Download as
Browse Code »

Commit 307f8268179c0b747b6707b1231dafe0f6cc88c8

Authored by Caio Salgado + Rafael Manzo
Committed by Paulo Meireles
1 parent 690ebf6e
Exists in master and in 28 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, stable, temp_ratings, tests, tests_fixies

[Mezuro] refactored create_metric_configuration and create_compound_metric_configuration

Showing 1 changed file with 14 additions and 14 deletions   Show diff stats
plugins/mezuro/controllers/mezuro_plugin_myprofile_controller.rb
  Diff comments   View file @307f826
... ... @@ -43,16 +43,14 @@ class MezuroPluginMyprofileController < ProfileController
43 43 end
44 44  
45 45 def create_metric_configuration
46   - @configuration_name = params[:configuration_name]
47 46 metric_configuration = new_metric_configuration_instance
48   - Kalibro::Client::MetricConfigurationClient.new.save(metric_configuration, @configuration_name)
  47 + generic_metric_configuration_creation(metric_configuration)
49 48 redirect_to "/#{profile.identifier}/#{@configuration_name.downcase.gsub(/\s/, '-')}"
50 49 end
51 50  
52 51 def create_compound_metric_configuration
53   - @configuration_name = params[:configuration_name]
54 52 compound_metric_configuration = new_compound_metric_configuration_instance
55   - Kalibro::Client::MetricConfigurationClient.new.save(compound_metric_configuration, @configuration_name)
  53 + generic_metric_configuration_creation(compound_metric_configuration)
56 54 redirect_to "/#{profile.identifier}/#{@configuration_name.downcase.gsub(/\s/, '-')}"
57 55 end
58 56  
... ... @@ -137,8 +135,6 @@ class MezuroPluginMyprofileController < ProfileController
137 135 redirect_to "/#{profile.identifier}/#{configuration_name.downcase.gsub(/\s/, '-')}"
138 136 end
139 137  
140   -
141   -
142 138 private
143 139  
144 140 def new_metric_configuration_instance
... ... @@ -154,26 +150,30 @@ class MezuroPluginMyprofileController < ProfileController
154 150 end
155 151  
156 152 def assign_metric_configuration_instance(metric_configuration)
157   - metric_configuration.metric.name = params[:metric_configuration][:metric][:name]
158   - metric_configuration.metric.description = params[:metric_configuration][:metric][:description]
  153 + assign_generic_metric_configuration(metric_configuration)
159 154 metric_configuration.metric.origin = params[:metric_configuration][:metric][:origin]
160   - metric_configuration.metric.scope = params[:metric_configuration][:metric][:scope]
161 155 metric_configuration.metric.language = params[:metric_configuration][:metric][:language]
162   - metric_configuration.code = params[:metric_configuration][:code]
163   - metric_configuration.weight = params[:metric_configuration][:weight]
164   - metric_configuration.aggregation_form = params[:metric_configuration][:aggregation_form]
165 156 metric_configuration
166 157 end
167 158  
168 159 def assign_compound_metric_configuration_instance(metric_configuration)
  160 + assign_generic_metric_configuration(metric_configuration)
  161 + metric_configuration.metric.script = params[:metric_configuration][:metric][:script]
  162 + metric_configuration
  163 + end
  164 +
  165 + def assign_generic_metric_configuration(metric_configuration)
169 166 metric_configuration.metric.name = params[:metric_configuration][:metric][:name]
170 167 metric_configuration.metric.description = params[:metric_configuration][:metric][:description]
171 168 metric_configuration.metric.scope = params[:metric_configuration][:metric][:scope]
172   - metric_configuration.metric.script = params[:metric_configuration][:metric][:script]
173 169 metric_configuration.code = params[:metric_configuration][:code]
174 170 metric_configuration.weight = params[:metric_configuration][:weight]
175 171 metric_configuration.aggregation_form = params[:metric_configuration][:aggregation_form]
176   - metric_configuration
  172 + end
  173 +
  174 + def generic_metric_configuration_creation(metric_configuration)
  175 + @configuration_name = params[:configuration_name]
  176 + Kalibro::Client::MetricConfigurationClient.new.save(metric_configuration, @configuration_name)
177 177 end
178 178  
179 179 def new_range_instance
... ...