social_network: Join community on login/signup

Join community if user log in or sign up after following a "Join" link within a community. (ActionItem3096)

social_network: Join community on login/signup
Join community if user log in or sign up after following a "Join" link within a community. (ActionItem3096)
Daniel
1 parent 0efa7f89
Showing 5 changed files with 26 additions and 19 deletions Show diff stats
app/controllers/public/account_controller.rb
app/controllers/public/profile_controller.rb
app/models/user.rb
app/views/user/mailer/activation_code.rhtml
features/signup.feature
@@ -17,6 +17,7 @@ class AccountController &lt; ApplicationController
     @user = User.find_by_activation_code(params[:activation_code]) if params[:activation_code]
     if @user and @user.activate
       @message = _("Your account has been activated, now you can log in!")
+      session[:join] = params[:join] unless params[:join].blank?
       render :action => 'login', :userlogin => @user.login
     else
       session[:notice] = _("It looks like you're trying to activate an account. Perhaps have already activated this account?")
@@ -35,6 +36,7 @@ class AccountController &lt; ApplicationController
     self.current_user ||= User.authenticate(params[:user][:login], params[:user][:password], environment) if params[:user]
     if logged_in?
+      join_community(self.current_user)
       if params[:remember_me] == "1"
         self.current_user.remember_me
         cookies[:auth_token] = { :value => self.current_user.remember_token , :expires => self.current_user.remember_token_expires_at }
@@ -91,6 +93,7 @@ class AccountController &lt; ApplicationController
           if session[:may_be_a_bot]
             return false unless verify_recaptcha :model=>@user, :message=>_('Captcha (the human test)')
           end
+          @user.community_to_join = session[:join]
           @user.signup!
           owner_role = Role.find_by_name('owner')
           @user.person.affiliate(@user.person, [owner_role]) if owner_role
@@ -101,6 +104,7 @@ class AccountController &lt; ApplicationController
           end
           if @user.activated?
             self.current_user = @user
+            join_community(@user)
             go_to_signup_initial_page
           else
             @register_pending = true
@@ -448,4 +452,12 @@ class AccountController &lt; ApplicationController
       redirect_back_or_default(default)
     end
   end
+
+  def join_community(user)
+    profile_to_join = session[:join]
+    unless profile_to_join.blank?
+     environment.profiles.find_by_identifier(profile_to_join).add_member(user.person)
+     session.delete(:join)
+    end
+  end
 end
@@ -3,7 +3,7 @@ class ProfileController &lt; PublicController
   needs_profile
   before_filter :check_access_to_profile, :except => [:join, :join_not_logged, :index, :add]
   before_filter :store_location, :only => [:join, :join_not_logged, :report_abuse, :send_mail]
-  before_filter :login_required, :only => [:add, :join, :join_not_logged, :leave, :unblock, :leave_scrap, :remove_scrap, :remove_activity, :view_more_activities, :view_more_network_activities, :report_abuse, :register_report, :leave_comment_on_activity, :send_mail]
+  before_filter :login_required, :only => [:add, :join, :leave, :unblock, :leave_scrap, :remove_scrap, :remove_activity, :view_more_activities, :view_more_network_activities, :report_abuse, :register_report, :leave_comment_on_activity, :send_mail]
   helper TagsHelper
@@ -97,21 +97,12 @@ class ProfileController &lt; PublicController
   end
   def join_not_logged
-    if request.post?
-      profile.add_member(user)
-      session[:notice] = _('%s administrator still needs to accept you as member.') % profile.name if profile.closed?
-      redirect_to_previous_location
+    session[:join] = profile.identifier
+
+    if user
+      redirect_to :controller => 'profile', :action => 'join'
     else
-      if user.memberships.include?(profile)
-        session[:notice] = _('You are already a member of %s.') % profile.name
-        redirect_to profile.url
-        return
-      end
-      if request.xhr?
-        render :layout => false
-      else
-        redirect_to profile.url
-      end
+      redirect_to :controller => '/account', :action => 'login'
     end
   end
@@ -50,6 +50,9 @@ class User &lt; ActiveRecord::Base
     self.person.preferred_domain && self.person.preferred_domain.name || self.environment.default_hostname(true)
   end
+  # virtual attribute used to stash which community to join on signup or login
+  attr_accessor :community_to_join
+
   class Mailer < ActionMailer::Base
     def activation_email_notify(user)
       user_email = "#{user.login}@#{user.email_domain}"
@@ -72,7 +75,8 @@ class User &lt; ActiveRecord::Base
         :activation_code => user.activation_code,
         :environment => user.environment.name,
         :url => user.environment.top_url,
-        :redirection => (true if user.return_to)
+        :redirection => (true if user.return_to),
+        :join => (user.community_to_join if user.community_to_join)
     end
     def signup_welcome_email(user)
 <%= _('Hi, %{recipient}!') % { :recipient => @recipient } %>
-<%= word_wrap(_('Welcome to %{environment}! To activate your account, follow the link: %{activation_url}') % { :environment => @environment, :activation_url => @url + url_for(:controller => :account, :action => :activate, :activation_code => @activation_code, :redirection => @redirection) }) %>
+<%= word_wrap(_('Welcome to %{environment}! To activate your account, follow the link: %{activation_url}') % { :environment => @environment, :activation_url => @url + url_for(:controller => :account, :action => :activate, :activation_code => @activation_code, :redirection => @redirection, :join => @join) }) %>
 <%= _("Greetings,") %>
@@ -275,7 +275,7 @@ Feature: signup
     And I fill in "Username" with "josesilva"
     And I fill in "Password" with "secret"
     And I press "Log in"
-    Then "Joao Silva" should be a member of "Free Software"
+    Then "José da Silva" should be a member of "Free Software"
   @selenium
   Scenario: join community on direct signup
@@ -297,4 +297,4 @@ Feature: signup
       | Full name             | José da Silva         |
     And wait for the captcha signup time
     And I press "Create my account"
-    Then "Joao Silva" should be a member of "Free Software"
+    Then "José da Silva" should be a member of "Free Software"
1	<%= _('Hi, %{recipient}!') % { :recipient => @recipient } %>	1	<%= _('Hi, %{recipient}!') % { :recipient => @recipient } %>
2		2
3	-<%= word_wrap(_('Welcome to %{environment}! To activate your account, follow the link: %{activation_url}') % { :environment => @environment, :activation_url => @url + url_for(:controller => :account, :action => :activate, :activation_code => @activation_code, :redirection => @redirection) }) %>	3	+<%= word_wrap(_('Welcome to %{environment}! To activate your account, follow the link: %{activation_url}') % { :environment => @environment, :activation_url => @url + url_for(:controller => :account, :action => :activate, :activation_code => @activation_code, :redirection => @redirection, :join => @join) }) %>
4		4
5	<%= _("Greetings,") %>	5	<%= _("Greetings,") %>
6		6
	@@ -275,7 +275,7 @@ Feature: signup		@@ -275,7 +275,7 @@ Feature: signup
275	And I fill in "Username" with "josesilva"	275	And I fill in "Username" with "josesilva"
276	And I fill in "Password" with "secret"	276	And I fill in "Password" with "secret"
277	And I press "Log in"	277	And I press "Log in"
278	- Then "Joao Silva" should be a member of "Free Software"	278	+ Then "José da Silva" should be a member of "Free Software"
279		279
280	@selenium	280	@selenium
281	Scenario: join community on direct signup	281	Scenario: join community on direct signup
	@@ -297,4 +297,4 @@ Feature: signup		@@ -297,4 +297,4 @@ Feature: signup
297	\| Full name \| José da Silva \|	297	\| Full name \| José da Silva \|
298	And wait for the captcha signup time	298	And wait for the captcha signup time
299	And I press "Create my account"	299	And I press "Create my account"
300	- Then "Joao Silva" should be a member of "Free Software"	300	+ Then "José da Silva" should be a member of "Free Software"