Download as
Browse Code »

Commit 4e6065c448a3461e55141c1d6ec4f1603fd4efa9

Authored by Rodrigo Souto
1 parent 208311e8
Exists in master and in 28 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, stable, temp_ratings, tests, tests_fixies

[stoa] Avoiding crash if no field is passed to matches

Showing 2 changed files with 5 additions and 1 deletions   Show diff stats
plugins/stoa/lib/stoa_plugin/usp_user.rb
  Diff comments   View file @4e6065c
@@ -15,7 +15,7 @@ class StoaPlugin::UspUser < ActiveRecord::Base @@ -15,7 +15,7 @@ class StoaPlugin::UspUser < ActiveRecord::Base
15 def self.matches?(usp_id, field, value) 15 def self.matches?(usp_id, field, value)
16 usp_id.to_s.gsub!(/[.-]/,'') 16 usp_id.to_s.gsub!(/[.-]/,'')
17 user = StoaPlugin::UspUser.find_by_codpes(usp_id.to_i) 17 user = StoaPlugin::UspUser.find_by_codpes(usp_id.to_i)
18 - return false if user.nil? || !user.respond_to?(field) || value.blank? 18 + return false if user.nil? || field.blank? || !user.respond_to?(field) || value.blank?
19 case field.to_sym 19 case field.to_sym
20 when :cpf 20 when :cpf
21 value.to_s.gsub!(/[.-]/,'') 21 value.to_s.gsub!(/[.-]/,'')
plugins/stoa/test/unit/usp_user_test.rb
  Diff comments   View file @4e6065c
@@ -43,5 +43,9 @@ class StoaPlugin::UspUserTest < ActiveSupport::TestCase @@ -43,5 +43,9 @@ class StoaPlugin::UspUserTest < ActiveSupport::TestCase
43 assert StoaPlugin::UspUser.exists?('0000123456') 43 assert StoaPlugin::UspUser.exists?('0000123456')
44 assert StoaPlugin::UspUser.matches?(123456, :cpf, '00012345678') 44 assert StoaPlugin::UspUser.matches?(123456, :cpf, '00012345678')
45 end 45 end
  46 +
  47 + should 'return false if field is nil' do
  48 + assert !StoaPlugin::UspUser.matches?(123456, nil, '00012345678')
  49 + end
46 end 50 end
47 51