Download as
Browse Code »

Commit 50a5337022c4a7aad7af6e575639daff6b3de80a

Authored by Lucas Melo
Committed by Rodrigo Souto
1 parent b29ff55e
Exists in master and in 28 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, stable, temp_ratings, tests, tests_fixies

external_feed: strip attributes style and class 

(ActionItem2650)
Showing 2 changed files with 23 additions and 0 deletions   Show diff stats
app/models/external_feed.rb
  Diff comments   View file @50a5337
@@ -11,6 +11,15 @@ class ExternalFeed < ActiveRecord::Base @@ -11,6 +11,15 @@ class ExternalFeed < ActiveRecord::Base
11 } 11 }
12 12
13 def add_item(title, link, date, content) 13 def add_item(title, link, date, content)
  14 + doc = Hpricot(content)
  15 + doc.search('*').each do |p|
  16 + if p.instance_of? Hpricot::Elem
  17 + p.remove_attribute 'style'
  18 + p.remove_attribute 'class'
  19 + end
  20 + end
  21 + content = doc.to_s
  22 +
14 article = TinyMceArticle.new(:name => title, :profile => blog.profile, :body => content, :published_at => date, :source => link, :profile => blog.profile, :parent => blog) 23 article = TinyMceArticle.new(:name => title, :profile => blog.profile, :body => content, :published_at => date, :source => link, :profile => blog.profile, :parent => blog)
15 unless blog.children.exists?(:slug => article.slug) 24 unless blog.children.exists?(:slug => article.slug)
16 article.save! 25 article.save!
test/unit/external_feed_test.rb
  Diff comments   View file @50a5337
@@ -152,4 +152,18 @@ class ExternalFeedTest < ActiveSupport::TestCase @@ -152,4 +152,18 @@ class ExternalFeedTest < ActiveSupport::TestCase
152 assert_equal 35, external_feed.fetched_at.min 152 assert_equal 35, external_feed.fetched_at.min
153 end 153 end
154 154
  155 + should 'strip content of style and class attributes' do
  156 + blog = create_blog
  157 + e = build(:external_feed, :blog => blog)
  158 + e.add_item('Article title', 'http://orig.link.invalid', Time.now, '<p style="color: red">Html content 1.</p>')
  159 + e.add_item('Article title 2', 'http://orig.link.invalid', Time.now, '<p class="myclass">Html content 2.</p>')
  160 + e.add_item('Article title 3', 'http://orig.link.invalid', Time.now, '<img src="noosfero.png" />')
  161 +
  162 + dd = []
  163 + Article.where(['parent_id = ?', blog.id]).all.each do |a|
  164 + dd << a.body.to_s.strip.gsub(/\s+/, ' ')
  165 + end
  166 + assert_equal '<img src="noosfero.png" /><p>Html content 1.</p><p>Html content 2.</p>', dd.sort.join
  167 + end
  168 +
155 end 169 end