Download as
Browse Code »

Commit 51d3ac08b10f2f063a6915b83e95329dd14613dd

Authored by Braulio Bhavamitra
1 parent 3c94729b
Exists in master and in 26 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, temp_ratings, tests, tests_fixies

plugins: don't crash on method_missing methods

Showing 2 changed files with 11 additions and 0 deletions   Show diff stats
lib/noosfero/plugin/manager.rb
  Diff comments   View file @51d3ac0
@@ -38,6 +38,8 @@ class Noosfero::Plugin::Manager @@ -38,6 +38,8 @@ class Noosfero::Plugin::Manager
38 end 38 end
39 39
40 def result_for plugin, event, *args 40 def result_for plugin, event, *args
  41 + # check if defined to avoid crash, as there is hotspots using method_missing
  42 + return unless plugin.respond_to? event
41 method = plugin.method event 43 method = plugin.method event
42 method.call *args if method.owner != Noosfero::Plugin 44 method.call *args if method.owner != Noosfero::Plugin
43 end 45 end
test/unit/plugin_manager_test.rb
  Diff comments   View file @51d3ac0
@@ -178,6 +178,15 @@ class PluginManagerTest < ActiveSupport::TestCase @@ -178,6 +178,15 @@ class PluginManagerTest < ActiveSupport::TestCase
178 assert_equal Plugin2, manager.fetch_first_plugin(:random_event) 178 assert_equal Plugin2, manager.fetch_first_plugin(:random_event)
179 end 179 end
180 180
  181 + should 'return nil if missing method is called' do
  182 + class Plugin1 < Noosfero::Plugin
  183 + end
  184 + Noosfero::Plugin.stubs(:all).returns(['PluginManagerTest::Plugin1'])
  185 + environment.enable_plugin(Plugin1)
  186 +
  187 + assert_equal nil, @manager.result_for(Plugin1.new, :content_remove_new)
  188 + end
  189 +
181 should 'parse macro' do 190 should 'parse macro' do
182 class Plugin1 < Noosfero::Plugin 191 class Plugin1 < Noosfero::Plugin
183 def macros 192 def macros