Download as
Browse Code »

Commit 5521d9b4c262a089c443049486451490378de88a

Authored by Antonio Terceiro
1 parent 4bad2f6a
Exists in master and in 28 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, stable, temp_ratings, tests, tests_fixies

Named scope to select non-spam comments 

ActionItem2306
Showing 2 changed files with 10 additions and 0 deletions   Show diff stats
app/models/comment.rb
  Diff comments   View file @5521d9b
@@ -10,6 +10,8 @@ class Comment < ActiveRecord::Base @@ -10,6 +10,8 @@ class Comment < ActiveRecord::Base
10 has_many :children, :class_name => 'Comment', :foreign_key => 'reply_of_id', :dependent => :destroy 10 has_many :children, :class_name => 'Comment', :foreign_key => 'reply_of_id', :dependent => :destroy
11 belongs_to :reply_of, :class_name => 'Comment', :foreign_key => 'reply_of_id' 11 belongs_to :reply_of, :class_name => 'Comment', :foreign_key => 'reply_of_id'
12 12
  13 + named_scope :without_spam, :conditions => ['spam IS NULL OR spam = ?', false]
  14 +
13 # unauthenticated authors: 15 # unauthenticated authors:
14 validates_presence_of :name, :if => (lambda { |record| !record.email.blank? }) 16 validates_presence_of :name, :if => (lambda { |record| !record.email.blank? })
15 validates_presence_of :email, :if => (lambda { |record| !record.name.blank? }) 17 validates_presence_of :email, :if => (lambda { |record| !record.name.blank? })
test/unit/comment_test.rb
  Diff comments   View file @5521d9b
@@ -437,4 +437,12 @@ class CommentTest < ActiveSupport::TestCase @@ -437,4 +437,12 @@ class CommentTest < ActiveSupport::TestCase
437 assert !c.ham? 437 assert !c.ham?
438 end 438 end
439 439
  440 + should 'be able to select non-spam comments' do
  441 + c1 = fast_create(Comment)
  442 + c2 = fast_create(Comment, :spam => false)
  443 + c3 = fast_create(Comment, :spam => true)
  444 +
  445 + assert_equivalent [c1,c2], Comment.without_spam
  446 + end
  447 +
440 end 448 end