Download as
Browse Code »

Commit 55e713093f3a6f5a7c8b3ca29202feaff0c4234b

Authored by Daniela Feitosa
Committed by Antonio Terceiro
1 parent 740e8524
Exists in master and in 28 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, stable, temp_ratings, tests, tests_fixies

ActionItem909: don't list UploadFile articles in the recent contents block

Showing 2 changed files with 17 additions and 6 deletions   Show diff stats
app/models/article.rb
  Diff comments   View file @55e7130
... ... @@ -89,12 +89,13 @@ class Article < ActiveRecord::Base
89 89 def self.recent(limit)
90 90 # FIXME this method is a horrible hack
91 91 options = { :limit => limit,
92   - :conditions => {
93   - :advertise => true,
94   - :public_article => true,
95   - :published => true,
96   - 'profiles.public_profile' => true
97   - },
  92 + :conditions => [
  93 + "advertise = ? AND
  94 + public_article = ? AND
  95 + published = ? AND
  96 + profiles.public_profile = ? AND
  97 + (articles.type != ? OR articles.type is NULL)", true, true, true, true, 'UploadedFile'
  98 + ],
98 99 :include => 'profile',
99 100 :order => 'articles.updated_at desc, articles.id desc'
100 101 }
... ...
test/unit/article_test.rb
  Diff comments   View file @55e7130
... ... @@ -197,6 +197,16 @@ class ArticleTest < Test::Unit::TestCase
197 197 assert_equal [ first, second ], Article.recent(2)
198 198 end
199 199  
  200 + should 'not show UploadedFile as recent' do
  201 + p = create_user('usr1').person
  202 + Article.destroy_all
  203 +
  204 + first = UploadedFile.new(:profile => p, :uploaded_data => fixture_file_upload('/files/rails.png', 'image/png')); first.save!
  205 + second = p.articles.build(:name => 'second'); second.save!
  206 +
  207 + assert_equal [ second ], Article.recent(nil)
  208 + end
  209 +
200 210 should 'require that subclasses define description' do
201 211 assert_raise NotImplementedError do
202 212 Article.description
... ...