Download as
Browse Code »

Commit 55ed4cb56e07bdfcb6bc23fcb953e3510aff57a6

Authored by Antonio Terceiro
1 parent 6548e2f2
Exists in master and in 28 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, stable, temp_ratings, tests, tests_fixies

ActionItem980: making it easier to find users 

In the console, specially
Showing 2 changed files with 8 additions and 0 deletions   Show diff stats
app/models/user.rb
  Diff comments   View file @55ed4cb
@@ -8,6 +8,10 @@ class User < ActiveRecord::Base @@ -8,6 +8,10 @@ class User < ActiveRecord::Base
8 N_('Password confirmation') 8 N_('Password confirmation')
9 N_('Terms accepted') 9 N_('Terms accepted')
10 10
  11 + def self.[](login)
  12 + self.find_by_login(login)
  13 + end
  14 +
11 # FIXME ugly workaround 15 # FIXME ugly workaround
12 def self.human_attribute_name(attrib) 16 def self.human_attribute_name(attrib)
13 case attrib.to_sym 17 case attrib.to_sym
test/unit/user_test.rb
  Diff comments   View file @55ed4cb
@@ -283,6 +283,10 @@ class UserTest < Test::Unit::TestCase @@ -283,6 +283,10 @@ class UserTest < Test::Unit::TestCase
283 assert !user.email_activation_pending? 283 assert !user.email_activation_pending?
284 end 284 end
285 285
  286 + should 'be able to use [] operator to find users by login' do
  287 + assert_equal users(:ze), User['ze']
  288 + end
  289 +
286 protected 290 protected
287 def new_user(options = {}) 291 def new_user(options = {})
288 user = User.new({ :login => 'quire', :email => 'quire@example.com', :password => 'quire', :password_confirmation => 'quire' }.merge(options)) 292 user = User.new({ :login => 'quire', :email => 'quire@example.com', :password => 'quire', :password_confirmation => 'quire' }.merge(options))