[Mezuro] Started refactoring module result controller and view.

Diego Camarinha · João M. M. da Silva
1 parent e64fac10
Showing 6 changed files with 40 additions and 33 deletions Show diff stats
plugins/mezuro/controllers/profile/mezuro_plugin_module_controller.rb
plugins/mezuro/lib/kalibro/metric_configuration_snapshot.rb
plugins/mezuro/lib/kalibro/metric_result.rb
plugins/mezuro/lib/mezuro_plugin/helpers/content_viewer_helper.rb
plugins/mezuro/public/javascripts/project_content.js
plugins/mezuro/views/mezuro_plugin_module/_module_result.rhtml
@@ -3,10 +3,10 @@ class MezuroPluginModuleController &lt; MezuroPluginProfileController
   append_view_path File.join(File.dirname(__FILE__) + '/../../views')
  
   def module_result
-    @content = profile.articles.find(params[:id])
-    @module_result = @content.module_result(params)
-    @module = @module_result.module
-    @module_label = "#{@module.name} (#{@module.granularity})"
+    project_content = profile.articles.find(params[:id])
+    repositories = project_content.repositories
+    @module_result = project_content.module_result(repositories.first.id)
+    @metric_results = Kalibro::MetricResult.metric_results_of(@module_result.id)
     if project_content_has_errors?
       redirect_to_error_page(@content.errors[:base])
     else
@@ -15,9 +15,9 @@ class MezuroPluginModuleController &lt; MezuroPluginProfileController
   end
  
   def module_metrics_history
-    metric_name = params[:metric_name]
+    module_result_id = params[:module_result_id]
     @content = profile.articles.find(params[:id])
-    module_history = @content.result_history(params[:module_name])
+    module_history = @content.result_history(params[:module_result_id])
     if project_content_has_errors?
       redirect_to_error_page(@content.errors[:base])
     else
@@ -28,7 +28,7 @@ class MezuroPluginModuleController &lt; MezuroPluginProfileController
  
   def module_grade_history
     @content = profile.articles.find(params[:id])
-    modules_results = @content.result_history(params[:module_name])
+    modules_results = @content.result_history(params[:module_result_id])
     if project_content_has_errors?
       redirect_to_error_page(@content.errors[:base])
     else
@@ -42,16 +42,12 @@ class MezuroPluginModuleController &lt; MezuroPluginProfileController
   private
  
   def filtering_metric_history(metric_name, module_history)
-    metrics_history = module_history.map do |module_result|
-      [module_result.metric_results, format_date_to_simple_form(module_result.date)]
-    end
-    metric_history =  metrics_history.map do |metric_results_with_date|
-      [(metric_results_with_date.first.select do |metric_result|
-        metric_result.metric.name.delete("() ") == metric_name
-      end).first, metric_results_with_date.last]
+    metrics_history = module_history.select do |m|
+      m.metric_result.configuration.metric.name.delete("() ") == metric_name
     end
-    metric_history.map do |metric_result_with_date|
-      [metric_result_with_date.first.value, metric_result_with_date.last]
+    
+    metric_history = metrics_history.map do |m|
+      [m.metric_result.value, format_date_to_simple_form(m.date)]
     end
   end
  
@@ -11,7 +11,11 @@ class Kalibro::MetricConfigurationSnapshot &lt; Kalibro::Model
   end
  
   def range=(value)
-    @range = Kalibro::Range.to_object value
+    @range = Kalibro::RangeSnapshot.to_object value
+  end
+
+  def range_snapshot
+    range
   end
  
 end
@@ -10,6 +10,10 @@ class Kalibro::MetricResult &lt; Kalibro::Model
     @configuration = Kalibro::MetricConfigurationSnapshot.to_object value
   end
  
+  def metric_configuration_snapshot
+    configuration
+  end
+
   def error=(value)
     @error = Kalibro::Throwable.to_object value
   end
@@ -45,8 +45,8 @@ class MezuroPlugin::Helpers::ContentViewerHelper
     selected_option.first
   end
  
-  def self.format_name(metric_result)
-    metric_result.configuration.metric.name.delete("() ")
+  def self.format_name(metric_configuration_snapshot)
+    metric_configuration_snapshot.metric.name.delete("() ")
   end
  
   def self.get_license_option(selected)
@@ -18,7 +18,7 @@ function display_metric_history() {
   var metric_name = jQuery(this).attr('show-metric-history');
   toggle_mezuro("." + metric_name);
   metricName = metric_name;
-  callAction('module', 'module_metrics_history', {module_name: module_name, metric_name: metric_name}, show_metrics);
+  callAction('module', 'module_metrics_history', {module_id: module_id, module_result_id: module_result_id}, show_metrics);
   return false;
 }
  
-<h5><%= _('Metric results for: ') + @module_label %> </h5>
+<% module_name = @module_result.module.name
+<h5><%= _('Metric results for: #{module_name} (#{@module_result.module.granularity}) ') %> </h5>
  
 <hr/>
 <div class="zoomable-image">
@@ -12,26 +13,28 @@
     </tr>
   </thead>
   <tbody>
-    <% @module_result.metric_results.each do |metric_result|  %>
-      <% range = metric_result.range %>
-      <% if !range.nil? %>
+    <% @metric_results.each do |metric_result|  %>
+      <% metric_configuration_snapshot = metric_result.metric_configuration_snapshot%>
+      <% range_snapshot = metric_configuration_snapshot.range_snapshot %>
+      <% formatted_name = MezuroPlugin::Helpers::ContentViewerHelper.format_name(metric_configuration_snapshot) %>
+      <% if !range_snapshot.nil? %>
         <tr>
-          <td style="width: 74%"><a href="#" show-metric-history="<%= MezuroPlugin::Helpers::ContentViewerHelper.format_name(metric_result) %>" data-module-name="<%= @module.name %>"><%= metric_result.metric.name %></a></td>
+          <td style="width: 74%"><a href="#" show-metric-history="<%= formatted_name %>" data-module-name="<%= module_name %>"><%= metric_configuration_snapshot.metric.name %></a></td>
           <td><%= MezuroPlugin::Helpers::ContentViewerHelper.format_grade(metric_result.value) %></td>
-          <td><%= metric_result.weight %></td>
-          <td style="background-color: #<%= range.color[2..-1] %>">
-            <span title="<%= range.comments %>" >
-              <%= range.label %>
+          <td><%= metric_configuration_snapshot.weight %></td>
+          <td style="background-color: #<%= range_snapshot.color %>">
+            <span title="<%= range_snapshot.comments %>" >
+              <%= range_snapshot.label %>
             </span>
           </td>
         </tr>	  
-        <tr class="<%= MezuroPlugin::Helpers::ContentViewerHelper.format_name(metric_result) %>" style="display: none;">
+        <tr class="<%= formatted_name %>" style="display: none;">
           <td colspan="3">
-            <div id='historical-<%= MezuroPlugin::Helpers::ContentViewerHelper.format_name(metric_result) %>'>
+            <div id='historical-<%= formatted_name %>'>
             </div>
           </td>
           <td align="right">
-            <%= range.comments.nil? ? '' : range.comments %>
+            <%= range_snapshot.comments.nil? ? '' : range_snapshot.comments %>
           </td> 
         </tr>
       <% end %>
@@ -43,7 +46,7 @@
         <div id='historical-grade' style="display: none;"></div>
       </td>
       <td align = "right">
-        <a href="#" show-grade-history="<%= @module_result.module.name %>" data-module-name="<%= @module.name%>" >
+        <a href="#" show-grade-history="<%= module_name %>" data-module-name="<%= module_name%>" >
           <strong>
             <%= _('Grade:') %>
             <%= "%.02f" % @module_result.grade %>
...	...	@@ -3,10 +3,10 @@ class MezuroPluginModuleController < MezuroPluginProfileController
3	3	append_view_path File.join(File.dirname(__FILE__) + '/../../views')
4	4
5	5	def module_result
6		- @content = profile.articles.find(params[:id])
7		- @module_result = @content.module_result(params)
8		- @module = @module_result.module
9		- @module_label = "#{@module.name} (#{@module.granularity})"
	6	+ project_content = profile.articles.find(params[:id])
	7	+ repositories = project_content.repositories
	8	+ @module_result = project_content.module_result(repositories.first.id)
	9	+ @metric_results = Kalibro::MetricResult.metric_results_of(@module_result.id)
10	10	if project_content_has_errors?
11	11	redirect_to_error_page(@content.errors[:base])
12	12	else
...	...	@@ -15,9 +15,9 @@ class MezuroPluginModuleController < MezuroPluginProfileController
15	15	end
16	16
17	17	def module_metrics_history
18		- metric_name = params[:metric_name]
	18	+ module_result_id = params[:module_result_id]
19	19	@content = profile.articles.find(params[:id])
20		- module_history = @content.result_history(params[:module_name])
	20	+ module_history = @content.result_history(params[:module_result_id])
21	21	if project_content_has_errors?
22	22	redirect_to_error_page(@content.errors[:base])
23	23	else
...	...	@@ -28,7 +28,7 @@ class MezuroPluginModuleController < MezuroPluginProfileController
28	28
29	29	def module_grade_history
30	30	@content = profile.articles.find(params[:id])
31		- modules_results = @content.result_history(params[:module_name])
	31	+ modules_results = @content.result_history(params[:module_result_id])
32	32	if project_content_has_errors?
33	33	redirect_to_error_page(@content.errors[:base])
34	34	else
...	...	@@ -42,16 +42,12 @@ class MezuroPluginModuleController < MezuroPluginProfileController
42	42	private
43	43
44	44	def filtering_metric_history(metric_name, module_history)
45		- metrics_history = module_history.map do \|module_result\|
46		- [module_result.metric_results, format_date_to_simple_form(module_result.date)]
47		- end
48		- metric_history = metrics_history.map do \|metric_results_with_date\|
49		- [(metric_results_with_date.first.select do \|metric_result\|
50		- metric_result.metric.name.delete("() ") == metric_name
51		- end).first, metric_results_with_date.last]
	45	+ metrics_history = module_history.select do \|m\|
	46	+ m.metric_result.configuration.metric.name.delete("() ") == metric_name
52	47	end
53		- metric_history.map do \|metric_result_with_date\|
54		- [metric_result_with_date.first.value, metric_result_with_date.last]
	48	+
	49	+ metric_history = metrics_history.map do \|m\|
	50	+ [m.metric_result.value, format_date_to_simple_form(m.date)]
55	51	end
56	52	end
57	53
...	...
...	...	@@ -11,7 +11,11 @@ class Kalibro::MetricConfigurationSnapshot < Kalibro::Model
11	11	end
12	12
13	13	def range=(value)
14		- @range = Kalibro::Range.to_object value
	14	+ @range = Kalibro::RangeSnapshot.to_object value
	15	+ end
	16	+
	17	+ def range_snapshot
	18	+ range
15	19	end
16	20
17	21	end
...	...
...	...	@@ -10,6 +10,10 @@ class Kalibro::MetricResult < Kalibro::Model
10	10	@configuration = Kalibro::MetricConfigurationSnapshot.to_object value
11	11	end
12	12
	13	+ def metric_configuration_snapshot
	14	+ configuration
	15	+ end
	16	+
13	17	def error=(value)
14	18	@error = Kalibro::Throwable.to_object value
15	19	end
...	...
...	...	@@ -45,8 +45,8 @@ class MezuroPlugin::Helpers::ContentViewerHelper
45	45	selected_option.first
46	46	end
47	47
48		- def self.format_name(metric_result)
49		- metric_result.configuration.metric.name.delete("() ")
	48	+ def self.format_name(metric_configuration_snapshot)
	49	+ metric_configuration_snapshot.metric.name.delete("() ")
50	50	end
51	51
52	52	def self.get_license_option(selected)
...	...
...	...	@@ -18,7 +18,7 @@ function display_metric_history() {
18	18	var metric_name = jQuery(this).attr('show-metric-history');
19	19	toggle_mezuro("." + metric_name);
20	20	metricName = metric_name;
21		- callAction('module', 'module_metrics_history', {module_name: module_name, metric_name: metric_name}, show_metrics);
	21	+ callAction('module', 'module_metrics_history', {module_id: module_id, module_result_id: module_result_id}, show_metrics);
22	22	return false;
23	23	}
24	24
...	...
1		-<h5><%= _('Metric results for: ') + @module_label %> </h5>
	1	+<% module_name = @module_result.module.name
	2	+<h5><%= _('Metric results for: #{module_name} (#{@module_result.module.granularity}) ') %> </h5>
2	3
3	4	<hr/>
4	5	<div class="zoomable-image">
...	...	@@ -12,26 +13,28 @@
12	13	</tr>
13	14	</thead>
14	15	<tbody>
15		- <% @module_result.metric_results.each do \|metric_result\| %>
16		- <% range = metric_result.range %>
17		- <% if !range.nil? %>
	16	+ <% @metric_results.each do \|metric_result\| %>
	17	+ <% metric_configuration_snapshot = metric_result.metric_configuration_snapshot%>
	18	+ <% range_snapshot = metric_configuration_snapshot.range_snapshot %>
	19	+ <% formatted_name = MezuroPlugin::Helpers::ContentViewerHelper.format_name(metric_configuration_snapshot) %>
	20	+ <% if !range_snapshot.nil? %>
18	21	<tr>
19		- <td style="width: 74%"><a href="#" show-metric-history="<%= MezuroPlugin::Helpers::ContentViewerHelper.format_name(metric_result) %>" data-module-name="<%= @module.name %>"><%= metric_result.metric.name %></a></td>
	22	+ <td style="width: 74%"><a href="#" show-metric-history="<%= formatted_name %>" data-module-name="<%= module_name %>"><%= metric_configuration_snapshot.metric.name %></a></td>
20	23	<td><%= MezuroPlugin::Helpers::ContentViewerHelper.format_grade(metric_result.value) %></td>
21		- <td><%= metric_result.weight %></td>
22		- <td style="background-color: #<%= range.color[2..-1] %>">
23		- <span title="<%= range.comments %>" >
24		- <%= range.label %>
	24	+ <td><%= metric_configuration_snapshot.weight %></td>
	25	+ <td style="background-color: #<%= range_snapshot.color %>">
	26	+ <span title="<%= range_snapshot.comments %>" >
	27	+ <%= range_snapshot.label %>
25	28	</span>
26	29	</td>
27	30	</tr>
28		- <tr class="<%= MezuroPlugin::Helpers::ContentViewerHelper.format_name(metric_result) %>" style="display: none;">
	31	+ <tr class="<%= formatted_name %>" style="display: none;">
29	32	<td colspan="3">
30		- <div id='historical-<%= MezuroPlugin::Helpers::ContentViewerHelper.format_name(metric_result) %>'>
	33	+ <div id='historical-<%= formatted_name %>'>
31	34	</div>
32	35	</td>
33	36	<td align="right">
34		- <%= range.comments.nil? ? '' : range.comments %>
	37	+ <%= range_snapshot.comments.nil? ? '' : range_snapshot.comments %>
35	38	</td>
36	39	</tr>
37	40	<% end %>
...	...	@@ -43,7 +46,7 @@
43	46	<div id='historical-grade' style="display: none;"></div>
44	47	</td>
45	48	<td align = "right">
46		- <a href="#" show-grade-history="<%= @module_result.module.name %>" data-module-name="<%= @module.name%>" >
	49	+ <a href="#" show-grade-history="<%= module_name %>" data-module-name="<%= module_name%>" >
47	50	<strong>
48	51	<%= _('Grade:') %>
49	52	<%= "%.02f" % @module_result.grade %>
...	...