Changes neeed to get test/unit/city_test.rb running

It looks to me that this fixes all the problems that would happen at load time.

Changes neeed to get test/unit/city_test.rb running
It looks to me that this fixes all the problems that would happen at load time.
Antonio Terceiro
1 parent de9842bd
Showing 36 changed files with 54 additions and 242 deletions Show diff stats
app/controllers/application_controller.rb
app/models/change_password.rb
app/models/contact.rb
app/models/event.rb
config/initializers/plugins.rb
test/functional/application_controller_test.rb
test/functional/contact_controller_test.rb
test/functional/maps_controller_test.rb
test/functional/search_controller_test.rb
test/noosfero_doc_test.rb
test/test_helper.rb
test/unit/application_helper_test.rb
test/unit/certifier_test.rb
test/unit/city_test.rb
test/unit/contact_test.rb
test/unit/countries_helper_test.rb
test/unit/doc_section_test.rb
test/unit/doc_topic_test.rb
test/unit/enterprise_test.rb
test/unit/language_helper_test.rb
@@ -59,7 +59,11 @@ class ApplicationController &lt; ActionController::Base
   # declares that the given <tt>actions</tt> cannot be accessed by other HTTP
   # method besides POST.
   def self.post_only(actions, redirect = { :action => 'index'})
-    verify :method => :post, :only => actions, :redirect_to => redirect
+    before_filter(:only => actions) do |controller|
+      if !controller.request.post?
+        controller.redirect_to redirect
+      end
+    end
   end
  
   helper_method :current_person, :current_person
@@ -4,7 +4,7 @@ class ChangePassword &lt; Task
  
   def self.human_attribute_name(attrib)
     case attrib.to_sym
-    when :login:
+    when :login
       _('Username')
     when :email
       _('e-mail')
-class Contact < ActiveRecord::Base #WithoutTable
-  tableless :columns => [
-    [:name, :string],
-    [:subject, :string],
-    [:message, :string],
-    [:email, :string],
-    [:state, :string],
-    [:city, :string],
-    [:receive_a_copy, :boolean]
-  ]
+class Contact
+
+  include ActiveModel::Validations
+
+  def initialize(attributes = nil)
+    if attributes
+      attributes.each do |attr,value|
+        self.send("#{attr}=", value)
+      end
+    end
+  end
+
+  attr_accessor :name
+  attr_accessor :subject
+  attr_accessor :message
+  attr_accessor :email
+  attr_accessor :state
+  attr_accessor :city
+  attr_accessor :receive_a_copy
   attr_accessor :dest
   attr_accessor :sender
  
+require 'noosfero/translatable_content'
+
 class Event < Article
  
   def self.type_name
@@ -1,7 +0,0 @@
-require 'noosfero/plugin'
-require 'noosfero/plugin/hot_spot'
-require 'noosfero/plugin/manager'
-require 'noosfero/plugin/active_record'
-require 'noosfero/plugin/mailer_base'
-require 'noosfero/plugin/settings'
-Noosfero::Plugin.init_system if $NOOSFERO_LOAD_PLUGINS
+# encoding: UTF-8
 require File.dirname(__FILE__) + '/../test_helper'
 require 'test_controller'
  
+# encoding: UTF-8
 require File.dirname(__FILE__) + '/../test_helper'
 require 'contact_controller'
  
+# encoding: UTF-8
 require File.dirname(__FILE__) + '/../test_helper'
 require 'maps_controller'
  
+# encoding: UTF-8
 require File.dirname(__FILE__) + '/../test_helper'
 require 'search_controller'
  
+# encoding: UTF-8
 require 'mocha'
  
 module Noosfero::DocTest
 ENV["RAILS_ENV"] = "test"
  
 require File.expand_path(File.dirname(__FILE__) + "/../config/environment")
-require 'test_help'
+require 'rails/test_help'
 require 'mocha'
 require 'tidy'
 require 'hpricot'
  
 require 'noosfero/test'
+require 'authenticated_test_helper'
 require File.dirname(__FILE__) + '/factories'
 require File.dirname(__FILE__) + '/noosfero_doc_test'
 require File.dirname(__FILE__) + '/action_tracker_test_helper'
@@ -44,7 +45,7 @@ class ActiveSupport::TestCase
   # Add more helper methods to be used by all tests here...
  
   # for fixture_file_upload
-  include ActionController::TestProcess
+  include ActionDispatch::TestProcess
  
   include Noosfero::Factory
  
@@ -52,14 +53,6 @@ class ActiveSupport::TestCase
  
   fixtures :environments, :roles
  
-  def setup
-    TestSolr.disable
-  end
-
-  def teardown
-    TestSolr.disable
-  end
-
   def self.all_fixtures
     Dir.glob(File.join(Rails.root, 'test', 'fixtures', '*.yml')).each do |item|
       fixtures File.basename(item).sub(/\.yml$/, '').to_s
+# encoding: UTF-8
 require File.dirname(__FILE__) + '/../test_helper'
  
 class ApplicationHelperTest < ActiveSupport::TestCase
+# encoding: UTF-8
 require File.dirname(__FILE__) + '/../test_helper'
  
 class CertifierTest < ActiveSupport::TestCase
-require File.dirname(__FILE__) + '/../test_helper'
+require 'test_helper.rb'
  
 class CityTest < ActiveSupport::TestCase
   # Replace this with your real tests.
-require File.dirname(__FILE__) + '/../test_helper'
+require 'test_helper'
  
 class ContactTest < ActiveSupport::TestCase
  
+# encoding: UTF-8
 require File.dirname(__FILE__) + '/../test_helper'
  
 class CountriesHelperTest < ActiveSupport::TestCase
+# encoding: UTF-8
 require 'test_helper'
  
 class DocSectionTest < ActiveSupport::TestCase
+# encoding: UTF-8
 require File.dirname(__FILE__) + '/../test_helper'
  
 class DocTopicTest < ActiveSupport::TestCase
+# encoding: UTF-8
 require File.dirname(__FILE__) + '/../test_helper'
  
 class EnterpriseTest < ActiveSupport::TestCase
+# encoding: UTF-8
 require File.dirname(__FILE__) + '/../test_helper'
  
 class LanguageHelperTest < ActiveSupport::TestCase
+# encoding: UTF-8
 require File.dirname(__FILE__) + '/../test_helper'
  
 class ManageProductsHelperTest < ActiveSupport::TestCase
+# encoding: UTF-8
 require File.dirname(__FILE__) + '/../test_helper'
  
 class PersonTest < ActiveSupport::TestCase
+# encoding: UTF-8
 require File.dirname(__FILE__) + '/../test_helper'
  
 class ProfileTest < ActiveSupport::TestCase
+# encoding: UTF-8
 require File.dirname(__FILE__) + '/../test_helper'
  
 class QualifierTest < ActiveSupport::TestCase
+# encoding: UTF-8
 require File.dirname(__FILE__) + '/../test_helper'
  
 # tests for String core extension. See lib/noosfero/core_ext/string.rb
+# encoding: UTF-8
 require File.dirname(__FILE__) + '/../test_helper'
  
 class TagsHelperTest < ActiveSupport::TestCase
+# encoding: UTF-8
 require File.dirname(__FILE__) + '/../test_helper'
  
 class TinyMceArticleTest < ActiveSupport::TestCase
+# encoding: UTF-8
 require File.dirname(__FILE__) + '/../test_helper'
  
 class UserTest < ActiveSupport::TestCase
@@ -1,20 +0,0 @@
-Copyright (c) 2008 [name of plugin creator]
-
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of this software and associated documentation files (the
-"Software"), to deal in the Software without restriction, including
-without limitation the rights to use, copy, modify, merge, publish,
-distribute, sublicense, and/or sell copies of the Software, and to
-permit persons to whom the Software is furnished to do so, subject to
-the following conditions:
-
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
@@ -1,30 +0,0 @@
-ActiveRecordTableless
-=====================
-
-Rails plugin allowing ActiveRecord models to be used with validations but 
-without being backed by a database table.
-
-
-Install
-=======
-
-script/plugin install git://github.com/robinsp/active_record_tableless.git
-
-
-Example
-=======
-
-class TablelessModel < ActiveRecord::Base
-  tableless :columns => [
-                [:email, :string],
-                [:password, :string],
-                [:password_confirmation] 
-            ]
-  
-  validates_presence_of     :email, :password, :password_confirmation
-  validates_confirmation_of :password
-  
-end
-
-
-Copyright (c) 2008 [name of plugin creator], released under the MIT license
@@ -1,22 +0,0 @@
-require 'rake'
-require 'rake/testtask'
-require 'rake/rdoctask'
-
-desc 'Default: run unit tests.'
-task :default => :test
-
-desc 'Test the active_record_tableless plugin.'
-Rake::TestTask.new(:test) do |t|
-  t.libs << 'lib'
-  t.pattern = 'test/**/*_test.rb'
-  t.verbose = true
-end
-
-desc 'Generate documentation for the active_record_tableless plugin.'
-Rake::RDocTask.new(:rdoc) do |rdoc|
-  rdoc.rdoc_dir = 'rdoc'
-  rdoc.title    = 'ActiveRecordTableless'
-  rdoc.options << '--line-numbers' << '--inline-source'
-  rdoc.rdoc_files.include('README')
-  rdoc.rdoc_files.include('lib/**/*.rb')
-end
@@ -1,2 +0,0 @@
-# Include hook code here
-ActiveRecord::Base.send(:include, ActiveRecord::Tableless)
 \ No newline at end of file
@@ -1,56 +0,0 @@
-module ActiveRecord
-  module Tableless
-    
-    def self.included(base)
-      # 'base' is assumed to be ActiveRecord::Base
-      base.extend(ClassMethods)
-    end
-    
-    module ClassMethods
-      def tableless( options = {} )
-        include ActiveRecord::Tableless::InstanceMethods
-        raise "No columns defined" unless options.has_key?(:columns) && !options[:columns].empty?
-        
-        self.extend(MetaMethods)
-        
-        for column_args in options[:columns]
-          column( *column_args )
-        end
-        
-      end
-    end
-    
-    module MetaMethods 
-      def columns()
-        @columns ||= []
-      end
-      
-      def column(name, sql_type = nil, default = nil, null = true)
-        columns << ActiveRecord::ConnectionAdapters::Column.new(name.to_s, default, sql_type.to_s, null)
-        reset_column_information
-      end
-      
-      # Do not reset @columns
-      def reset_column_information
-        generated_methods.each { |name| undef_method(name) }
-        @column_names = @columns_hash = @content_columns = @dynamic_methods_hash = @read_methods = nil
-      end
-    end
-    
-    module InstanceMethods 
-      def create_or_update
-        errors.empty?
-      end
-      
-      def saved!(with_id = 1)
-        self.id = with_id
-        
-        def self.new_record?
-          false
-        end
-      end
-      alias_method :exists!, :saved!
-    end
-    
-  end
-end
 \ No newline at end of file
@@ -1,4 +0,0 @@
-# desc "Explaining what the task does"
-# task :active_record_tableless do
-#   # Task goes here
-# end
@@ -1,75 +0,0 @@
-require 'test/unit'
-require 'rubygems'
-require 'active_record'
-require File.dirname(__FILE__) + '/../lib/active_record/tableless'
-
-
-
-ActiveRecord::Base.establish_connection(  {
-  :adapter => 'sqlite3',
-  :database => ":memory:",
-  :timeout => 500
-  
-})
-
-ActiveRecord::Base.send(:include, ActiveRecord::Tableless)
-
-class TablelessModel < ActiveRecord::Base
-  tableless :columns => [
-                [:email, :string],
-                [:password, :string],
-                [:password_confirmation] ]
-  
-  validates_presence_of     :email, :password, :password_confirmation
-  validates_confirmation_of :password
-  
-end
-
-class ActiveRecordTablelessTest < Test::Unit::TestCase
-  
-  def setup
-    super
-    @valid_attributes = {
-      :email => "robin@bogus.com", 
-      :password => "password", 
-      :password_confirmation => "password"
-    }
-  end
-  
-  def test_create
-    assert TablelessModel.create(@valid_attributes).valid?
-  end
-  
-  def test_validations
-    # Just check a few validations to make sure we didn't break ActiveRecord::Validations::ClassMethods
-    assert_not_nil TablelessModel.create(@valid_attributes.merge(:email => "")).errors[:email]
-    assert_not_nil TablelessModel.create(@valid_attributes.merge(:password => "")).errors[:password]
-    assert_not_nil TablelessModel.create(@valid_attributes.merge(:password_confirmation => "")).errors[:password]
-  end
-  
-  def test_save
-    assert TablelessModel.new(@valid_attributes).save 
-    assert !TablelessModel.new(@valid_attributes.merge(:password => "no_match")).save 
-  end
-  
-  def test_valid?
-    assert TablelessModel.new(@valid_attributes).valid? 
-    assert !TablelessModel.new(@valid_attributes.merge(:password => "no_match")).valid? 
-  end
-  
-  
-  def test_exists!
-    m = TablelessModel.new(@valid_attributes)
-    
-    assert_nil m.id 
-    assert m.new_record?
-    
-    m.exists!
-    assert_equal 1, m.id 
-    assert !m.new_record?
-    
-    m.exists!(250)
-    assert_equal 250, m.id 
-    assert !m.new_record?
-  end
-end
@@ -48,8 +48,8 @@ module NoosferoHttpCaching
 end
  
 unless Rails.env.development?
-  middleware = ActionController::Dispatcher.middleware
-  cookies_mw = ActionController::Session::CookieStore
+  middleware = Noosfero::Application.config.middleware
+  cookies_mw = ActionDispatch::Session::CookieStore
   ActionController::Base.send(:include, NoosferoHttpCaching)
   middleware.insert_before(cookies_mw, NoosferoHttpCaching::Middleware)
 end
...	...	@@ -59,7 +59,11 @@ class ApplicationController < ActionController::Base
59	59	# declares that the given <tt>actions</tt> cannot be accessed by other HTTP
60	60	# method besides POST.
61	61	def self.post_only(actions, redirect = { :action => 'index'})
62		- verify :method => :post, :only => actions, :redirect_to => redirect
	62	+ before_filter(:only => actions) do \|controller\|
	63	+ if !controller.request.post?
	64	+ controller.redirect_to redirect
	65	+ end
	66	+ end
63	67	end
64	68
65	69	helper_method :current_person, :current_person
...	...
...	...	@@ -4,7 +4,7 @@ class ChangePassword < Task
4	4
5	5	def self.human_attribute_name(attrib)
6	6	case attrib.to_sym
7		- when :login:
	7	+ when :login
8	8	_('Username')
9	9	when :email
10	10	_('e-mail')
...	...
1		-class Contact < ActiveRecord::Base #WithoutTable
2		- tableless :columns => [
3		- [:name, :string],
4		- [:subject, :string],
5		- [:message, :string],
6		- [:email, :string],
7		- [:state, :string],
8		- [:city, :string],
9		- [:receive_a_copy, :boolean]
10		- ]
	1	+class Contact
	2	+
	3	+ include ActiveModel::Validations
	4	+
	5	+ def initialize(attributes = nil)
	6	+ if attributes
	7	+ attributes.each do \|attr,value\|
	8	+ self.send("#{attr}=", value)
	9	+ end
	10	+ end
	11	+ end
	12	+
	13	+ attr_accessor :name
	14	+ attr_accessor :subject
	15	+ attr_accessor :message
	16	+ attr_accessor :email
	17	+ attr_accessor :state
	18	+ attr_accessor :city
	19	+ attr_accessor :receive_a_copy
11	20	attr_accessor :dest
12	21	attr_accessor :sender
13	22
...	...
	1	+require 'noosfero/translatable_content'
	2	+
1	3	class Event < Article
2	4
3	5	def self.type_name
...	...
...	...	@@ -1,7 +0,0 @@
1		-require 'noosfero/plugin'
2		-require 'noosfero/plugin/hot_spot'
3		-require 'noosfero/plugin/manager'
4		-require 'noosfero/plugin/active_record'
5		-require 'noosfero/plugin/mailer_base'
6		-require 'noosfero/plugin/settings'
7		-Noosfero::Plugin.init_system if $NOOSFERO_LOAD_PLUGINS
	1	+# encoding: UTF-8
1	2	require File.dirname(__FILE__) + '/../test_helper'
2	3	require 'test_controller'
3	4
...	...
	1	+# encoding: UTF-8
1	2	require File.dirname(__FILE__) + '/../test_helper'
2	3	require 'contact_controller'
3	4
...	...
	1	+# encoding: UTF-8
1	2	require File.dirname(__FILE__) + '/../test_helper'
2	3	require 'maps_controller'
3	4
...	...
	1	+# encoding: UTF-8
1	2	require File.dirname(__FILE__) + '/../test_helper'
2	3	require 'search_controller'
3	4
...	...
	1	+# encoding: UTF-8
1	2	require 'mocha'
2	3
3	4	module Noosfero::DocTest
...	...