Download as
Browse Code »

Commit 6cbd22d0c45a2d240c18795834fe2143cc69b632

Authored by Diego Camarinha
Committed by Caio
1 parent 80e4ce40
Exists in master and in 28 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, stable, temp_ratings, tests, tests_fixies

[Mezuro] Continued refactoring tests.

Showing 3 changed files with 37 additions and 3 deletions   Show diff stats
plugins/mezuro/lib/mezuro_plugin/configuration_content.rb
  Diff comments   View file @6cbd22d
@@ -17,7 +17,7 @@ class MezuroPlugin::ConfigurationContent < Article @@ -17,7 +17,7 @@ class MezuroPlugin::ConfigurationContent < Article
17 end 17 end
18 end 18 end
19 19
20 - def configuration 20 + def configuration #FIXME invalid method name
21 Kalibro::Client::ConfigurationClient.configuration(name) 21 Kalibro::Client::ConfigurationClient.configuration(name)
22 end 22 end
23 23
plugins/mezuro/test/unit/mezuro_plugin/metric_configuration_content_test.rb
  Diff comments   View file @6cbd22d
@@ -18,7 +18,27 @@ class MetricConfigurationContentTest < ActiveSupport::TestCase @@ -18,7 +18,27 @@ class MetricConfigurationContentTest < ActiveSupport::TestCase
18 assert_equal 'Sets of thresholds to interpret a metric', MezuroPlugin::MetricConfigurationContent.description 18 assert_equal 'Sets of thresholds to interpret a metric', MezuroPlugin::MetricConfigurationContent.description
19 end 19 end
20 20
21 - should 'return metric configuration' do  
22 - pending "Need refactoring" 21 + should 'have an html view' do
  22 + assert_not_nil @metric_configuration.to_html
23 end 23 end
  24 +
  25 + #should 'return metric configuration' do
  26 + # pending "Need refactoring"
  27 + #end
  28 +
  29 + should 'send metric configuration to service after saving' do
  30 + @metric_configuration.expects :send_metric_configuration_to_service
  31 + @metric_configuration.run_callbacks :after_save
  32 + end
  33 +
  34 + should 'send correct metric configuration to service' do
  35 + Kalibro::Client::MetricConfigurationClient.expects(:save).with(@metric_configuration)
  36 + @metric_configuration.send :send_metric_configuration_to_service
  37 + end
  38 +
  39 + should 'remove metric configuration from service' do
  40 + Kalibro::Client::MetricConfigurationClient.expects(:remove).with(@metric_configuration.name)
  41 + @metric_configuration.send :remove_metric_configuration_from_service
  42 + end
  43 +
24 end 44 end
plugins/mezuro/test/unit/mezuro_plugin/project_content_test.rb
  Diff comments   View file @6cbd22d
1 require "test_helper" 1 require "test_helper"
2 2
3 require "#{RAILS_ROOT}/plugins/mezuro/test/fixtures/project_fixtures" 3 require "#{RAILS_ROOT}/plugins/mezuro/test/fixtures/project_fixtures"
  4 +require "#{RAILS_ROOT}/plugins/mezuro/test/fixtures/project_result_fixtures"
4 5
5 class ProjectContentTest < ActiveSupport::TestCase 6 class ProjectContentTest < ActiveSupport::TestCase
6 7
@@ -42,6 +43,19 @@ class ProjectContentTest &lt; ActiveSupport::TestCase @@ -42,6 +43,19 @@ class ProjectContentTest &lt; ActiveSupport::TestCase
42 Kalibro::Client::ProjectResultClient.expects(:last_result).with(@content.name).returns(project_result) 43 Kalibro::Client::ProjectResultClient.expects(:last_result).with(@content.name).returns(project_result)
43 assert_equal project_result, @content.project_result 44 assert_equal project_result, @content.project_result
44 end 45 end
  46 +
  47 + #def get_date_result(date)
  48 + # client = Kalibro::Client::ProjectResultClient.new
  49 + # @project_result ||= client.has_results_before(name, date) ? client.last_result_before(name, date) : client.first_result_after(name, date)
  50 + #end
  51 +
  52 + should 'get date result from service when has_result_before is true' do
  53 + client = mock
  54 + Kalibro::Client::ProjectResultClient.expects(:new).returns(client)
  55 + client.expects(:has_results_before).with(@project.name, "2012-05-22T22:00:33+04:00").returns(true)
  56 + client.expects(:last_result_before).with(@project.name, "2012-05-22T22:00:33+04:00").returns(project_result)
  57 + assert_equal project_result, @content.project_result
  58 + end
45 59
46 should 'get module result from service' do 60 should 'get module result from service' do
47 mock_project_client 61 mock_project_client