Download as
Browse Code »

Commit 6e6ba4e8586c66fcecd37bf7263590aae6289a10

Authored by Joenio Costa
1 parent d90a9743
Exists in master and in 22 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, temp_ratings

check if Article exists before trying to get its ID 

resolves issue #79
Showing 2 changed files with 10 additions and 1 deletions   Show diff stats
plugins/metadata/lib/metadata_plugin.rb
  Diff comments   View file @6e6ba4e
... ... @@ -23,7 +23,7 @@ class MetadataPlugin < Noosfero::Plugin
23 23 },
24 24 content_viewer: {
25 25 variable: proc do
26   - if profile and profile.home_page_id == @page.id
  26 + if profile and @page and profile.home_page_id == @page.id
27 27 @profile
28 28 elsif @page.respond_to? :encapsulated_file
29 29 @page.encapsulated_file
... ...
plugins/metadata/test/functional/content_viewer_controller_test.rb
  Diff comments   View file @6e6ba4e
... ... @@ -48,4 +48,13 @@ class ContentViewerControllerTest < ActionController::TestCase
48 48 assert_tag tag: 'meta', attributes: { property: 'og:image', content: /\/images\/x.png/ }
49 49 end
50 50  
  51 + should 'render not_found page properly' do
  52 + assert_equal false, Article.exists?(:slug => 'non-existing-page')
  53 + assert_nothing_raised do
  54 + get :view_page, profile: profile.identifier, page: [ 'non-existing-page' ]
  55 + assert_response 404 # not found
  56 + assert_template 'not_found'
  57 + end
  58 + end
  59 +
51 60 end
... ...