Added custom roles management for organizations

Signed-off-by: Hebert Douglas <hebertdougl@gmail.com> Signed-off-by: Filipe Ribeiro <firibeiro77@live.com> Signed-off-by: André Bernardes <andrebsguedes@gmail.com>

Added custom roles management for organizations
Signed-off-by: Hebert Douglas <hebertdougl@gmail.com> Signed-off-by: Filipe Ribeiro <firibeiro77@live.com> Signed-off-by: André Bernardes <andrebsguedes@gmail.com>
André Guedes · André Guedes
1 parent 12d04695
Showing 15 changed files with 190 additions and 6 deletions Show diff stats
app/controllers/admin/role_controller.rb
app/controllers/my_profile/profile_members_controller.rb
app/controllers/my_profile/profile_roles_controller.rb
app/models/organization.rb
app/models/profile.rb
app/views/profile_editor/index.html.erb
app/views/profile_members/change_role.html.erb
app/views/profile_roles/_form.html.erb
app/views/profile_roles/destroy.html.erb
app/views/profile_roles/edit.html.erb
app/views/profile_roles/index.html.erb
app/views/profile_roles/new.html.erb
app/views/profile_roles/show.html.erb
db/migrate/20150203143051_add_reference_to_role.rb
vendor/plugins/access_control/lib/role.rb
@@ -2,7 +2,7 @@ class RoleController &lt; AdminController
   protect 'manage_environment_roles', :environment
   def index
-    @roles = environment.roles.find(:all)
+    @roles = environment.roles.find(:all, :conditions => {:profile_id => nil})
   end
   def new
@@ -58,6 +58,7 @@ class ProfileMembersController &lt; MyProfileController
   def change_role
     @roles = Profile::Roles.organization_member_roles(environment.id)
+    @custom_roles = Profile::Roles.organization_custom_roles(environment.id, profile.id)
     begin
       @member = profile.members.find(params[:id])
     rescue ActiveRecord::RecordNotFound
@@ -0,0 +1,65 @@
+class ProfileRolesController < MyProfileController
+
+  include RoleHelper
+
+  def index
+    @roles = environment.roles.find(:all, :conditions => {:profile_id => profile.id} )
+  end
+
+  def new
+    @role = Role.new
+  end
+
+  def create
+    @role = Role.create({:name => params[:role][:name], :permissions => params[:role][:permissions], :profile_id => profile.id, :environment => environment }, :without_protection => true)
+    if @role.save
+      redirect_to :action => 'show', :id => @role
+    else
+      session[:notice] = _('Failed to create role')
+      render :action => 'new'
+    end
+  end
+
+  def show
+    @role = environment.roles.find(params[:id])
+  end
+
+  def edit
+    @role = environment.roles.find(params[:id])
+  end
+
+  def destroy
+    @role = environment.roles.find(params[:id])
+    @members = profile.members_by_role(@role)
+    @roles_list = Profile::Roles.organization_all_roles(environment.id, profile.id)
+    @roles_list.delete(@role)
+  end
+
+  def remove
+    @role = environment.roles.find(params[:id])
+    @members = profile.members_by_role(@role)
+    new_roles = params[:roles] ? environment.roles.find(params[:roles].select{|r|!r.to_i.zero?}) : []
+    @members.each do |person|
+      member_roles = person.find_roles(profile).map(&:role) + new_roles
+      person.define_roles(member_roles, profile)
+    end
+    if @role.destroy
+      session[:notice] = _('Role successfuly removed!')
+    else
+      session[:notice] = _('Failed to remove role!')
+    end
+    redirect_to :action => 'index'
+  end
+
+  def update
+    @role = environment.roles.find(params[:id])
+    if @role.update_attributes(params[:role])
+      redirect_to :action => 'show', :id => @role
+    else
+      session[:notice] = _('Failed to edit role')
+      render :action => 'edit'
+    end
+  end
+
+
+end
@@ -29,6 +29,8 @@ class Organization &lt; Profile
   has_many :mailings, :class_name => 'OrganizationMailing', :foreign_key => :source_id, :as => 'source'
+  has_many :custom_roles, :class_name => 'Role', :foreign_key => :profile_id
+
   scope :more_popular, :order => 'members_count DESC'
   validate :presence_of_required_fieds, :unless => :is_template
@@ -43,10 +43,16 @@ class Profile &lt; ActiveRecord::Base
       find_role('editor', env_id)
     end
     def self.organization_member_roles(env_id)
-      all_roles(env_id).select{ |r| r.key.match(/^profile_/) unless r.key.blank? }
+      all_roles(env_id, nil).select{ |r| r.key.match(/^profile_/) unless r.key.blank? }
     end
-    def self.all_roles(env_id)
-      Role.all :conditions => { :environment_id => env_id }
+    def self.organization_custom_roles(env_id, profile_id)
+      all_roles(env_id, profile_id).select{ |r| r.key.match(/^profile_/) unless r.key.blank? }
+    end
+    def self.organization_all_roles(env_id, profile_id)
+      self.organization_member_roles(env_id) + self.organization_custom_roles(env_id, profile_id)
+    end
+    def self.all_roles(env_id, profile_id)
+      Role.all :conditions => { :profile_id => profile_id, :environment_id => env_id }
     end
     def self.method_missing(m, *args, &block)
       role = find_role(m, args[0])
@@ -28,6 +28,8 @@
   <%= control_panel_button(_('Manage Content'), 'cms', :controller => 'cms') %>
+  <%= control_panel_button(_('Manage Roles'), 'roles', :controller => 'profile_roles') %>
+
   <% unless profile.enterprise? %>
     <%= case profile.blogs.count
       when 0
 <h3> <%= _('Changing role of %s') % @member.name %> </h3>
 <%= labelled_form_for :member, :url => {:action => 'update_roles'} do |f| %>
-  
-  <%= _('Roles:') %> <br>
+
+  <h4><%= _('Roles:') %></h4>
   <% @roles.each do |r| %>
     <%= labelled_check_box(r.name, 'roles[]', r.id, @associations.map(&:role).include?(r) ) %><br/>
     <ul class="role-permissions">
@@ -11,6 +11,17 @@
       <% end %>
     </ul>
   <% end %>
+  <% unless @custom_roles.empty? %>
+    <h4><%= _('Custom Roles:') %></h4>
+    <% @custom_roles.each do |r| %>
+    <%= labelled_check_box(r.name, 'roles[]', r.id, @associations.map(&:role).include?(r) ) %><br/>
+    <ul class="role-permissions">
+      <% r.permissions.each do |p| %>
+      <li> <%= permission_name(p) %> </li>
+      <% end %>
+    </ul>
+    <% end %>
+  <% end %>
   <%= hidden_field_tag 'person', @member.id %>
   <% button_bar do %>
@@ -0,0 +1,22 @@
+<%= error_messages_for :role %>
+
+<%= labelled_form_for :role, :url => (mode == :edit) ? {:action => 'update', :id => role} : {:action => 'create'} do |f| %>
+
+  <%= required_fields_message %>
+
+  <%= required f.text_field(:name) %>
+
+  <% permissions.each do |key| %>
+  <div class="permissions <%= key.downcase %>">
+    <h4><%= _('%s Permissions:' % key) %></h4>
+    <% ActiveRecord::Base::PERMISSIONS[key].keys.each do |p| %>
+      <%= check_box_tag("role[permissions][]", p, role.has_permission?(p), { :id => p }) %>
+      <%= content_tag(:label, permission_name(p), { :for => p }) %><br/>
+    <% end %>
+  </div>
+  <% end %>
+
+  <% button_bar do %>
+    <%= submit_button('save', (mode == :edit) ? _('Save changes') : _('Create role'), :cancel => {:action => 'index'} ) %>
+  <% end %>
+<% end %>
@@ -0,0 +1,23 @@
+<h2> <%= _("Deleting #{@role.name}") %> </h2>
+
+<% if @members.nil? || @members.empty? %>
+  <p><%= _('This role is not being currently used.')%></p>
+  <p><%= _('Are you sure you want to delete this role?') %></p>
+
+  <% button_bar do %>
+    <%= button(:remove, _('Yes, I am sure'), {:action => 'remove', :id => @role.id}, :method => :post) %>
+    <%= button(:cancel, _('No, I gave up'), {:action => 'index'}) %>
+  <% end %>
+<% else %>
+  <p><%= _('There are members currently using this role.')%></p>
+  <p><%= _('To which role do you want to change them?') %></p>
+  <%= labelled_form_for :role, :url => { :action => 'remove', :id => @role.id } do |f| %>
+    <% @roles_list.each do |role| %>
+      <%= check_box_tag("roles[]", role.id, false ,{:id => role.key}) %>
+      <%= content_tag(:label, role.name, { :for => role.key }) %><br/>
+    <% end %>
+    <% button_bar do %>
+    <%= submit_button('save',_('Delete role'), :cancel => {:action => 'index'} ) %>
+    <% end %>
+  <% end %>
+<% end %>
@@ -0,0 +1,3 @@
+<h2> <%= _("Editing #{@role.name}") %> </h2>
+
+<%= render :partial => 'form', :locals => { :mode => :edit, :role => @role, :permissions => [@role.kind] } %>
@@ -0,0 +1,24 @@
+<h1><%= _('Manage user roles') %></h1>
+
+<table>
+  <tr>
+    <th><%= _('Role') %></th>
+    <th><%= _('Actions') %></th>
+  </tr>
+  <% @roles.each do |role| %>
+    <tr>
+      <td>
+        <%= link_to role.name, :action => 'show', :id => role %>
+      </td>
+      <td>
+        <%= button_without_text :edit, _('Edit'), :action => 'edit', :id => role %>
+        <%= button_without_text :delete, _('Delete'), :action => 'destroy', :id => role %>
+      </td>
+    </tr>
+  <% end %>
+</table>
+
+<% button_bar do %>
+  <%= button :add, _('Create a new role'), :action => 'new' %>
+  <%= button :back, _('Back to control panel'), :controller => 'profile_editor' %>
+<% end %>
@@ -0,0 +1,3 @@
+<h2> <%= _("Create a new role") %> </h2>
+
+<%= render :partial => 'form', :locals => { :mode => :create, :role => @role, :permissions => ['Profile'] } %>
@@ -0,0 +1,13 @@
+<h1> <%= _(@role.name)  %></h1>
+
+<h3> <%= _('Permissions') %> </h3>
+<ul>
+  <% @role.permissions.each do |p| %>
+    <li> <%= permission_name(p) %> </li> 
+  <% end %>
+</ul>
+
+<% button_bar do %>
+  <%= button :edit, _('Edit'), :action => 'edit', :id => @role %>
+  <%= button :back, _('Back to roles management'), :action => 'index' %>
+<% end %>
@@ -0,0 +1,8 @@
+class AddReferenceToRole < ActiveRecord::Migration
+  def self.up
+    add_column :roles, :profile_id, :integer
+  end
+  def self.down
+    remove_column :roles , :profile_id
+  end
+end
@@ -4,6 +4,7 @@ class Role &lt; ActiveRecord::Base
   has_many :role_assignments, :dependent => :destroy
   belongs_to :environment
+  belongs_to :organization
   serialize :permissions, Array
   validates_presence_of :name
   validates_uniqueness_of :name, :scope => :environment_id
	@@ -2,7 +2,7 @@ class RoleController < AdminController		@@ -2,7 +2,7 @@ class RoleController < AdminController
2	protect 'manage_environment_roles', :environment	2	protect 'manage_environment_roles', :environment
3		3
4	def index	4	def index
5	- @roles = environment.roles.find(:all)	5	+ @roles = environment.roles.find(:all, :conditions => {:profile_id => nil})
6	end	6	end
7		7
8	def new	8	def new
	@@ -58,6 +58,7 @@ class ProfileMembersController < MyProfileController		@@ -58,6 +58,7 @@ class ProfileMembersController < MyProfileController
58		58
59	def change_role	59	def change_role
60	@roles = Profile::Roles.organization_member_roles(environment.id)	60	@roles = Profile::Roles.organization_member_roles(environment.id)
		61	+ @custom_roles = Profile::Roles.organization_custom_roles(environment.id, profile.id)
61	begin	62	begin
62	@member = profile.members.find(params[:id])	63	@member = profile.members.find(params[:id])
63	rescue ActiveRecord::RecordNotFound	64	rescue ActiveRecord::RecordNotFound
@@ -0,0 +1,65 @@		@@ -0,0 +1,65 @@
	1	+class ProfileRolesController < MyProfileController
	2	+
	3	+ include RoleHelper
	4	+
	5	+ def index
	6	+ @roles = environment.roles.find(:all, :conditions => {:profile_id => profile.id} )
	7	+ end
	8	+
	9	+ def new
	10	+ @role = Role.new
	11	+ end
	12	+
	13	+ def create
	14	+ @role = Role.create({:name => params[:role][:name], :permissions => params[:role][:permissions], :profile_id => profile.id, :environment => environment }, :without_protection => true)
	15	+ if @role.save
	16	+ redirect_to :action => 'show', :id => @role
	17	+ else
	18	+ session[:notice] = _('Failed to create role')
	19	+ render :action => 'new'
	20	+ end
	21	+ end
	22	+
	23	+ def show
	24	+ @role = environment.roles.find(params[:id])
	25	+ end
	26	+
	27	+ def edit
	28	+ @role = environment.roles.find(params[:id])
	29	+ end
	30	+
	31	+ def destroy
	32	+ @role = environment.roles.find(params[:id])
	33	+ @members = profile.members_by_role(@role)
	34	+ @roles_list = Profile::Roles.organization_all_roles(environment.id, profile.id)
	35	+ @roles_list.delete(@role)
	36	+ end
	37	+
	38	+ def remove
	39	+ @role = environment.roles.find(params[:id])
	40	+ @members = profile.members_by_role(@role)
	41	+ new_roles = params[:roles] ? environment.roles.find(params[:roles].select{\|r\|!r.to_i.zero?}) : []
	42	+ @members.each do \|person\|
	43	+ member_roles = person.find_roles(profile).map(&:role) + new_roles
	44	+ person.define_roles(member_roles, profile)
	45	+ end
	46	+ if @role.destroy
	47	+ session[:notice] = _('Role successfuly removed!')
	48	+ else
	49	+ session[:notice] = _('Failed to remove role!')
	50	+ end
	51	+ redirect_to :action => 'index'
	52	+ end
	53	+
	54	+ def update
	55	+ @role = environment.roles.find(params[:id])
	56	+ if @role.update_attributes(params[:role])
	57	+ redirect_to :action => 'show', :id => @role
	58	+ else
	59	+ session[:notice] = _('Failed to edit role')
	60	+ render :action => 'edit'
	61	+ end
	62	+ end
	63	+
	64	+
	65	+end
	@@ -29,6 +29,8 @@ class Organization < Profile		@@ -29,6 +29,8 @@ class Organization < Profile
29		29
30	has_many :mailings, :class_name => 'OrganizationMailing', :foreign_key => :source_id, :as => 'source'	30	has_many :mailings, :class_name => 'OrganizationMailing', :foreign_key => :source_id, :as => 'source'
31		31
		32	+ has_many :custom_roles, :class_name => 'Role', :foreign_key => :profile_id
		33	+
32	scope :more_popular, :order => 'members_count DESC'	34	scope :more_popular, :order => 'members_count DESC'
33		35
34	validate :presence_of_required_fieds, :unless => :is_template	36	validate :presence_of_required_fieds, :unless => :is_template
	@@ -28,6 +28,8 @@		@@ -28,6 +28,8 @@
28		28
29	<%= control_panel_button(_('Manage Content'), 'cms', :controller => 'cms') %>	29	<%= control_panel_button(_('Manage Content'), 'cms', :controller => 'cms') %>
30		30
		31	+ <%= control_panel_button(_('Manage Roles'), 'roles', :controller => 'profile_roles') %>
		32	+
31	<% unless profile.enterprise? %>	33	<% unless profile.enterprise? %>
32	<%= case profile.blogs.count	34	<%= case profile.blogs.count
33	when 0	35	when 0
@@ -0,0 +1,22 @@		@@ -0,0 +1,22 @@
	1	+<%= error_messages_for :role %>
	2	+
	3	+<%= labelled_form_for :role, :url => (mode == :edit) ? {:action => 'update', :id => role} : {:action => 'create'} do \|f\| %>
	4	+
	5	+ <%= required_fields_message %>
	6	+
	7	+ <%= required f.text_field(:name) %>
	8	+
	9	+ <% permissions.each do \|key\| %>
	10	+ <div class="permissions <%= key.downcase %>">
	11	+ <h4><%= _('%s Permissions:' % key) %></h4>
	12	+ <% ActiveRecord::Base::PERMISSIONS[key].keys.each do \|p\| %>
	13	+ <%= check_box_tag("role[permissions][]", p, role.has_permission?(p), { :id => p }) %>
	14	+ <%= content_tag(:label, permission_name(p), { :for => p }) %><br/>
	15	+ <% end %>
	16	+ </div>
	17	+ <% end %>
	18	+
	19	+ <% button_bar do %>
	20	+ <%= submit_button('save', (mode == :edit) ? _('Save changes') : _('Create role'), :cancel => {:action => 'index'} ) %>
	21	+ <% end %>
	22	+<% end %>
@@ -0,0 +1,23 @@		@@ -0,0 +1,23 @@
	1	+<h2> <%= _("Deleting #{@role.name}") %> </h2>
	2	+
	3	+<% if @members.nil? \|\| @members.empty? %>
	4	+ <p><%= _('This role is not being currently used.')%></p>
	5	+ <p><%= _('Are you sure you want to delete this role?') %></p>
	6	+
	7	+ <% button_bar do %>
	8	+ <%= button(:remove, _('Yes, I am sure'), {:action => 'remove', :id => @role.id}, :method => :post) %>
	9	+ <%= button(:cancel, _('No, I gave up'), {:action => 'index'}) %>
	10	+ <% end %>
	11	+<% else %>
	12	+ <p><%= _('There are members currently using this role.')%></p>
	13	+ <p><%= _('To which role do you want to change them?') %></p>
	14	+ <%= labelled_form_for :role, :url => { :action => 'remove', :id => @role.id } do \|f\| %>
	15	+ <% @roles_list.each do \|role\| %>
	16	+ <%= check_box_tag("roles[]", role.id, false ,{:id => role.key}) %>
	17	+ <%= content_tag(:label, role.name, { :for => role.key }) %><br/>
	18	+ <% end %>
	19	+ <% button_bar do %>
	20	+ <%= submit_button('save',_('Delete role'), :cancel => {:action => 'index'} ) %>
	21	+ <% end %>
	22	+ <% end %>
	23	+<% end %>
@@ -0,0 +1,3 @@		@@ -0,0 +1,3 @@
	1	+<h2> <%= _("Editing #{@role.name}") %> </h2>
	2	+
	3	+<%= render :partial => 'form', :locals => { :mode => :edit, :role => @role, :permissions => [@role.kind] } %>
@@ -0,0 +1,24 @@		@@ -0,0 +1,24 @@
	1	+<h1><%= _('Manage user roles') %></h1>
	2	+
	3	+<table>
	4	+ <tr>
	5	+ <th><%= _('Role') %></th>
	6	+ <th><%= _('Actions') %></th>
	7	+ </tr>
	8	+ <% @roles.each do \|role\| %>
	9	+ <tr>
	10	+ <td>
	11	+ <%= link_to role.name, :action => 'show', :id => role %>
	12	+ </td>
	13	+ <td>
	14	+ <%= button_without_text :edit, _('Edit'), :action => 'edit', :id => role %>
	15	+ <%= button_without_text :delete, _('Delete'), :action => 'destroy', :id => role %>
	16	+ </td>
	17	+ </tr>
	18	+ <% end %>
	19	+</table>
	20	+
	21	+<% button_bar do %>
	22	+ <%= button :add, _('Create a new role'), :action => 'new' %>
	23	+ <%= button :back, _('Back to control panel'), :controller => 'profile_editor' %>
	24	+<% end %>
@@ -0,0 +1,3 @@		@@ -0,0 +1,3 @@
	1	+<h2> <%= _("Create a new role") %> </h2>
	2	+
	3	+<%= render :partial => 'form', :locals => { :mode => :create, :role => @role, :permissions => ['Profile'] } %>