Download as
Browse Code »

Commit 7f3da1f1f310e50282bf7ef3f5c973a0724e67d5

Authored by Daniela Feitosa
Committed by Antonio Terceiro
1 parent b0660bd6
Exists in master and in 28 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, stable, temp_ratings, tests, tests_fixies

ActionItem1146: limit has a default and must be a number

Showing 2 changed files with 11 additions and 1 deletions   Show diff stats
app/models/recent_documents_block.rb
  Diff comments   View file @7f3da1f
... ... @@ -12,7 +12,7 @@ class RecentDocumentsBlock < Block
12 12 _('This block lists your recent content.')
13 13 end
14 14  
15   - settings_items :limit
  15 + settings_items :limit, :type => :integer, :default => 5
16 16  
17 17 include ActionController::UrlWriter
18 18 def content
... ...
test/unit/recent_documents_block_test.rb
  Diff comments   View file @7f3da1f
... ... @@ -44,6 +44,16 @@ class RecentDocumentsBlockTest < Test::Unit::TestCase
44 44 assert_no_match /href=.*\/testinguser\/first/, output
45 45 end
46 46  
  47 + should 'store limit as a number' do
  48 + block.limit = ''
  49 + assert block.limit.is_a?(Fixnum)
  50 + end
  51 +
  52 + should 'have a non-zero default' do
  53 + block.limit = nil
  54 + assert block.limit > 0
  55 + end
  56 +
47 57 should 'display a link to sitemap with title "All content"' do
48 58 expects(:link_to).with('All content', :controller => 'profile', :action => 'sitemap', :profile => profile.identifier)
49 59 expects(:_).with('All content').returns('All content')
... ...