Returning 0 on price_description_percentage when price is 0

(ActionItem2273)

Returning 0 on price_description_percentage when price is 0
(ActionItem2273)
Daniela Feitosa
1 parent 3d461d73
Showing 2 changed files with 23 additions and 0 deletions Show diff stats
app/models/product.rb
test/unit/product_test.rb
@@ -196,6 +196,7 @@ class Product &lt; ActiveRecord::Base
   end
  
   def price_description_percentage
+    return 0 if price.blank? || price.zero?
     total_production_cost * 100 / price
   end
  
@@ -510,4 +510,26 @@ class ProductTest &lt; Test::Unit::TestCase
     assert_equal "50.00", product.formatted_value(:inputs_cost)
   end
  
+  should 'return 0 on price_description_percentage by default' do
+    assert_equal 0, Product.new.price_description_percentage
+  end
+
+  should 'return 0 on price_description_percentage if price is 0' do
+    product = fast_create(Product, :price => 0)
+
+    assert_equal 0, product.price_description_percentage
+  end
+
+  should 'return 0 on price_description_percentage if price is not defined' do
+    product = fast_create(Product)
+
+    assert_equal 0, product.price_description_percentage
+  end
+
+  should 'return 0 on price_description_percentage if total_production_cost is 0' do
+    product = fast_create(Product, :price => 50)
+
+    assert_equal 0, product.price_description_percentage
+  end
+
 end
...	...	@@ -196,6 +196,7 @@ class Product < ActiveRecord::Base
196	196	end
197	197
198	198	def price_description_percentage
	199	+ return 0 if price.blank? \|\| price.zero?
199	200	total_production_cost * 100 / price
200	201	end
201	202
...	...
...	...	@@ -510,4 +510,26 @@ class ProductTest < Test::Unit::TestCase
510	510	assert_equal "50.00", product.formatted_value(:inputs_cost)
511	511	end
512	512
	513	+ should 'return 0 on price_description_percentage by default' do
	514	+ assert_equal 0, Product.new.price_description_percentage
	515	+ end
	516	+
	517	+ should 'return 0 on price_description_percentage if price is 0' do
	518	+ product = fast_create(Product, :price => 0)
	519	+
	520	+ assert_equal 0, product.price_description_percentage
	521	+ end
	522	+
	523	+ should 'return 0 on price_description_percentage if price is not defined' do
	524	+ product = fast_create(Product)
	525	+
	526	+ assert_equal 0, product.price_description_percentage
	527	+ end
	528	+
	529	+ should 'return 0 on price_description_percentage if total_production_cost is 0' do
	530	+ product = fast_create(Product, :price => 50)
	531	+
	532	+ assert_equal 0, product.price_description_percentage
	533	+ end
	534	+
513	535	end
...	...