Download as
Browse Code »

Commit 9d1bd7a8d4170623632ea272cde3150822aaadfd

Authored by Braulio Bhavamitra
2 parents aca12460 783b0692
Exists in master and in 27 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, temp_ratings, tests, tests_fixies

Merge branch 'custom_activation_check_time' into 'master' 

New configuration to define when user activation check will perform

See merge request !455
Showing 4 changed files with 15 additions and 4 deletions   Show diff stats
app/models/user.rb
  Diff comments   View file @9d1bd7a
... ... @@ -363,6 +363,6 @@ class User < ActiveRecord::Base
363 363  
364 364 def delay_activation_check
365 365 return if person.is_template?
366   - Delayed::Job.enqueue(UserActivationJob.new(self.id), {:priority => 0, :run_at => 72.hours.from_now})
  366 + Delayed::Job.enqueue(UserActivationJob.new(self.id), {:priority => 0, :run_at => (NOOSFERO_CONF['hours_until_user_activation_check'] || 72).hours.from_now})
367 367 end
368 368 end
... ...
config/noosfero.yml.dist
  Diff comments   View file @9d1bd7a
... ... @@ -9,6 +9,7 @@ development:
9 9 googlemaps_initial_zoom: 4
10 10 exception_recipients: [admin@example.com]
11 11 max_upload_size: 5MB
  12 + hours_until_user_activation_check: 72
12 13  
13 14 test:
14 15  
... ...
test/unit/user_activation_job_test.rb
  Diff comments   View file @9d1bd7a
1 1 require_relative "../test_helper"
2 2  
3   -class NotifyActivityToProfilesJobTest < ActiveSupport::TestCase
  3 +class UserActivationJobTest < ActiveSupport::TestCase
4 4  
5 5 should 'create job on user creation' do
6 6 user = new_user :login => 'test1'
... ...
test/unit/user_test.rb
  Diff comments   View file @9d1bd7a
... ... @@ -526,9 +526,19 @@ class UserTest &lt; ActiveSupport::TestCase
526 526 assert user.activated?
527 527 end
528 528  
529   - should 'delay activation check' do
  529 + should 'delay activation check with default time' do
530 530 user = new_user
531   - assert_match /UserActivationJob/, Delayed::Job.last.handler
  531 + job = Delayed::Job.last
  532 + assert_match /UserActivationJob/, job.handler
  533 + assert_equal 72, ((job.run_at - user.created_at)/1.hour).round
  534 + end
  535 +
  536 + should 'delay activation check with custom time' do
  537 + NOOSFERO_CONF.stubs(:[]).with('hours_until_user_activation_check').returns(240)
  538 + user = new_user
  539 + job = Delayed::Job.last
  540 + assert_match /UserActivationJob/, job.handler
  541 + assert_equal 240, ((job.run_at - user.created_at)/1.hour).round
532 542 end
533 543  
534 544 should 'not create job to check activation to template users' do
... ...