Fix migration to run at a reasonable time

Antonio Terceiro
1 parent 43378edc
Showing 2 changed files with 34 additions and 2 deletions Show diff stats
db/migrate/20100928000952_aggressive_indexing_strategy2.rb
db/schema.rb
 class AggressiveIndexingStrategy2 < ActiveRecord::Migration
   def self.up
-    execute("delete from action_tracker_notifications where id not in (select distinct(atn.id) from action_tracker_notifications as atn JOIN action_tracker_notifications as t ON  (t.profile_id = atn.profile_id and t.action_tracker_id = atn.action_tracker_id and atn.id < t.id))")
+
+    say 'Removing duplicate notification records ...'
+    buffer = ''
+    removed = 0
+    select_all(
+      'select min(id) as min_id, action_tracker_id, profile_id, count(*)
+      from action_tracker_notifications
+      group by action_tracker_id, profile_id
+      having count(*) > 1'
+    ).each do |duplicate|
+      buffer += ('delete from action_tracker_notifications
+        where
+          profile_id = %d AND
+          action_tracker_id = %s AND
+        id > %d;
+        ' % [duplicate['profile_id'], duplicate['action_tracker_id'], duplicate['min_id']]
+      )
+      if removed % 100 == 0
+        execute buffer
+        say "Deleted " + removed.to_s
+        buffer = ''
+      end
+      removed += 1
+    end
+
+    if !buffer.empty?
+      execute buffer
+    end
+
     add_index(:action_tracker_notifications, :profile_id)
     add_index(:action_tracker_notifications, :action_tracker_id)
     add_index(:action_tracker_notifications, [:profile_id, :action_tracker_id], :unique => true)
@@ -9,7 +9,7 @@
 #
 # It's strongly recommended to check this file into your version control system.
-ActiveRecord::Schema.define(:version => 20100923160040) do
+ActiveRecord::Schema.define(:version => 20100928000952) do
   create_table "action_tracker", :force => true do |t|
     t.integer  "user_id"
@@ -31,6 +31,10 @@ ActiveRecord::Schema.define(:version =&gt; 20100923160040) do
     t.integer "profile_id"
   end
+  add_index "action_tracker_notifications", ["action_tracker_id"], :name => "index_action_tracker_notifications_on_action_tracker_id"
+  add_index "action_tracker_notifications", ["profile_id", "action_tracker_id"], :name => "index_action_tracker_notifications_on_profile_id_and_action_tracker_id", :unique => true
+  add_index "action_tracker_notifications", ["profile_id"], :name => "index_action_tracker_notifications_on_profile_id"
+
   create_table "article_versions", :force => true do |t|
     t.integer  "article_id"
     t.integer  "version"
1	class AggressiveIndexingStrategy2 < ActiveRecord::Migration	1	class AggressiveIndexingStrategy2 < ActiveRecord::Migration
2	def self.up	2	def self.up
3	- execute("delete from action_tracker_notifications where id not in (select distinct(atn.id) from action_tracker_notifications as atn JOIN action_tracker_notifications as t ON (t.profile_id = atn.profile_id and t.action_tracker_id = atn.action_tracker_id and atn.id < t.id))")	3	+
		4	+ say 'Removing duplicate notification records ...'
		5	+ buffer = ''
		6	+ removed = 0
		7	+ select_all(
		8	+ 'select min(id) as min_id, action_tracker_id, profile_id, count(*)
		9	+ from action_tracker_notifications
		10	+ group by action_tracker_id, profile_id
		11	+ having count(*) > 1'
		12	+ ).each do \|duplicate\|
		13	+ buffer += ('delete from action_tracker_notifications
		14	+ where
		15	+ profile_id = %d AND
		16	+ action_tracker_id = %s AND
		17	+ id > %d;
		18	+ ' % [duplicate['profile_id'], duplicate['action_tracker_id'], duplicate['min_id']]
		19	+ )
		20	+ if removed % 100 == 0
		21	+ execute buffer
		22	+ say "Deleted " + removed.to_s
		23	+ buffer = ''
		24	+ end
		25	+ removed += 1
		26	+ end
		27	+
		28	+ if !buffer.empty?
		29	+ execute buffer
		30	+ end
		31	+
4	add_index(:action_tracker_notifications, :profile_id)	32	add_index(:action_tracker_notifications, :profile_id)
5	add_index(:action_tracker_notifications, :action_tracker_id)	33	add_index(:action_tracker_notifications, :action_tracker_id)
6	add_index(:action_tracker_notifications, [:profile_id, :action_tracker_id], :unique => true)	34	add_index(:action_tracker_notifications, [:profile_id, :action_tracker_id], :unique => true)