Download as
Browse Code »

Commit b4badb69daceb445d025ec9805dc96f2c9f9c30f

Authored by Larissa Reis
1 parent 562fa646
Exists in master and in 28 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, stable, temp_ratings, tests, tests_fixies

Validates there is at least one alternative

Showing 2 changed files with 11 additions and 0 deletions   Show diff stats
plugins/custom_forms/lib/custom_forms_plugin/select_field.rb
  Diff comments   View file @b4badb6
@@ -3,4 +3,6 @@ class CustomFormsPlugin::SelectField < CustomFormsPlugin::Field @@ -3,4 +3,6 @@ class CustomFormsPlugin::SelectField < CustomFormsPlugin::Field
3 3
4 validates_length_of :select_field_type, :minimum => 1, :allow_nil => false 4 validates_length_of :select_field_type, :minimum => 1, :allow_nil => false
5 validates_inclusion_of :select_field_type, :in => %w(radio check_box select multiple_select) 5 validates_inclusion_of :select_field_type, :in => %w(radio check_box select multiple_select)
  6 +
  7 + validates_length_of :alternatives, :minimum => 1
6 end 8 end
plugins/custom_forms/test/unit/custom_forms_plugin/select_field_test.rb
  Diff comments   View file @b4badb6
1 require File.dirname(__FILE__) + '/../../../../../test/test_helper' 1 require File.dirname(__FILE__) + '/../../../../../test/test_helper'
2 2
3 class CustomFormsPlugin::SelectFieldTest < ActiveSupport::TestCase 3 class CustomFormsPlugin::SelectFieldTest < ActiveSupport::TestCase
  4 + should 'have alternative' do
  5 + select = CustomFormsPlugin::SelectField.new(:name => 'select_field001' )
  6 + assert !select.save
  7 +
  8 + select.alternatives << CustomFormsPlugin::Alternative.new(:label => 'option')
  9 + assert select.save
  10 + end
  11 +
4 should 'validate type' do 12 should 'validate type' do
5 select = CustomFormsPlugin::SelectField.new(:name => 'select_field001' ) 13 select = CustomFormsPlugin::SelectField.new(:name => 'select_field001' )
  14 + select.alternatives << CustomFormsPlugin::Alternative.new(:label => 'option')
6 15
7 select.update_attribute(:select_field_type, 'random') 16 select.update_attribute(:select_field_type, 'random')
8 assert select.invalid? 17 assert select.invalid?