Download as
Browse Code »

Commit b6ec7ab024edbd686985bc0d70bf44754f4c609c

Authored by Rodrigo Souto
1 parent 03c1131a
Exists in master and in 27 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, temp_ratings, tests, tests_fixies

publish_on_communities: not crash when no community is selected

Showing 2 changed files with 9 additions and 0 deletions   Show diff stats
app/controllers/my_profile/cms_controller.rb
  Diff comments   View file @b6ec7ab
@@ -295,6 +295,7 @@ class CmsController < MyProfileController @@ -295,6 +295,7 @@ class CmsController < MyProfileController
295 params_marked = (params['q'] || '').split(',').select { |marked| user.memberships.map(&:id).include? marked.to_i } 295 params_marked = (params['q'] || '').split(',').select { |marked| user.memberships.map(&:id).include? marked.to_i }
296 @marked_groups = Profile.find(params_marked) 296 @marked_groups = Profile.find(params_marked)
297 if @marked_groups.empty? 297 if @marked_groups.empty?
  298 + redirect_to @back_to
298 return session[:notice] = _("Select some group to publish your article") 299 return session[:notice] = _("Select some group to publish your article")
299 end 300 end
300 @marked_groups.each do |item| 301 @marked_groups.each do |item|
test/functional/cms_controller_test.rb
  Diff comments   View file @b6ec7ab
@@ -763,6 +763,14 @@ class CmsControllerTest < ActionController::TestCase @@ -763,6 +763,14 @@ class CmsControllerTest < ActionController::TestCase
763 end 763 end
764 end 764 end
765 765
  766 + should 'not crash if no community is selected' do
  767 + article = profile.articles.create!(:name => 'something intresting', :body => 'ruby on rails')
  768 +
  769 + assert_nothing_raised do
  770 + post :publish_on_communities, :profile => profile.identifier, :id => article.id, :q => '', :back_to => '/'
  771 + end
  772 + end
  773 +
766 should "not crash if there is a post and no portal community defined" do 774 should "not crash if there is a post and no portal community defined" do
767 Environment.any_instance.stubs(:portal_community).returns(nil) 775 Environment.any_instance.stubs(:portal_community).returns(nil)
768 article = profile.articles.create!(:name => 'something intresting', :body => 'ruby on rails') 776 article = profile.articles.create!(:name => 'something intresting', :body => 'ruby on rails')