Download as
Browse Code »

Commit bb03159988747ffeb89587cd2f0c727569ba664b

Authored by Rodrigo Souto
1 parent 6b037511
Exists in master and in 28 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, stable, temp_ratings, tests, tests_fixies

shopping_cart: avoid crash on buy if there is no cart 

(ActionItem2808)
Showing 2 changed files with 12 additions and 4 deletions   Show diff stats
plugins/shopping_cart/controllers/shopping_cart_plugin_controller.rb
  Diff comments   View file @bb03159
... ... @@ -94,10 +94,12 @@ class ShoppingCartPluginController < PublicController
94 94 end
95 95  
96 96 def buy
97   - @cart = cart
98   - @enterprise = environment.enterprises.find(cart[:enterprise_id])
99   - @settings = Noosfero::Plugin::Settings.new(@enterprise, ShoppingCartPlugin)
100   - render :layout => false
  97 + if validate_cart_presence
  98 + @cart = cart
  99 + @enterprise = environment.enterprises.find(cart[:enterprise_id])
  100 + @settings = Noosfero::Plugin::Settings.new(@enterprise, ShoppingCartPlugin)
  101 + render :layout => false
  102 + end
101 103 end
102 104  
103 105 def send_request
... ...
plugins/shopping_cart/test/functional/shopping_cart_plugin_controller_test.rb
  Diff comments   View file @bb03159
... ... @@ -187,6 +187,12 @@ class ShoppingCartPluginControllerTest < ActionController::TestCase
187 187 assert !cart?, "cart expected to be empty!"
188 188 end
189 189  
  190 + should 'not allow buy without any cart' do
  191 + get :buy
  192 + assert !json_response[:ok]
  193 + assert_equal 2, json_response['error']['code']
  194 + end
  195 +
190 196 private
191 197  
192 198 def json_response
... ...