Download as
Browse Code »

Commit cf3280640a4bb5986167a40f2e6c17035490e64d

Authored by Antonio Terceiro
1 parent 2161fb73
Exists in master and in 28 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, stable, temp_ratings, tests, tests_fixies

Only warn user if actually changing the URL 

(ActionItem1258)
Showing 1 changed file with 10 additions and 2 deletions   Show diff stats
public/javascripts/application.js
  Diff comments   View file @cf32806
@@ -48,8 +48,16 @@ function convToValidIdentifier( str, sep ) { @@ -48,8 +48,16 @@ function convToValidIdentifier( str, sep ) {
48 48
49 function updateUrlField(name_field, id) { 49 function updateUrlField(name_field, id) {
50 url_field = $(id); 50 url_field = $(id);
51 - url_field.value = convToValidIdentifier(name_field.value, "-");  
52 - warn_value_change(url_field); 51 + old_url_value = url_field.value;
  52 + new_url_value = convToValidIdentifier(name_field.value, "-");
  53 +
  54 + url_field.value = new_url_value;
  55 +
  56 + if (!/^\s*$/.test(old_url_value)
  57 + && old_url_value != new_url_value
  58 + ) {
  59 + warn_value_change(url_field);
  60 + }
53 } 61 }
54 62
55 function show_warning(field, message) { 63 function show_warning(field, message) {