Change vote plugin to remove votes when a voteable is removed

Victor Costa
1 parent 772c27b5
Showing 3 changed files with 14 additions and 1 deletions Show diff stats
test/unit/article_test.rb
test/unit/comment_test.rb
vendor/plugins/vote_fu/lib/acts_as_voteable.rb
@@ -1751,4 +1751,10 @@ class ArticleTest &lt; ActiveSupport::TestCase
     assert_equal 5, article.votes_total
   end
+  should 'be able to remove a voted article' do
+    article = Article.create!(:name => 'Test', :profile => profile, :last_changed_by => nil)
+    profile.vote(article, 5)
+    article.destroy
+  end
+
 end
@@ -724,6 +724,13 @@ class CommentTest &lt; ActiveSupport::TestCase
     assert_equal 2, comment.votes_against
   end
+  should 'be able to remove a voted comment' do
+    comment = create_comment
+    person = create_user('voter').person
+    person.vote(comment, 5)
+    comment.destroy
+  end
+
   private
   def create_comment(args = {})
@@ -16,7 +16,7 @@ module Juixe
         #     Note: Specifying a counter will add it to that model‘s list of readonly attributes using attr_readonly.
         # 
         def acts_as_voteable options={}
-          has_many :votes, :as => :voteable, :dependent => :nullify
+          has_many :votes, :as => :voteable, :dependent => :destroy
           include Juixe::Acts::Voteable::InstanceMethods
           extend  Juixe::Acts::Voteable::SingletonMethods
           if (options[:vote_counter])
	@@ -1751,4 +1751,10 @@ class ArticleTest < ActiveSupport::TestCase		@@ -1751,4 +1751,10 @@ class ArticleTest < ActiveSupport::TestCase
1751	assert_equal 5, article.votes_total	1751	assert_equal 5, article.votes_total
1752	end	1752	end
1753		1753
		1754	+ should 'be able to remove a voted article' do
		1755	+ article = Article.create!(:name => 'Test', :profile => profile, :last_changed_by => nil)
		1756	+ profile.vote(article, 5)
		1757	+ article.destroy
		1758	+ end
		1759	+
1754	end	1760	end
	@@ -724,6 +724,13 @@ class CommentTest < ActiveSupport::TestCase		@@ -724,6 +724,13 @@ class CommentTest < ActiveSupport::TestCase
724	assert_equal 2, comment.votes_against	724	assert_equal 2, comment.votes_against
725	end	725	end
726		726
		727	+ should 'be able to remove a voted comment' do
		728	+ comment = create_comment
		729	+ person = create_user('voter').person
		730	+ person.vote(comment, 5)
		731	+ comment.destroy
		732	+ end
		733	+
727	private	734	private
728		735
729	def create_comment(args = {})	736	def create_comment(args = {})
	@@ -16,7 +16,7 @@ module Juixe		@@ -16,7 +16,7 @@ module Juixe
16	# Note: Specifying a counter will add it to that model‘s list of readonly attributes using attr_readonly.	16	# Note: Specifying a counter will add it to that model‘s list of readonly attributes using attr_readonly.
17	#	17	#
18	def acts_as_voteable options={}	18	def acts_as_voteable options={}
19	- has_many :votes, :as => :voteable, :dependent => :nullify	19	+ has_many :votes, :as => :voteable, :dependent => :destroy
20	include Juixe::Acts::Voteable::InstanceMethods	20	include Juixe::Acts::Voteable::InstanceMethods
21	extend Juixe::Acts::Voteable::SingletonMethods	21	extend Juixe::Acts::Voteable::SingletonMethods
22	if (options[:vote_counter])	22	if (options[:vote_counter])