Make possible to rate as zero and tests

Signed-off-by: Fabio Teixeira <fabio1079@gmail.com> Signed-off-by: Gabriela Navarro <navarro1703@gmail.com>

Make possible to rate as zero and tests
Signed-off-by: Fabio Teixeira <fabio1079@gmail.com> Signed-off-by: Gabriela Navarro <navarro1703@gmail.com>
Gabriela Navarro
1 parent 8651abee
Showing 3 changed files with 26 additions and 39 deletions Show diff stats
plugins/communities_ratings/public/rate.js
plugins/communities_ratings/test/functional/communities_ratings_plugin_profile_controller_test.rb
plugins/communities_ratings/views/communities_ratings_plugin_profile/new_rating.html.erb
@@ -92,18 +92,20 @@
       .on("click", function() { // On mouse click, set the selected star rate
         var rate_mouseover = parseInt(this.getAttribute(DATA.DATA_RATE_ATTRIBUTE));
-        DATA.selected_rate = rate_mouseover;
-      });
-  }
+        // If the new rate is different from actual, update it
+        if (rate_mouseover !== DATA.selected_rate) {
+          DATA.selected_rate = rate_mouseover;
+        } else { // or else, uncheck it
+          DATA.selected_rate = DATA.NOT_SELECTED_VALUE;
+        }
-  /*
-  * Display a message to the user if there is no star selected when he/she
-  * clicks on the rate button
-  */
-  function not_selected_rate_action(notice_element) {
-    var notice = $("#empty-star-notice").val();
-    notice_element.html(notice);
+        var star_notice = $(".star-notice");
+        star_notice.removeClass("star-hide");
+
+        // Call selected_rate_action to send the rate data.
+        selected_rate_action(star_notice);
+      });
   }
@@ -127,27 +129,6 @@
   /*
-  * Set the rate button actions. It verify if the user selected a rate.
-  * If true:
-  *  Call selected_rate_action to send the rate data.
-  * If false:
-  *  Call not_selected_rate_action to display a error message to the user
-  */
-  function set_rate_button_action() {
-    $("#star-rate-action").on("click", function() {
-      var star_notice = $(".star-notice");
-      star_notice.removeClass("star-hide");
-
-      if (DATA.selected_rate !== DATA.NOT_SELECTED_VALUE) {
-        selected_rate_action(star_notice);
-      } else {
-        not_selected_rate_action(star_notice);
-      }
-    });
-  }
-
-
-  /*
   * When the page DOM is ready, set all the stars events
   */
   $(document).ready(function() {
@@ -25,10 +25,20 @@ class CommunitiesRatingsPluginProfileControllerTest &lt; ActionController::TestCase
   test "should logged person rate a community" do
-    #xhr :post , :rate, :profile => @community, :value => 4
-    #xhr :post , url_for(:action=>:rate), :profile => @community, :value => 4
+    xhr :post , :rate, :profile => @community.identifier, :value => 4
-    assert_equal true, true
+    json_response = ActiveSupport::JSON.decode(@response.body)
+
+    assert_equal true, json_response['success']
+  end
+
+  test "should logged person not rate a community with invalid value" do
+    xhr :post , :rate, :profile => @community.identifier, :value => 7
+
+    json_response = ActiveSupport::JSON.decode(@response.body)
+
+    assert_equal false, json_response['success']
+    assert_equal 'Value must be between 0 and 5', json_response['errors'].first
   end
   test "should add new comment to community" do
 <input type="hidden" id="community-profile" value="<%= @profile.identifier  %>">
-<input type="hidden" id="empty-star-notice" value="<%= _("At least one star must be selected") %>">
 <input type="hidden" id="selected-star-rate" value="<%= @actual_rate_value %>">
 <div class="star-notice star-hide"></div>
@@ -19,9 +18,6 @@
         <% end %>
       </div>
-      <div class="star-action">
-        <button id="star-rate-action"><%= _("Rate") %></button>
-      </div>
     </div>
     <div>
       <%= form_for :comments do |c| %>
@@ -31,7 +27,7 @@
         </div>
         <%= @plugins.dispatch(:communities_ratings_plugin_comments_extra_fields).collect { |content| instance_exec(&content) }.join("") %>
-        <%= c.submit %>
+        <%= c.submit _("Send") %>
       <% end %>
     </div>
   </div>
	@@ -92,18 +92,20 @@		@@ -92,18 +92,20 @@
92		92
93	.on("click", function() { // On mouse click, set the selected star rate	93	.on("click", function() { // On mouse click, set the selected star rate
94	var rate_mouseover = parseInt(this.getAttribute(DATA.DATA_RATE_ATTRIBUTE));	94	var rate_mouseover = parseInt(this.getAttribute(DATA.DATA_RATE_ATTRIBUTE));
95	- DATA.selected_rate = rate_mouseover;
96	- });
97	- }
98		95
		96	+ // If the new rate is different from actual, update it
		97	+ if (rate_mouseover !== DATA.selected_rate) {
		98	+ DATA.selected_rate = rate_mouseover;
		99	+ } else { // or else, uncheck it
		100	+ DATA.selected_rate = DATA.NOT_SELECTED_VALUE;
		101	+ }
99		102
100	- /*
101	- * Display a message to the user if there is no star selected when he/she
102	- * clicks on the rate button
103	- */
104	- function not_selected_rate_action(notice_element) {
105	- var notice = $("#empty-star-notice").val();
106	- notice_element.html(notice);	103	+ var star_notice = $(".star-notice");
		104	+ star_notice.removeClass("star-hide");
		105	+
		106	+ // Call selected_rate_action to send the rate data.
		107	+ selected_rate_action(star_notice);
		108	+ });
107	}	109	}
108		110
109		111
	@@ -127,27 +129,6 @@		@@ -127,27 +129,6 @@
127		129
128		130
129	/*	131	/*
130	- * Set the rate button actions. It verify if the user selected a rate.
131	- * If true:
132	- * Call selected_rate_action to send the rate data.
133	- * If false:
134	- * Call not_selected_rate_action to display a error message to the user
135	- */
136	- function set_rate_button_action() {
137	- $("#star-rate-action").on("click", function() {
138	- var star_notice = $(".star-notice");
139	- star_notice.removeClass("star-hide");
140	-
141	- if (DATA.selected_rate !== DATA.NOT_SELECTED_VALUE) {
142	- selected_rate_action(star_notice);
143	- } else {
144	- not_selected_rate_action(star_notice);
145	- }
146	- });
147	- }
148	-
149	-
150	- /*
151	* When the page DOM is ready, set all the stars events	132	* When the page DOM is ready, set all the stars events
152	*/	133	*/
153	$(document).ready(function() {	134	$(document).ready(function() {
	@@ -25,10 +25,20 @@ class CommunitiesRatingsPluginProfileControllerTest < ActionController::TestCase		@@ -25,10 +25,20 @@ class CommunitiesRatingsPluginProfileControllerTest < ActionController::TestCase
25		25
26		26
27	test "should logged person rate a community" do	27	test "should logged person rate a community" do
28	- #xhr :post , :rate, :profile => @community, :value => 4
29	- #xhr :post , url_for(:action=>:rate), :profile => @community, :value => 4	28	+ xhr :post , :rate, :profile => @community.identifier, :value => 4
30		29
31	- assert_equal true, true	30	+ json_response = ActiveSupport::JSON.decode(@response.body)
		31	+
		32	+ assert_equal true, json_response['success']
		33	+ end
		34	+
		35	+ test "should logged person not rate a community with invalid value" do
		36	+ xhr :post , :rate, :profile => @community.identifier, :value => 7
		37	+
		38	+ json_response = ActiveSupport::JSON.decode(@response.body)
		39	+
		40	+ assert_equal false, json_response['success']
		41	+ assert_equal 'Value must be between 0 and 5', json_response['errors'].first
32	end	42	end
33		43
34	test "should add new comment to community" do	44	test "should add new comment to community" do