Download as
Browse Code »

Commit dc356d387f39b26cb8738db07af076f428cc2ae9

Authored by AntonioTerceiro
1 parent d31f0c9f
Exists in master and in 28 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, stable, temp_ratings, tests, tests_fixies

ActionItem438: base URL must be SSL-aware 

git-svn-id: https://svn.colivre.coop.br/svn/noosfero/trunk@2470 3f533792-8f58-4932-b0fe-aaf55b0a4547
Showing 4 changed files with 14 additions and 3 deletions   Show diff stats
app/helpers/application_helper.rb
  Diff comments   View file @dc356d3
@@ -713,4 +713,8 @@ module ApplicationHelper @@ -713,4 +713,8 @@ module ApplicationHelper
713 url_for(options) 713 url_for(options)
714 end 714 end
715 715
  716 + def base_url
  717 + environment.top_url(request.ssl?)
  718 + end
  719 +
716 end 720 end
app/models/environment.rb
  Diff comments   View file @dc356d3
@@ -256,8 +256,9 @@ class Environment < ActiveRecord::Base @@ -256,8 +256,9 @@ class Environment < ActiveRecord::Base
256 end 256 end
257 end 257 end
258 258
259 - def top_url  
260 - result = "http://#{default_hostname}" 259 + def top_url(ssl = false)
  260 + protocol = (ssl ? 'https' : 'http')
  261 + result = "#{protocol}://#{default_hostname}"
261 if Noosfero.url_options.has_key?(:port) 262 if Noosfero.url_options.has_key?(:port)
262 result << ':' << Noosfero.url_options[:port].to_s 263 result << ':' << Noosfero.url_options[:port].to_s
263 end 264 end
app/views/layouts/application.rhtml
  Diff comments   View file @dc356d3
@@ -50,7 +50,7 @@ @@ -50,7 +50,7 @@
50 <%# FIXME %> 50 <%# FIXME %>
51 <%= stylesheet_link_tag '/designs/icons/default/style.css' %> 51 <%= stylesheet_link_tag '/designs/icons/default/style.css' %>
52 52
53 - <base href="<%= environment.top_url %>"/> 53 + <base href="<%= base_url %>"/>
54 </head> 54 </head>
55 55
56 <body class='noosfero category<%= category_color %><%= 56 <body class='noosfero category<%= category_color %><%=
test/unit/environment_test.rb
  Diff comments   View file @dc356d3
@@ -187,6 +187,12 @@ class EnvironmentTest &lt; Test::Unit::TestCase @@ -187,6 +187,12 @@ class EnvironmentTest &lt; Test::Unit::TestCase
187 assert_equal 'http://www.lalala.net:9999', env.top_url 187 assert_equal 'http://www.lalala.net:9999', env.top_url
188 end 188 end
189 189
  190 + should 'use https when asked for a ssl url' do
  191 + env = Environment.new
  192 + env.expects(:default_hostname).returns('www.lalala.net')
  193 + assert_equal 'https://www.lalala.net', env.top_url(true)
  194 + end
  195 +
190 should 'provide an approval_method setting' do 196 should 'provide an approval_method setting' do
191 env = Environment.new 197 env = Environment.new
192 198