Download as
Browse Code »

Commit e042473dc49e5403d031a88697ac4f91e92361ff

Authored by Rodrigo Souto
1 parent 2fd03497
Exists in master and in 28 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, stable, temp_ratings, tests, tests_fixies

Spammer logger 

Also logging spammer when comment is marked as spam
Showing 4 changed files with 59 additions and 0 deletions   Show diff stats
app/models/comment.rb
  Diff comments   View file @e042473
... ... @@ -224,6 +224,7 @@ class Comment < ActiveRecord::Base
224 224 def spam!
225 225 self.spam = true
226 226 self.save!
  227 + SpammerLogger.log(ip_address, self)
227 228 Delayed::Job.enqueue(CommentHandler.new(self.id, :marked_as_spam))
228 229 self
229 230 end
... ...
app/models/spammer_logger.rb 0 → 100644
  Diff comments   View file @e042473
... ... @@ -0,0 +1,24 @@
  1 +class SpammerLogger < Logger
  2 + @logpath = File.join(Rails.root, 'log', "#{ENV['RAILS_ENV']}_spammers.log")
  3 + @logger = new(@logpath)
  4 +
  5 + def self.log(spammer_ip, object=nil)
  6 + if object
  7 + if object.kind_of?(Comment)
  8 + @logger << "[#{Time.now.strftime("%F %T %z")}] Comment-id: #{object.id} IP: #{spammer_ip}\n"
  9 + end
  10 + else
  11 + @logger << "[#{Time.now.strftime("%F %T %z")}] IP: #{spammer_ip}\n"
  12 + end
  13 + end
  14 +
  15 + def self.clean_log
  16 + File.delete(@logpath) if File.exists?(@logpath)
  17 + end
  18 +
  19 + def self.reload_log
  20 + clean_log
  21 + @logger = new(@logpath)
  22 + end
  23 +
  24 +end
... ...
test/unit/comment_test.rb
  Diff comments   View file @e042473
... ... @@ -563,6 +563,14 @@ class CommentTest &lt; ActiveSupport::TestCase
563 563 assert_equal Environment.default, comment.environment
564 564 end
565 565  
  566 + should 'log spammer ip after marking comment as spam' do
  567 + comment = create_comment(:ip_address => '192.168.0.1')
  568 + comment.spam!
  569 + log = File.open('log/test_spammers.log')
  570 + assert_match "Comment-id: #{comment.id} IP: 192.168.0.1", log.read
  571 + SpammerLogger.clean_log
  572 + end
  573 +
566 574 private
567 575  
568 576 def create_comment(args = {})
... ...
test/unit/spammer_logger_test.rb 0 → 100644
  Diff comments   View file @e042473
... ... @@ -0,0 +1,26 @@
  1 +require File.dirname(__FILE__) + '/../test_helper'
  2 +
  3 +class SpammerLoggerTest < ActiveSupport::TestCase
  4 +
  5 + def setup
  6 + SpammerLogger.reload_log
  7 + end
  8 +
  9 + def teardown
  10 + SpammerLogger.clean_log
  11 + end
  12 +
  13 + should 'log the spammer ip' do
  14 + SpammerLogger.log('192.168.0.1')
  15 + log = File.open('log/test_spammers.log')
  16 + assert_match 'IP: 192.168.0.1', log.read
  17 + end
  18 +
  19 + should 'log the spammer ip with comment associated' do
  20 + comment = fast_create(Comment)
  21 + SpammerLogger.log('192.168.0.1', comment)
  22 + log = File.open('log/test_spammers.log')
  23 + assert_match "Comment-id: #{comment.id} IP: 192.168.0.1", log.read
  24 + end
  25 +
  26 +end
... ...