ActionItem1219: now actually sending the e-mail

Send the e-mail outside the Task transaction, so the e-mail server can have an up-to-date view of the table.

ActionItem1219: now actually sending the e-mail
Send the e-mail outside the Task transaction, so the e-mail server can have an up-to-date view of the table.
Antonio Terceiro
1 parent a289c353
Showing 2 changed files with 9 additions and 0 deletions Show diff stats
app/models/email_activation.rb
app/models/task.rb
@@ -17,6 +17,10 @@ class EmailActivation &lt; Task
  
   def perform
     person.user.enable_email!
+  end
+
+  # :nodoc:
+  def after_finish
     User::Mailer.deliver_activation_email_notify(person.user)
   end
  
@@ -80,6 +80,11 @@ class Task &lt; ActiveRecord::Base
         RAILS_DEFAULT_LOGGER.info ex.to_s
       end
     end
+    after_finish
+  end
+
+  # :nodoc:
+  def after_finish
   end
  
   # this method cancels the task. At the end a message (as returned by
...	...	@@ -17,6 +17,10 @@ class EmailActivation < Task
17	17
18	18	def perform
19	19	person.user.enable_email!
	20	+ end
	21	+
	22	+ # :nodoc:
	23	+ def after_finish
20	24	User::Mailer.deliver_activation_email_notify(person.user)
21	25	end
22	26
...	...
...	...	@@ -80,6 +80,11 @@ class Task < ActiveRecord::Base
80	80	RAILS_DEFAULT_LOGGER.info ex.to_s
81	81	end
82	82	end
	83	+ after_finish
	84	+ end
	85	+
	86	+ # :nodoc:
	87	+ def after_finish
83	88	end
84	89
85	90	# this method cancels the task. At the end a message (as returned by
...	...