Improvements on article suggestion feature

* English text review * Letting the administrator edit all fields which are going to be published before accepting the article. * Letting administrator highlight the new article. * Making the size of the lead and body fields consistent with other UI parts * Removed inconsistent styling * Updated database schema file (ActionItem1732)

Improvements on article suggestion feature
* English text review * Letting the administrator edit all fields which are going to be published before accepting the article. * Letting administrator highlight the new article. * Making the size of the lead and body fields consistent with other UI parts * Removed inconsistent styling * Updated database schema file (ActionItem1732)
Antonio Terceiro
1 parent 2cd9c622
Showing 11 changed files with 80 additions and 34 deletions Show diff stats
app/controllers/my_profile/cms_controller.rb
app/models/suggest_article.rb
app/views/cms/suggest_an_article.rhtml
app/views/content_viewer/view_page.rhtml
app/views/tasks/_approve_article.rhtml
app/views/tasks/_suggest_article.rhtml
db/schema.rb
public/stylesheets/application.css
test/factories.rb
test/functional/cms_controller_test.rb
test/unit/suggest_article_test.rb
@@ -289,7 +289,7 @@ class CmsController &lt; MyProfileController
     if request.post?
        @task.target = profile
       if @task.save
-        session[:notice] = _('You make your suggestion successfully. Please wait the article approval.')
+        session[:notice] = _('Thanks for your suggestion. The community administrators were notified.')
         redirect_to @back_to
       end
     end
@@ -8,7 +8,7 @@ class SuggestArticle &lt; Task
   validates_presence_of :target_id, :article_name, :email, :name, :article_body
   def description
-    _('%{email} suggested to publish "%{article}" on %{community}') % { :email => email, :article => article_name, :community => target.name }
+    _('%{sender} suggested to publish "%{article}" on %{community}') % { :sender => sender, :article => article_name, :community => target.name }
   end
   settings_items :email, :type => String
@@ -18,9 +18,24 @@ class SuggestArticle &lt; Task
   settings_items :article_abstract, :type => String
   settings_items :article_parent_id, :type => String
   settings_items :source, :type => String
+  settings_items :source_name, :type => String
+  settings_items :highlighted, :type => :boolean
+
+  def sender
+    "#{name} (#{email})"
+  end
   def perform
-    TinyMceArticle.create!(:profile => target, :name => article_name, :body => article_body, :abstract => article_abstract, :parent_id => article_parent_id, :source => source, :source_name => name)
+    TinyMceArticle.create!(
+      :profile => target,
+      :name => article_name,
+      :body => article_body,
+      :abstract => article_abstract,
+      :parent_id => article_parent_id,
+      :source => source,
+      :source_name => source_name,
+      :highlighted => highlighted
+    )
   end
 end
@@ -6,23 +6,25 @@
 <% labelled_form_for 'task', @task do |f| %>
-  <%= required labelled_form_field(_('Title'), text_field(:task, 'article_name')) %>
+  <%= required labelled_form_field(_('Title'), text_field(:task, 'article_name', :size => 50)) %>
-  <%= labelled_form_field(_('Url Source'), text_field(:task, 'source')) %>
+  <%= labelled_form_field(_('Source'), text_field(:task, 'source_name')) %>
-  <%= required labelled_form_field(_('Name'), text_field(:task, 'name')) %>
+  <%= labelled_form_field(_('Source link'), text_field(:task, 'source')) %>
+
+  <%= required labelled_form_field(_('Your name'), text_field(:task, 'name')) %>
   <%= required labelled_form_field(_('Email'), text_field(:task, 'email')) %>
   <br style="clear: both;"/>
   <%= button :add, _("Lead"), '#', :id => "lead-button", :style => "margin-left: 0px;" %>
-  <em><%= _('Used when a short version your text is needed.') %></em>
+  <em><%= _('Used when a short version of your text is needed.') %></em>
   <div id="article-lead">
-    <%= labelled_form_field(_('Lead'), text_area(:task , 'article_abstract', :style => 'width: 100%; height: 300px;')) %>
+    <%= labelled_form_field(_('Lead'), text_area(:task , 'article_abstract', :style => 'width: 100%; height: 200px;')) %>
   </div>
   <div style="margin-top: 10px;">
-    <%= labelled_form_field(_('Text'), text_area(:task, 'article_body', :style => 'width:100%')) %>
+    <%= labelled_form_field(_('Text'), text_area(:task, 'article_body', :style => 'width:100%; height: 500px;')) %>
   </div>
   <div id="captcha">
@@ -46,7 +46,9 @@
       <% end %>
     </div>
   <% else %>
-    <%= link_to content_tag( 'span', _('Suggest an article') ), profile.admin_url.merge({ :controller => 'cms', :action => 'suggest_an_article'}), :class => 'button with-text icon-new' %>
+    <% if profile.community? %>
+      <%= link_to content_tag( 'span', _('Suggest an article') ), profile.admin_url.merge({ :controller => 'cms', :action => 'suggest_an_article'}), :class => 'button with-text icon-new' %>
+    <% end %>
   <% end %>
   <div id="article-header">
     <%= link_to(image_tag('icons-mime/rss-feed.png'), @page.feed.url, :class => 'blog-feed-link') if @page.has_posts? && @page.feed %>
@@ -26,7 +26,11 @@
       <%= labelled_form_field _('Name for publishing'), f.text_field(:name, :style => 'width:80%;') %>
       <%= select_folder(_('Select the folder where the article must be published'), 'task', 'article_parent_id', task.target.folders) %>
-      <%= labelled_form_field( _('Highlight this article'), f.check_box(:highlighted)) %>
+      <div>
+        <%= f.check_box(:highlighted) %>
+        <label for="article_highlighted"><%= _('Highlight this article')%></label>
+      </div>
+
       <%= labelled_form_field _('Comment for author'), f.text_field(:closing_statment, :style => 'width:80%;') %>
       <%= render :partial => partial_for_class(task.article.class), :locals => { :f => f } %>
@@ -4,24 +4,24 @@
 <% form_for('task', task, :url => { :action => 'close', :id => task.id}) do |f| %>
-  <p> <%= label_tag(_("Sent by: %s") % task.name) %> </p>
+  <p><%= label_tag(_("Sent by: %s") % task.name) %> </p>
   <p><%= label_tag(_("Email: %s") % task.email) %> </p>
-  <p><%= label_tag(_("Source: %s") % task.source) %> </p>
-  <%= required labelled_form_field(_('Title'), text_field_tag('task[article_name]', task.article_name)) %>
+  <%= required labelled_form_field(_('Title'), f.text_field(:article_name, :size => 50)) %>
+  <%= labelled_form_field(_('Source'), f.text_field(:source_name)) %>
+  <%= labelled_form_field(_("Source URL"), f.text_field(:source)) %>
   <%= select_folder(_('Select the folder where the article must be published'), 'task', 'article_parent_id', task.target.folders) %>
-
   <br style="clear: both;"/>
   <%= button :add, _("Lead"), '#', :id => "lead-button", :style => "margin-left: 0px;" %>
   <em><%= _('Used when a short version your text is needed.') %></em>
   <div id="article-lead">
-    <%= labelled_form_field(_('Lead'), text_area_tag('task[article_abstract]', task.article_abstract, :style => 'width: 100%; height: 300px;')) %>
+    <%= labelled_form_field(_('Lead'), text_area_tag('task[article_abstract]', task.article_abstract, :style => 'width: 100%; height: 200px;')) %>
   </div>
   <div style="margin-top: 10px;">
-    <%= labelled_form_field(_('Text'), text_area_tag('task[article_body]', task.article_body, :style => 'width:100%')) %>
+    <%= labelled_form_field(_('Text'), text_area_tag('task[article_body]', task.article_body, :style => 'width:100%; height: 500px;')) %>
   </div>
   <div>
@@ -9,7 +9,7 @@
 #
 # It's strongly recommended to check this file into your version control system.
-ActiveRecord::Schema.define(:version => 20101205034144) do
+ActiveRecord::Schema.define(:version => 20101209001631) do
   create_table "action_tracker", :force => true do |t|
     t.integer  "user_id"
@@ -74,6 +74,7 @@ ActiveRecord::Schema.define(:version =&gt; 20101205034144) do
     t.boolean  "is_image",             :default => false
     t.integer  "translation_of_id"
     t.string   "language"
+    t.string   "source_name"
   end
   create_table "articles", :force => true do |t|
@@ -113,6 +114,7 @@ ActiveRecord::Schema.define(:version =&gt; 20101205034144) do
     t.boolean  "is_image",             :default => false
     t.integer  "translation_of_id"
     t.string   "language"
+    t.string   "source_name"
   end
   add_index "articles", ["translation_of_id"], :name => "index_articles_on_translation_of_id"
@@ -5237,17 +5237,3 @@ h1#agenda-title {
 .forum-posts .pagination {
   margin-top: 20px;
 }
-
-#captcha input {
-  border: 1px solid #ccc;
-  margin: 4px 0px 2px 10px !important;
-  padding: 0px !important;
-  width: 150px !important;
-  font-size: 24px;
-  float: left;
-}
-
-#captcha label{
-  float: left;
-  font-size: 24px;
-}
@@ -427,4 +427,8 @@ module Noosfero::Factory
     { :profile_id => 1, :path => name, :name => name, :slug => name.to_slug }.merge(params)
   end
+  def defaults_for_suggest_article
+    { :name => 'Sender', :email => 'sender@example.com', :article_name => 'Some title', :article_body => 'some body text', :article_abstract => 'some abstract text'}
+  end
+
 end
@@ -1438,8 +1438,6 @@ class CmsControllerTest &lt; Test::Unit::TestCase
     c = Community.create!(:name => 'test comm', :identifier => 'test_comm', :moderated_articles => true)
     get :suggest_an_article, :profile => c.identifier
     assert_response :success
-    assert_template 'suggest_an_article'
-    assert_tag :tag => 'input', :attributes => { :value => "https://colivre.net/profile/test_comm", :id => 'back_to' }
   end
 end
@@ -86,4 +86,37 @@ class SuggestArticleTest &lt; ActiveSupport::TestCase
     assert_equal count + 1, TinyMceArticle.count
   end
+  should 'fill source name and URL into created article' do
+    t = build(SuggestArticle, :target => @profile)
+    t.source_name = 'GNU project'
+    t.source = 'http://www.gnu.org/'
+    t.perform
+
+    article = TinyMceArticle.last
+    assert_equal 'GNU project', article.source_name
+    assert_equal 'http://www.gnu.org/', article.source
+  end
+
+  should 'use sender name in description' do
+    t = build(SuggestArticle, :target => @profile)
+    t.stubs(:sender).returns('XYZ')
+    assert_match(/XYZ/, t.description)
+  end
+
+  should 'use name and e-mail as sender info' do
+    t = build(SuggestArticle, :target => @profile)
+    t.name = 'Some One'
+    t.email = 'someone@example.com'
+    assert_match(/.*Some One.*someone@example.com/, t.sender)
+  end
+
+  should 'highlight created article' do
+    t = build(SuggestArticle, :target => @profile)
+    t.highlighted = true
+    t.perform
+
+    article = TinyMceArticle.last(:conditions => { :name => t.article_name}) # just to be sure
+    assert article.highlighted
+  end
+
 end
	@@ -289,7 +289,7 @@ class CmsController < MyProfileController		@@ -289,7 +289,7 @@ class CmsController < MyProfileController
289	if request.post?	289	if request.post?
290	@task.target = profile	290	@task.target = profile
291	if @task.save	291	if @task.save
292	- session[:notice] = _('You make your suggestion successfully. Please wait the article approval.')	292	+ session[:notice] = _('Thanks for your suggestion. The community administrators were notified.')
293	redirect_to @back_to	293	redirect_to @back_to
294	end	294	end
295	end	295	end
	@@ -8,7 +8,7 @@ class SuggestArticle < Task		@@ -8,7 +8,7 @@ class SuggestArticle < Task
8	validates_presence_of :target_id, :article_name, :email, :name, :article_body	8	validates_presence_of :target_id, :article_name, :email, :name, :article_body
9		9
10	def description	10	def description
11	- _('%{email} suggested to publish "%{article}" on %{community}') % { :email => email, :article => article_name, :community => target.name }	11	+ _('%{sender} suggested to publish "%{article}" on %{community}') % { :sender => sender, :article => article_name, :community => target.name }
12	end	12	end
13		13
14	settings_items :email, :type => String	14	settings_items :email, :type => String
	@@ -18,9 +18,24 @@ class SuggestArticle < Task		@@ -18,9 +18,24 @@ class SuggestArticle < Task
18	settings_items :article_abstract, :type => String	18	settings_items :article_abstract, :type => String
19	settings_items :article_parent_id, :type => String	19	settings_items :article_parent_id, :type => String
20	settings_items :source, :type => String	20	settings_items :source, :type => String
		21	+ settings_items :source_name, :type => String
		22	+ settings_items :highlighted, :type => :boolean
		23	+
		24	+ def sender
		25	+ "#{name} (#{email})"
		26	+ end
21		27
22	def perform	28	def perform
23	- TinyMceArticle.create!(:profile => target, :name => article_name, :body => article_body, :abstract => article_abstract, :parent_id => article_parent_id, :source => source, :source_name => name)	29	+ TinyMceArticle.create!(
		30	+ :profile => target,
		31	+ :name => article_name,
		32	+ :body => article_body,
		33	+ :abstract => article_abstract,
		34	+ :parent_id => article_parent_id,
		35	+ :source => source,
		36	+ :source_name => source_name,
		37	+ :highlighted => highlighted
		38	+ )
24	end	39	end
25		40
26	end	41	end
	@@ -5237,17 +5237,3 @@ h1#agenda-title {		@@ -5237,17 +5237,3 @@ h1#agenda-title {
5237	.forum-posts .pagination {	5237	.forum-posts .pagination {
5238	margin-top: 20px;	5238	margin-top: 20px;
5239	}	5239	}
5240	-
5241	-#captcha input {
5242	- border: 1px solid #ccc;
5243	- margin: 4px 0px 2px 10px !important;
5244	- padding: 0px !important;
5245	- width: 150px !important;
5246	- font-size: 24px;
5247	- float: left;
5248	-}
5249	-
5250	-#captcha label{
5251	- float: left;
5252	- font-size: 24px;
5253	-}
	@@ -427,4 +427,8 @@ module Noosfero::Factory		@@ -427,4 +427,8 @@ module Noosfero::Factory
427	{ :profile_id => 1, :path => name, :name => name, :slug => name.to_slug }.merge(params)	427	{ :profile_id => 1, :path => name, :name => name, :slug => name.to_slug }.merge(params)
428	end	428	end
429		429
		430	+ def defaults_for_suggest_article
		431	+ { :name => 'Sender', :email => 'sender@example.com', :article_name => 'Some title', :article_body => 'some body text', :article_abstract => 'some abstract text'}
		432	+ end
		433	+
430	end	434	end
	@@ -86,4 +86,37 @@ class SuggestArticleTest < ActiveSupport::TestCase		@@ -86,4 +86,37 @@ class SuggestArticleTest < ActiveSupport::TestCase
86	assert_equal count + 1, TinyMceArticle.count	86	assert_equal count + 1, TinyMceArticle.count
87	end	87	end
88		88
		89	+ should 'fill source name and URL into created article' do
		90	+ t = build(SuggestArticle, :target => @profile)
		91	+ t.source_name = 'GNU project'
		92	+ t.source = 'http://www.gnu.org/'
		93	+ t.perform
		94	+
		95	+ article = TinyMceArticle.last
		96	+ assert_equal 'GNU project', article.source_name
		97	+ assert_equal 'http://www.gnu.org/', article.source
		98	+ end
		99	+
		100	+ should 'use sender name in description' do
		101	+ t = build(SuggestArticle, :target => @profile)
		102	+ t.stubs(:sender).returns('XYZ')
		103	+ assert_match(/XYZ/, t.description)
		104	+ end
		105	+
		106	+ should 'use name and e-mail as sender info' do
		107	+ t = build(SuggestArticle, :target => @profile)
		108	+ t.name = 'Some One'
		109	+ t.email = 'someone@example.com'
		110	+ assert_match(/.Some One.someone@example.com/, t.sender)
		111	+ end
		112	+
		113	+ should 'highlight created article' do
		114	+ t = build(SuggestArticle, :target => @profile)
		115	+ t.highlighted = true
		116	+ t.perform
		117	+
		118	+ article = TinyMceArticle.last(:conditions => { :name => t.article_name}) # just to be sure
		119	+ assert article.highlighted
		120	+ end
		121	+
89	end	122	end