[Mezuro] Refactoring module_result. Fixed fixtures, started tests and added new …

…methods to module_result.rb

[Mezuro] Refactoring module_result. Fixed fixtures, started tests and added new …
…methods to module_result.rb
Alessandro Palmeira + Caio Salgado · Paulo Meireles
1 parent 7a825ff3
Showing 4 changed files with 66 additions and 23 deletions Show diff stats
plugins/mezuro/lib/kalibro/module_result.rb
plugins/mezuro/test/fixtures/module_result_fixtures.rb
plugins/mezuro/test/unit/kalibro/entities/module_result_test.rb
plugins/mezuro/test/unit/kalibro/module_result_test.rb
@@ -3,14 +3,24 @@ class Kalibro::ModuleResult &lt; Kalibro::Model
   attr_accessor :module, :date, :grade, :metric_result, :compound_metric_with_error
   def self.find_module_result(project_name, module_name, date)
-    result = module_result.request(
+    response = request(
     :get_module_result,
       {
         :project_name => project_name, 
         :module_name => module_name,
         :date => date_with_milliseconds(date)
       })[:module_result]
-    new result
+    new response
+  end
+  
+  def self.all_module_results(project_name, module_name)
+    response = request(
+    :get_result_history,
+      {
+        :project_name => project_name, 
+        :module_name => module_name,
+      })[:module_result]
+    to_entity_array(response)
   end
   #FIXME change Kalibro::Entities::Module
@@ -34,14 +44,23 @@ class Kalibro::ModuleResult &lt; Kalibro::Model
   private
-  def self.module_result
-    endpoint = "ModuleResult"
+  def self.to_entity_array(value)
+    array = value.kind_of?(Array) ? value : [value]
+    array.each.collect { |element| to_entity(element) }
+  end
+  
+  def self.to_entity(value)
+    value.kind_of?(Hash) ? new(value) : value
+  end
+  
+  def self.client
+    endpoint = 'ModuleResult'
     service_address = YAML.load_file("#{RAILS_ROOT}/plugins/mezuro/service.yaml")
     Savon::Client.new("#{service_address}#{endpoint}Endpoint/?wsdl")
   end
   def self.request(action, request_body = nil)
-    response = module_result.request(:kalibro, action) { soap.body = request_body }
+    response = client.request(:kalibro, action) { soap.body = request_body }
     response.to_hash["#{action}_response".to_sym]
   end
@@ -4,24 +4,20 @@ require File.dirname(__FILE__) + &#39;/compound_metric_with_error_fixtures&#39;
 class ModuleResultFixtures
-  def self.create
-    fixture = Kalibro::Entities::ModuleResult.new
-    fixture.module = ModuleFixtures.qt_calculator
-    fixture.date = DateTime.parse('Thu, 20 Oct 2011 18:26:43.151 +0000')
-    fixture.grade = 10.0
-    fixture.metric_results = [
-      MetricResultFixtures.amloc_result,
-      MetricResultFixtures.sc_result]
-    fixture.compound_metrics_with_error = [CompoundMetricWithErrorFixtures.create]
-    fixture
+  def self.module_result
+    fixture = Kalibro::ModuleResult.new( module_result_hash )
   end
-  def self.create_hash
-    {:module => ModuleFixtures.qt_calculator_hash,
-      :date => '2011-10-20T18:26:43.151+00:00', :grade => 10.0, :metric_result => [
+  def self.module_result_hash
+    {
+      :module => ModuleFixtures.qt_calculator_hash,
+      :date => '2011-10-20T18:26:43.151+00:00',
+      :grade => 10.0,
+      :metric_result => [
         MetricResultFixtures.amloc_result_hash,
         MetricResultFixtures.sc_result_hash],
-      :compound_metric_with_error => [CompoundMetricWithErrorFixtures.create_hash]}
+      :compound_metric_with_error => [CompoundMetricWithErrorFixtures.create_hash]
+    }
   end
 end
@@ -5,8 +5,8 @@ require &quot;#{RAILS_ROOT}/plugins/mezuro/test/fixtures/module_result_fixtures&quot;
 class ModuleResultTest < ActiveSupport::TestCase
   def setup
-    @hash = ModuleResultFixtures.create_hash
-    @result = ModuleResultFixtures.create
+    @hash = ModuleResultFixtures.module_result_hash
+    @result = ModuleResultFixtures.module_result
   end
   should 'create module result from hash' do
@@ -14,7 +14,7 @@ class ModuleResultTest &lt; ActiveSupport::TestCase
   end
   should 'convert module result to hash' do
-    assert_equal @hash, @result.to_hash
+    assert_equal @hash, Kalibro::Entities::ModuleResult.to_hash(@result)
   end
-end
 \ No newline at end of file
+end
@@ -0,0 +1,28 @@
+require "test_helper"
+
+require "#{RAILS_ROOT}/plugins/mezuro/test/fixtures/module_result_fixtures"
+
+class ModuleResultTest < ActiveSupport::TestCase
+
+  def setup
+    @hash = ModuleResultFixtures.module_result_hash
+    @module_result = ModuleResultFixtures.module_result
+  end
+  should 'create module result' do
+    assert_equal @module_result.date, Kalibro::ModuleResult.new(@hash).date
+  end
+  
+  should 'convert module result to hash' do
+    assert_equal @hash, @module_result.to_hash
+  end
+
+  should 'find module result' do
+    date_string = '2012-01-10T16:07:15.442-02:00'
+    date = DateTime.parse(date_string)
+    request_body = {:project_name => 'Qt-Calculator', :module_name => 'main', :date => date_string}
+    response = {:module_result => @hash}
+    Kalibro::ModuleResult.expects(:request).with(:get_module_result, request_body).returns(response)
+    assert_equal @module_result, Kalibro::ModuleResult.find_module_result('Qt-Calculator', 'main', date)
+  end
+
+end
@@ -0,0 +1,28 @@		@@ -0,0 +1,28 @@
	1	+require "test_helper"
	2	+
	3	+require "#{RAILS_ROOT}/plugins/mezuro/test/fixtures/module_result_fixtures"
	4	+
	5	+class ModuleResultTest < ActiveSupport::TestCase
	6	+
	7	+ def setup
	8	+ @hash = ModuleResultFixtures.module_result_hash
	9	+ @module_result = ModuleResultFixtures.module_result
	10	+ end
	11	+ should 'create module result' do
	12	+ assert_equal @module_result.date, Kalibro::ModuleResult.new(@hash).date
	13	+ end
	14	+
	15	+ should 'convert module result to hash' do
	16	+ assert_equal @hash, @module_result.to_hash
	17	+ end
	18	+
	19	+ should 'find module result' do
	20	+ date_string = '2012-01-10T16:07:15.442-02:00'
	21	+ date = DateTime.parse(date_string)
	22	+ request_body = {:project_name => 'Qt-Calculator', :module_name => 'main', :date => date_string}
	23	+ response = {:module_result => @hash}
	24	+ Kalibro::ModuleResult.expects(:request).with(:get_module_result, request_body).returns(response)
	25	+ assert_equal @module_result, Kalibro::ModuleResult.find_module_result('Qt-Calculator', 'main', date)
	26	+ end
	27	+
	28	+end