Api error handling

Wesnydy Ribeiro
1 parent 5033e81f
Showing 5 changed files with 58 additions and 17 deletions Show diff stats
translate-api/app.js
translate-api/config/db.js
translate-api/controllers/video.js
translate-api/helpers/amqpManager.js
translate-api/helpers/error.js
@@ -52,8 +52,15 @@ app.use(&#39;/video&#39;, video);
  * Error handler.
  */
 app.use(function(err, req, res, next) {
-    res.status(err.status || 500);
-    res.json({ message: err.message, error: err });
+  if (app.get('env') !== 'development')
+    delete err.stack
+  res.status(err.status).json({
+    error: {
+      'message': err.message,
+      'status': err.status,
+      'stack': err.stack
+    }
+  });
 });
 module.exports = app;
 /**
- * Author: Laércio S. Bezerra
- * Email: laerciosouza@lavid.ufpb.br
+ * Author: Wesnydy L. Ribeiro
+ * Email: wesnydy@lavid.ufpb.br
  */
 /*
@@ -9,13 +9,10 @@
 'use strict';
 /*
- * Required Lib.
+ * Required Libs.
  */
 var mongoose = require('mongoose');
-/*
- * My Lib for javascript Promises
- */
 mongoose.Promise = require('bluebird');
 /*
@@ -10,11 +10,12 @@
  */
 var shortid = require('shortid')
   , Video = require('../models/video')
-  , amqp = require('../helpers/amqpManager');
+  , amqp = require('../helpers/amqpManager')
+  , error = require('../helpers/error');
-exports.create = function(req, res) {
+exports.create = function(req, res, next) {
   if (!req.body.gloss)
-    return console.log('Gloss key missing');
+    return error.badRequest('The gloss key is missing.', next);
   var id = shortid.generate();
   var gloss = req.body.gloss;
@@ -26,7 +27,7 @@ exports.create = function(req, res) {
   new Promise(function (resolve) {
     video.save(function(err) {
       if (err)
-        return console.error(err);
+        return error.internalError('A database error has occurred.', next);
       res.json({ id: video._id });
       resolve(gloss);
     });
@@ -35,10 +36,10 @@ exports.create = function(req, res) {
     return new Promise(function(resolve) {
       amqp.sendToQueue(gloss, id, 'glosses', false, res, function(err) {
         if (err)
-          return console.error(err);
+          return error.internalError('An internal communication error has occurred.', next);
         amqp.receiveFromQueue(id, 'videos', false, res, function(err, message) {
           if (err)
-            return console.error(err);
+            return error.internalError('An internal communication error has occurred.', next);
           resolve(message);
         });
       });
@@ -53,20 +54,20 @@ exports.create = function(req, res) {
           }
         }, {new: true}, function(err, content) {
           if (err)
-            return console.log(err);
+            return error.internalError('A database error has occurred.', next);
         });
     });
   });
 };
-exports.status = function(req, res) {
+exports.status = function(req, res, next) {
   // Receive param id
   var contentID = req.params.id;
   // Find content by id on MongoDB
   return Video.findById(contentID, function (err, video) {
     // returns error when can not find content
     if (err)
-      res.status(404).send('Not Found');
+      return error.notFound('Can\'t find any content.', next);
     else
       res.json( { 'status': video.status, 'file': video.file, 'size': video.size } );
   });
 /**
+ * Author: Jonathan Lincoln Brilhante
+ * Email: jonathan.lincoln.brilhante@gmail.com
+ *
  * Author: Wesnydy Lima Ribeiro
  * Email: wesnydy@lavid.ufpb.br
  */
@@ -0,0 +1,33 @@
+/**
+ * Author: Wesnydy Lima Ribeiro
+ * Email: wesnydy@lavid.ufpb.br
+ */
+
+'use strict';
+
+/**
+ * Error when not find the resource.
+ */
+exports.notFound = function(message, next) {
+  var err = new Error(message || 'The requested resource couldn\'t be found.');
+  err.status = 404;
+  next(err);
+};
+
+/**
+ * Error when receive a malformed request syntax.
+ */
+exports.badRequest = function(message, next) {
+  var err = new Error(message || 'The Request can\'t be fulfilled due to bad syntax.');
+  err.status = 400;
+  next(err);
+};
+
+/**
+ * Error when workers processing.
+ */
+exports.internalError = function(message, next) {
+  var err = new Error(message || 'An internal error occurred during processing.');
+  err.status = 500;
+  next(err);
+};
	@@ -52,8 +52,15 @@ app.use('/video', video);		@@ -52,8 +52,15 @@ app.use('/video', video);
52	* Error handler.	52	* Error handler.
53	*/	53	*/
54	app.use(function(err, req, res, next) {	54	app.use(function(err, req, res, next) {
55	- res.status(err.status \|\| 500);
56	- res.json({ message: err.message, error: err });	55	+ if (app.get('env') !== 'development')
		56	+ delete err.stack
		57	+ res.status(err.status).json({
		58	+ error: {
		59	+ 'message': err.message,
		60	+ 'status': err.status,
		61	+ 'stack': err.stack
		62	+ }
		63	+ });
57	});	64	});
58		65
59	module.exports = app;	66	module.exports = app;
1	/**	1	/**
		2	+ * Author: Jonathan Lincoln Brilhante
		3	+ * Email: jonathan.lincoln.brilhante@gmail.com
		4	+ *
2	* Author: Wesnydy Lima Ribeiro	5	* Author: Wesnydy Lima Ribeiro
3	* Email: wesnydy@lavid.ufpb.br	6	* Email: wesnydy@lavid.ufpb.br
4	*/	7	*/
@@ -0,0 +1,33 @@		@@ -0,0 +1,33 @@
	1	+/**
	2	+ * Author: Wesnydy Lima Ribeiro
	3	+ * Email: wesnydy@lavid.ufpb.br
	4	+ */
	5	+
	6	+'use strict';
	7	+
	8	+/**
	9	+ * Error when not find the resource.
	10	+ */
	11	+exports.notFound = function(message, next) {
	12	+ var err = new Error(message \|\| 'The requested resource couldn\'t be found.');
	13	+ err.status = 404;
	14	+ next(err);
	15	+};
	16	+
	17	+/**
	18	+ * Error when receive a malformed request syntax.
	19	+ */
	20	+exports.badRequest = function(message, next) {
	21	+ var err = new Error(message \|\| 'The Request can\'t be fulfilled due to bad syntax.');
	22	+ err.status = 400;
	23	+ next(err);
	24	+};
	25	+
	26	+/**
	27	+ * Error when workers processing.
	28	+ */
	29	+exports.internalError = function(message, next) {
	30	+ var err = new Error(message \|\| 'An internal error occurred during processing.');
	31	+ err.status = 500;
	32	+ next(err);
	33	+};