Commit 38bb6597cfe13c8d3ad4f79f8c0f331f0518fcf5
1 parent
6347d197
Exists in
colab
and in
4 other branches
Fixing step 'I should not see... within...' #34
Showing
16 changed files
with
31 additions
and
33 deletions
Show diff stats
features/compound_metric_configuration/edition.feature
| ... | ... | @@ -12,7 +12,7 @@ Feature: Compound Metric Configuration edition |
| 12 | 12 | And I have a sample metric configuration within the given mezuro configuration |
| 13 | 13 | And I have a sample compound metric configuration within the given mezuro configuration |
| 14 | 14 | When I am at the Sample Configuration page |
| 15 | - Then I should not see "Edit" | |
| 15 | + Then I should not see Edit within table | |
| 16 | 16 | |
| 17 | 17 | @kalibro_restart |
| 18 | 18 | Scenario: editing a compound metric configuration successfully |
| ... | ... | @@ -64,4 +64,3 @@ Feature: Compound Metric Configuration edition |
| 64 | 64 | And I fill the Code field with "Another_Code" |
| 65 | 65 | And I press the Save button |
| 66 | 66 | Then I should see "Code There is already a MetricConfiguration with code Another_Code! Please, choose another one." |
| 67 | - | ... | ... |
features/metric_configuration/create.feature
| ... | ... | @@ -7,7 +7,7 @@ Feature: Metric Configuration Creation |
| 7 | 7 | Scenario: Should not create metric configurations without login |
| 8 | 8 | Given I have a sample configuration |
| 9 | 9 | And I am at the Sample Configuration page |
| 10 | - Then I should not see New Metric Configuration | |
| 10 | + Then I should not see "New Metric Configuration" | |
| 11 | 11 | |
| 12 | 12 | @kalibro_restart @javascript |
| 13 | 13 | Scenario: metric configuration creation | ... | ... |
features/metric_configuration/edition.feature
| ... | ... | @@ -11,7 +11,7 @@ Feature: Metric Configuration edition |
| 11 | 11 | And I have a sample reading group |
| 12 | 12 | And I have a sample metric configuration within the given mezuro configuration |
| 13 | 13 | When I am at the Sample Configuration page |
| 14 | - Then I should not see "Edit" | |
| 14 | + Then I should not see Edit within table | |
| 15 | 15 | |
| 16 | 16 | @kalibro_restart |
| 17 | 17 | Scenario: editing a metric configuration successfully |
| ... | ... | @@ -49,4 +49,4 @@ Feature: Metric Configuration edition |
| 49 | 49 | And I fill the Weight field with "0" |
| 50 | 50 | And I set the select field "Aggregation Form" as "Median" |
| 51 | 51 | When I press the Save button |
| 52 | - Then I should see "Weight must be greater than 0" | |
| 53 | 52 | \ No newline at end of file |
| 53 | + Then I should see "Weight must be greater than 0" | ... | ... |
features/metric_configuration/listing.feature
features/mezuro_configuration/create.feature
| ... | ... | @@ -6,7 +6,7 @@ Feature: Configuration Creation |
| 6 | 6 | @kalibro_restart |
| 7 | 7 | Scenario: Should not create configuration without login |
| 8 | 8 | Given I am at the All Configurations page |
| 9 | - Then I should not see New Configuration | |
| 9 | + Then I should not see "New Configuration" | |
| 10 | 10 | |
| 11 | 11 | @kalibro_restart |
| 12 | 12 | Scenario: configuration creation |
| ... | ... | @@ -38,4 +38,4 @@ Feature: Configuration Creation |
| 38 | 38 | And I fill the Name field with " " |
| 39 | 39 | And I fill the Description field with "Web Service to collect metrics" |
| 40 | 40 | When I press the Save button |
| 41 | - Then I should see "Name can't be blank" | |
| 42 | 41 | \ No newline at end of file |
| 42 | + Then I should see "Name can't be blank" | ... | ... |
features/mezuro_configuration/deletion.feature
| ... | ... | @@ -7,7 +7,7 @@ Feature: Configuration Deletion |
| 7 | 7 | Scenario: Should not delete a configuration without user authentication |
| 8 | 8 | Given I have a sample configuration |
| 9 | 9 | When I am at the Sample Configuration page |
| 10 | - Then I should not see Destroy | |
| 10 | + Then I should not see "Destroy" | |
| 11 | 11 | |
| 12 | 12 | @kalibro_restart |
| 13 | 13 | Scenario: Should not delete a configuration that doesn't belongs to user |
| ... | ... | @@ -15,7 +15,7 @@ Feature: Configuration Deletion |
| 15 | 15 | And I am signed in |
| 16 | 16 | And I have a sample configuration |
| 17 | 17 | When I am at the Sample Configuration page |
| 18 | - Then I should not see Destroy | |
| 18 | + Then I should not see "Destroy" | |
| 19 | 19 | |
| 20 | 20 | @kalibro_restart |
| 21 | 21 | Scenario: Should delete a configuration that I own | ... | ... |
features/mezuro_configuration/edition.feature
| ... | ... | @@ -18,7 +18,7 @@ Feature: Configuration |
| 18 | 18 | And I am signed in |
| 19 | 19 | And I have a sample configuration |
| 20 | 20 | And I am at the All Configurations page |
| 21 | - Then I should not see "Edit" within "table tr td" | |
| 21 | + Then I should not see Edit within table | |
| 22 | 22 | |
| 23 | 23 | @kalibro_restart |
| 24 | 24 | Scenario: Should not render the edit page if the configuration doesn't belongs to the current user | ... | ... |
features/project/create.feature
| ... | ... | @@ -5,7 +5,7 @@ Feature: Project Creation |
| 5 | 5 | |
| 6 | 6 | Scenario: Should not create project without login |
| 7 | 7 | Given I am at the All Projects page |
| 8 | - Then I should not see New Project | |
| 8 | + Then I should not see "New Project" | |
| 9 | 9 | |
| 10 | 10 | @kalibro_processor_restart |
| 11 | 11 | Scenario: project creation |
| ... | ... | @@ -44,4 +44,4 @@ Feature: Project Creation |
| 44 | 44 | And I am at the homepage |
| 45 | 45 | And I click the Your projects link |
| 46 | 46 | When I click the New Project link |
| 47 | - Then I should see "New Project" | |
| 48 | 47 | \ No newline at end of file |
| 48 | + Then I should see "New Project" | ... | ... |
features/project/deletion.feature
| ... | ... | @@ -7,7 +7,7 @@ Feature: Project Deletion |
| 7 | 7 | Scenario: Should not delete a project without user authetication |
| 8 | 8 | Given I have a sample project |
| 9 | 9 | When I am at the Sample Project page |
| 10 | - Then I should not see Destroy | |
| 10 | + Then I should not see "Destroy" | |
| 11 | 11 | |
| 12 | 12 | @kalibro_processor_restart |
| 13 | 13 | Scenario: Should not delete a project that doesn't belongs to user |
| ... | ... | @@ -15,7 +15,7 @@ Feature: Project Deletion |
| 15 | 15 | And I am signed in |
| 16 | 16 | And I have a sample project |
| 17 | 17 | When I am at the Sample Project page |
| 18 | - Then I should not see Destroy | |
| 18 | + Then I should not see "Destroy" | |
| 19 | 19 | |
| 20 | 20 | @kalibro_processor_restart |
| 21 | 21 | Scenario: Should delete a project that I own |
| ... | ... | @@ -25,4 +25,4 @@ Feature: Project Deletion |
| 25 | 25 | And I am at the Sample Project page |
| 26 | 26 | When I click the Destroy Project link |
| 27 | 27 | Then I should be in the All Projects page |
| 28 | - And the sample project should not be there | |
| 29 | 28 | \ No newline at end of file |
| 29 | + And the sample project should not be there | ... | ... |
features/project/edition.feature
| ... | ... | @@ -18,7 +18,7 @@ Feature: Project |
| 18 | 18 | And I am signed in |
| 19 | 19 | And I have a sample project |
| 20 | 20 | And I am at the All Projects page |
| 21 | - Then I should not see "Edit" within "table tr td" | |
| 21 | + Then I should not see Edit within table | |
| 22 | 22 | |
| 23 | 23 | @kalibro_processor_restart |
| 24 | 24 | Scenario: Should not render the edit page if the project doesn't belongs to the current user | ... | ... |
features/project/show.feature
| ... | ... | @@ -10,9 +10,9 @@ Scenario: Should not show the create repository link to user that doesn't own th |
| 10 | 10 | And I have a sample configuration with native metrics |
| 11 | 11 | And I have a sample repository within the sample project |
| 12 | 12 | When I am at the Sample Project page |
| 13 | - Then I should not see New Repository | |
| 14 | - And I should not see Destroy project | |
| 15 | - And I should not see Edit | |
| 13 | + Then I should not see "New Repository" | |
| 14 | + And I should not see "Destroy project" | |
| 15 | + And I should not see Edit within table | |
| 16 | 16 | |
| 17 | 17 | @kalibro_processor_restart |
| 18 | 18 | Scenario: Should show the create repository link the project owner |
| ... | ... | @@ -35,7 +35,7 @@ Scenario: Considering the project has repositories |
| 35 | 35 | And I have a sample configuration with native metrics |
| 36 | 36 | And I have a sample repository within the sample project |
| 37 | 37 | When I am at the Sample Project page |
| 38 | - Then I should not see There are no Repositories yet! | |
| 38 | + Then I should not see "There are no Repositories yet!" | |
| 39 | 39 | |
| 40 | 40 | @kalibro_processor_restart |
| 41 | 41 | Scenario: Checking project contents | ... | ... |
features/reading_group/create.feature
| ... | ... | @@ -6,7 +6,7 @@ Feature: Reading Group Creation |
| 6 | 6 | @kalibro_restart |
| 7 | 7 | Scenario: Should not create reading groups without login |
| 8 | 8 | Given I am at the All Reading Groups page |
| 9 | - Then I should not see New Reading Group | |
| 9 | + Then I should not see "New Reading Group" | |
| 10 | 10 | |
| 11 | 11 | @kalibro_restart |
| 12 | 12 | Scenario: Reading Group creation |
| ... | ... | @@ -40,4 +40,4 @@ Scenario: reading group creation with blank name |
| 40 | 40 | And I fill the Name field with " " |
| 41 | 41 | And I fill the Description field with "Anything" |
| 42 | 42 | When I press the Save button |
| 43 | - Then I should see "Name can't be blank" | |
| 44 | 43 | \ No newline at end of file |
| 44 | + Then I should see "Name can't be blank" | ... | ... |
features/reading_group/delete.feature
| ... | ... | @@ -7,7 +7,7 @@ Feature: Reading Group Deletion |
| 7 | 7 | Scenario: Should not delete a reading group without user authentication |
| 8 | 8 | Given I have a sample reading group |
| 9 | 9 | When I visit the Sample Reading Group page |
| 10 | - Then I should not see Destroy | |
| 10 | + Then I should not see "Destroy" | |
| 11 | 11 | |
| 12 | 12 | @kalibro_restart |
| 13 | 13 | Scenario: Should not delete a reading group that doesn't belongs to user |
| ... | ... | @@ -15,7 +15,7 @@ Feature: Reading Group Deletion |
| 15 | 15 | And I am signed in |
| 16 | 16 | And I have a sample reading group |
| 17 | 17 | When I visit the Sample Reading Group page |
| 18 | - Then I should not see Destroy | |
| 18 | + Then I should not see "Destroy" | |
| 19 | 19 | |
| 20 | 20 | @kalibro_restart |
| 21 | 21 | Scenario: Should delete a reading group that I own | ... | ... |
features/reading_group/edit.feature
| ... | ... | @@ -18,7 +18,7 @@ Feature: Reading Group |
| 18 | 18 | And I am signed in |
| 19 | 19 | And I have a sample reading group |
| 20 | 20 | And I am at the All Reading Groups page |
| 21 | - Then I should not see "Edit" within "table tr td" | |
| 21 | + Then I should not see Edit within table | |
| 22 | 22 | |
| 23 | 23 | @kalibro_restart |
| 24 | 24 | Scenario: Should not render the edit page if the reading group doesn't belongs to the current user | ... | ... |
features/reading_group/show.feature
| ... | ... | @@ -10,9 +10,9 @@ Scenario: Should not show the create, edit and destroy reading link to user that |
| 10 | 10 | And I have a sample reading within the sample reading group |
| 11 | 11 | When I visit the Sample Reading Group page |
| 12 | 12 | Then I should be in the Sample Reading Group page |
| 13 | - And I should not see New Reading | |
| 14 | - And I should not see Edit | |
| 15 | - And I should not see Destroy | |
| 13 | + And I should not see "New Reading" | |
| 14 | + And I should not see Edit within table | |
| 15 | + And I should not see "Destroy" | |
| 16 | 16 | |
| 17 | 17 | @kalibro_restart |
| 18 | 18 | Scenario: Should show the links for the user that owns the reading group |
| ... | ... | @@ -33,7 +33,7 @@ Scenario: Should show the information of the sample reading |
| 33 | 33 | And I have a sample reading within the sample reading group |
| 34 | 34 | When I visit the Sample Reading Group page |
| 35 | 35 | Then I should be in the Sample Reading Group page |
| 36 | - And I should not see There are no Readings yet! | |
| 36 | + And I should not see "There are no Readings yet!" | |
| 37 | 37 | And I should see "Label" |
| 38 | 38 | And I should see "Grade" |
| 39 | 39 | And I should see "Color" | ... | ... |
features/step_definitions/project_steps.rb
| ... | ... | @@ -38,12 +38,11 @@ Given(/^I am at the New Project page$/) do |
| 38 | 38 | visit new_project_path |
| 39 | 39 | end |
| 40 | 40 | |
| 41 | -Then(/^I should not see (.+)$/) do |text| | |
| 41 | +Then(/^I should not see "(.+)"$/) do |text| | |
| 42 | 42 | expect(page).to_not have_content(text) |
| 43 | 43 | end |
| 44 | 44 | |
| 45 | -#FIXME: this is step is not matched | |
| 46 | -Then(/^I should not see "(.+)"" within "(.+)"$/) do |text, selector| | |
| 45 | +Then(/^I should not see (.+) within (.+)$/) do |text, selector| | |
| 47 | 46 | expect(page.find(selector)).to_not have_content(text) |
| 48 | 47 | end |
| 49 | 48 | ... | ... |