Download as
Browse Code »

Commit 38bb6597cfe13c8d3ad4f79f8c0f331f0518fcf5

Authored by Beatriz Rezener
1 parent 6347d197
Exists in colab and in 4 other branches master, spb-master, spb-stable, stable

Fixing step 'I should not see... within...' #34

Showing 16 changed files with 31 additions and 33 deletions   Show diff stats
features/compound_metric_configuration/edition.feature
  Diff comments   View file @38bb659
@@ -12,7 +12,7 @@ Feature: Compound Metric Configuration edition @@ -12,7 +12,7 @@ Feature: Compound Metric Configuration edition
12 And I have a sample metric configuration within the given mezuro configuration 12 And I have a sample metric configuration within the given mezuro configuration
13 And I have a sample compound metric configuration within the given mezuro configuration 13 And I have a sample compound metric configuration within the given mezuro configuration
14 When I am at the Sample Configuration page 14 When I am at the Sample Configuration page
15 - Then I should not see "Edit" 15 + Then I should not see Edit within table
16 16
17 @kalibro_restart 17 @kalibro_restart
18 Scenario: editing a compound metric configuration successfully 18 Scenario: editing a compound metric configuration successfully
@@ -64,4 +64,3 @@ Feature: Compound Metric Configuration edition @@ -64,4 +64,3 @@ Feature: Compound Metric Configuration edition
64 And I fill the Code field with "Another_Code" 64 And I fill the Code field with "Another_Code"
65 And I press the Save button 65 And I press the Save button
66 Then I should see "Code There is already a MetricConfiguration with code Another_Code! Please, choose another one." 66 Then I should see "Code There is already a MetricConfiguration with code Another_Code! Please, choose another one."
67 -  
features/metric_configuration/create.feature
  Diff comments   View file @38bb659
@@ -7,7 +7,7 @@ Feature: Metric Configuration Creation @@ -7,7 +7,7 @@ Feature: Metric Configuration Creation
7 Scenario: Should not create metric configurations without login 7 Scenario: Should not create metric configurations without login
8 Given I have a sample configuration 8 Given I have a sample configuration
9 And I am at the Sample Configuration page 9 And I am at the Sample Configuration page
10 - Then I should not see New Metric Configuration 10 + Then I should not see "New Metric Configuration"
11 11
12 @kalibro_restart @javascript 12 @kalibro_restart @javascript
13 Scenario: metric configuration creation 13 Scenario: metric configuration creation
features/metric_configuration/edition.feature
  Diff comments   View file @38bb659
@@ -11,7 +11,7 @@ Feature: Metric Configuration edition @@ -11,7 +11,7 @@ Feature: Metric Configuration edition
11 And I have a sample reading group 11 And I have a sample reading group
12 And I have a sample metric configuration within the given mezuro configuration 12 And I have a sample metric configuration within the given mezuro configuration
13 When I am at the Sample Configuration page 13 When I am at the Sample Configuration page
14 - Then I should not see "Edit" 14 + Then I should not see Edit within table
15 15
16 @kalibro_restart 16 @kalibro_restart
17 Scenario: editing a metric configuration successfully 17 Scenario: editing a metric configuration successfully
@@ -49,4 +49,4 @@ Feature: Metric Configuration edition @@ -49,4 +49,4 @@ Feature: Metric Configuration edition
49 And I fill the Weight field with "0" 49 And I fill the Weight field with "0"
50 And I set the select field "Aggregation Form" as "Median" 50 And I set the select field "Aggregation Form" as "Median"
51 When I press the Save button 51 When I press the Save button
52 - Then I should see "Weight must be greater than 0"  
53 \ No newline at end of file 52 \ No newline at end of file
  53 + Then I should see "Weight must be greater than 0"
features/metric_configuration/listing.feature
  Diff comments   View file @38bb659
@@ -34,4 +34,4 @@ Feature: Configuration listing @@ -34,4 +34,4 @@ Feature: Configuration listing
34 And I am signed in 34 And I am signed in
35 And I have a sample configuration 35 And I have a sample configuration
36 When I am at the Sample Configuration page 36 When I am at the Sample Configuration page
37 - Then I should not see Add Metric link 37 + Then I should not see "Add Metric"
features/mezuro_configuration/create.feature
  Diff comments   View file @38bb659
@@ -6,7 +6,7 @@ Feature: Configuration Creation @@ -6,7 +6,7 @@ Feature: Configuration Creation
6 @kalibro_restart 6 @kalibro_restart
7 Scenario: Should not create configuration without login 7 Scenario: Should not create configuration without login
8 Given I am at the All Configurations page 8 Given I am at the All Configurations page
9 - Then I should not see New Configuration 9 + Then I should not see "New Configuration"
10 10
11 @kalibro_restart 11 @kalibro_restart
12 Scenario: configuration creation 12 Scenario: configuration creation
@@ -38,4 +38,4 @@ Feature: Configuration Creation @@ -38,4 +38,4 @@ Feature: Configuration Creation
38 And I fill the Name field with " " 38 And I fill the Name field with " "
39 And I fill the Description field with "Web Service to collect metrics" 39 And I fill the Description field with "Web Service to collect metrics"
40 When I press the Save button 40 When I press the Save button
41 - Then I should see "Name can't be blank"  
42 \ No newline at end of file 41 \ No newline at end of file
  42 + Then I should see "Name can't be blank"
features/mezuro_configuration/deletion.feature
  Diff comments   View file @38bb659
@@ -7,7 +7,7 @@ Feature: Configuration Deletion @@ -7,7 +7,7 @@ Feature: Configuration Deletion
7 Scenario: Should not delete a configuration without user authentication 7 Scenario: Should not delete a configuration without user authentication
8 Given I have a sample configuration 8 Given I have a sample configuration
9 When I am at the Sample Configuration page 9 When I am at the Sample Configuration page
10 - Then I should not see Destroy 10 + Then I should not see "Destroy"
11 11
12 @kalibro_restart 12 @kalibro_restart
13 Scenario: Should not delete a configuration that doesn't belongs to user 13 Scenario: Should not delete a configuration that doesn't belongs to user
@@ -15,7 +15,7 @@ Feature: Configuration Deletion @@ -15,7 +15,7 @@ Feature: Configuration Deletion
15 And I am signed in 15 And I am signed in
16 And I have a sample configuration 16 And I have a sample configuration
17 When I am at the Sample Configuration page 17 When I am at the Sample Configuration page
18 - Then I should not see Destroy 18 + Then I should not see "Destroy"
19 19
20 @kalibro_restart 20 @kalibro_restart
21 Scenario: Should delete a configuration that I own 21 Scenario: Should delete a configuration that I own
features/mezuro_configuration/edition.feature
  Diff comments   View file @38bb659
@@ -18,7 +18,7 @@ Feature: Configuration @@ -18,7 +18,7 @@ Feature: Configuration
18 And I am signed in 18 And I am signed in
19 And I have a sample configuration 19 And I have a sample configuration
20 And I am at the All Configurations page 20 And I am at the All Configurations page
21 - Then I should not see "Edit" within "table tr td" 21 + Then I should not see Edit within table
22 22
23 @kalibro_restart 23 @kalibro_restart
24 Scenario: Should not render the edit page if the configuration doesn't belongs to the current user 24 Scenario: Should not render the edit page if the configuration doesn't belongs to the current user
features/project/create.feature
  Diff comments   View file @38bb659
@@ -5,7 +5,7 @@ Feature: Project Creation @@ -5,7 +5,7 @@ Feature: Project Creation
5 5
6 Scenario: Should not create project without login 6 Scenario: Should not create project without login
7 Given I am at the All Projects page 7 Given I am at the All Projects page
8 - Then I should not see New Project 8 + Then I should not see "New Project"
9 9
10 @kalibro_processor_restart 10 @kalibro_processor_restart
11 Scenario: project creation 11 Scenario: project creation
@@ -44,4 +44,4 @@ Feature: Project Creation @@ -44,4 +44,4 @@ Feature: Project Creation
44 And I am at the homepage 44 And I am at the homepage
45 And I click the Your projects link 45 And I click the Your projects link
46 When I click the New Project link 46 When I click the New Project link
47 - Then I should see "New Project"  
48 \ No newline at end of file 47 \ No newline at end of file
  48 + Then I should see "New Project"
features/project/deletion.feature
  Diff comments   View file @38bb659
@@ -7,7 +7,7 @@ Feature: Project Deletion @@ -7,7 +7,7 @@ Feature: Project Deletion
7 Scenario: Should not delete a project without user authetication 7 Scenario: Should not delete a project without user authetication
8 Given I have a sample project 8 Given I have a sample project
9 When I am at the Sample Project page 9 When I am at the Sample Project page
10 - Then I should not see Destroy 10 + Then I should not see "Destroy"
11 11
12 @kalibro_processor_restart 12 @kalibro_processor_restart
13 Scenario: Should not delete a project that doesn't belongs to user 13 Scenario: Should not delete a project that doesn't belongs to user
@@ -15,7 +15,7 @@ Feature: Project Deletion @@ -15,7 +15,7 @@ Feature: Project Deletion
15 And I am signed in 15 And I am signed in
16 And I have a sample project 16 And I have a sample project
17 When I am at the Sample Project page 17 When I am at the Sample Project page
18 - Then I should not see Destroy 18 + Then I should not see "Destroy"
19 19
20 @kalibro_processor_restart 20 @kalibro_processor_restart
21 Scenario: Should delete a project that I own 21 Scenario: Should delete a project that I own
@@ -25,4 +25,4 @@ Feature: Project Deletion @@ -25,4 +25,4 @@ Feature: Project Deletion
25 And I am at the Sample Project page 25 And I am at the Sample Project page
26 When I click the Destroy Project link 26 When I click the Destroy Project link
27 Then I should be in the All Projects page 27 Then I should be in the All Projects page
28 - And the sample project should not be there  
29 \ No newline at end of file 28 \ No newline at end of file
  29 + And the sample project should not be there
features/project/edition.feature
  Diff comments   View file @38bb659
@@ -18,7 +18,7 @@ Feature: Project @@ -18,7 +18,7 @@ Feature: Project
18 And I am signed in 18 And I am signed in
19 And I have a sample project 19 And I have a sample project
20 And I am at the All Projects page 20 And I am at the All Projects page
21 - Then I should not see "Edit" within "table tr td" 21 + Then I should not see Edit within table
22 22
23 @kalibro_processor_restart 23 @kalibro_processor_restart
24 Scenario: Should not render the edit page if the project doesn't belongs to the current user 24 Scenario: Should not render the edit page if the project doesn't belongs to the current user
features/project/show.feature
  Diff comments   View file @38bb659
@@ -10,9 +10,9 @@ Scenario: Should not show the create repository link to user that doesn't own th @@ -10,9 +10,9 @@ Scenario: Should not show the create repository link to user that doesn't own th
10 And I have a sample configuration with native metrics 10 And I have a sample configuration with native metrics
11 And I have a sample repository within the sample project 11 And I have a sample repository within the sample project
12 When I am at the Sample Project page 12 When I am at the Sample Project page
13 - Then I should not see New Repository  
14 - And I should not see Destroy project  
15 - And I should not see Edit 13 + Then I should not see "New Repository"
  14 + And I should not see "Destroy project"
  15 + And I should not see Edit within table
16 16
17 @kalibro_processor_restart 17 @kalibro_processor_restart
18 Scenario: Should show the create repository link the project owner 18 Scenario: Should show the create repository link the project owner
@@ -35,7 +35,7 @@ Scenario: Considering the project has repositories @@ -35,7 +35,7 @@ Scenario: Considering the project has repositories
35 And I have a sample configuration with native metrics 35 And I have a sample configuration with native metrics
36 And I have a sample repository within the sample project 36 And I have a sample repository within the sample project
37 When I am at the Sample Project page 37 When I am at the Sample Project page
38 - Then I should not see There are no Repositories yet! 38 + Then I should not see "There are no Repositories yet!"
39 39
40 @kalibro_processor_restart 40 @kalibro_processor_restart
41 Scenario: Checking project contents 41 Scenario: Checking project contents
features/reading_group/create.feature
  Diff comments   View file @38bb659
@@ -6,7 +6,7 @@ Feature: Reading Group Creation @@ -6,7 +6,7 @@ Feature: Reading Group Creation
6 @kalibro_restart 6 @kalibro_restart
7 Scenario: Should not create reading groups without login 7 Scenario: Should not create reading groups without login
8 Given I am at the All Reading Groups page 8 Given I am at the All Reading Groups page
9 - Then I should not see New Reading Group 9 + Then I should not see "New Reading Group"
10 10
11 @kalibro_restart 11 @kalibro_restart
12 Scenario: Reading Group creation 12 Scenario: Reading Group creation
@@ -40,4 +40,4 @@ Scenario: reading group creation with blank name @@ -40,4 +40,4 @@ Scenario: reading group creation with blank name
40 And I fill the Name field with " " 40 And I fill the Name field with " "
41 And I fill the Description field with "Anything" 41 And I fill the Description field with "Anything"
42 When I press the Save button 42 When I press the Save button
43 - Then I should see "Name can't be blank"  
44 \ No newline at end of file 43 \ No newline at end of file
  44 + Then I should see "Name can't be blank"
features/reading_group/delete.feature
  Diff comments   View file @38bb659
@@ -7,7 +7,7 @@ Feature: Reading Group Deletion @@ -7,7 +7,7 @@ Feature: Reading Group Deletion
7 Scenario: Should not delete a reading group without user authentication 7 Scenario: Should not delete a reading group without user authentication
8 Given I have a sample reading group 8 Given I have a sample reading group
9 When I visit the Sample Reading Group page 9 When I visit the Sample Reading Group page
10 - Then I should not see Destroy 10 + Then I should not see "Destroy"
11 11
12 @kalibro_restart 12 @kalibro_restart
13 Scenario: Should not delete a reading group that doesn't belongs to user 13 Scenario: Should not delete a reading group that doesn't belongs to user
@@ -15,7 +15,7 @@ Feature: Reading Group Deletion @@ -15,7 +15,7 @@ Feature: Reading Group Deletion
15 And I am signed in 15 And I am signed in
16 And I have a sample reading group 16 And I have a sample reading group
17 When I visit the Sample Reading Group page 17 When I visit the Sample Reading Group page
18 - Then I should not see Destroy 18 + Then I should not see "Destroy"
19 19
20 @kalibro_restart 20 @kalibro_restart
21 Scenario: Should delete a reading group that I own 21 Scenario: Should delete a reading group that I own
features/reading_group/edit.feature
  Diff comments   View file @38bb659
@@ -18,7 +18,7 @@ Feature: Reading Group @@ -18,7 +18,7 @@ Feature: Reading Group
18 And I am signed in 18 And I am signed in
19 And I have a sample reading group 19 And I have a sample reading group
20 And I am at the All Reading Groups page 20 And I am at the All Reading Groups page
21 - Then I should not see "Edit" within "table tr td" 21 + Then I should not see Edit within table
22 22
23 @kalibro_restart 23 @kalibro_restart
24 Scenario: Should not render the edit page if the reading group doesn't belongs to the current user 24 Scenario: Should not render the edit page if the reading group doesn't belongs to the current user
features/reading_group/show.feature
  Diff comments   View file @38bb659
@@ -10,9 +10,9 @@ Scenario: Should not show the create, edit and destroy reading link to user that @@ -10,9 +10,9 @@ Scenario: Should not show the create, edit and destroy reading link to user that
10 And I have a sample reading within the sample reading group 10 And I have a sample reading within the sample reading group
11 When I visit the Sample Reading Group page 11 When I visit the Sample Reading Group page
12 Then I should be in the Sample Reading Group page 12 Then I should be in the Sample Reading Group page
13 - And I should not see New Reading  
14 - And I should not see Edit  
15 - And I should not see Destroy 13 + And I should not see "New Reading"
  14 + And I should not see Edit within table
  15 + And I should not see "Destroy"
16 16
17 @kalibro_restart 17 @kalibro_restart
18 Scenario: Should show the links for the user that owns the reading group 18 Scenario: Should show the links for the user that owns the reading group
@@ -33,7 +33,7 @@ Scenario: Should show the information of the sample reading @@ -33,7 +33,7 @@ Scenario: Should show the information of the sample reading
33 And I have a sample reading within the sample reading group 33 And I have a sample reading within the sample reading group
34 When I visit the Sample Reading Group page 34 When I visit the Sample Reading Group page
35 Then I should be in the Sample Reading Group page 35 Then I should be in the Sample Reading Group page
36 - And I should not see There are no Readings yet! 36 + And I should not see "There are no Readings yet!"
37 And I should see "Label" 37 And I should see "Label"
38 And I should see "Grade" 38 And I should see "Grade"
39 And I should see "Color" 39 And I should see "Color"
features/step_definitions/project_steps.rb
  Diff comments   View file @38bb659
@@ -38,12 +38,11 @@ Given(/^I am at the New Project page$/) do @@ -38,12 +38,11 @@ Given(/^I am at the New Project page$/) do
38 visit new_project_path 38 visit new_project_path
39 end 39 end
40 40
41 -Then(/^I should not see (.+)$/) do |text| 41 +Then(/^I should not see "(.+)"$/) do |text|
42 expect(page).to_not have_content(text) 42 expect(page).to_not have_content(text)
43 end 43 end
44 44
45 -#FIXME: this is step is not matched  
46 -Then(/^I should not see "(.+)"" within "(.+)"$/) do |text, selector| 45 +Then(/^I should not see (.+) within (.+)$/) do |text, selector|
47 expect(page.find(selector)).to_not have_content(text) 46 expect(page.find(selector)).to_not have_content(text)
48 end 47 end
49 48