Reviewing PR #204

signed off by: Rafael Reggiani Manzo <rr.manzo@gmail.com>

Reviewing PR #204
signed off by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
Diego Camarinha
1 parent c3cd29f7
Showing 4 changed files with 5 additions and 12 deletions Show diff stats
app/views/tutorials/analyzing.pt.html.erb
features/step_definitions/repository_steps.rb
features/users/user_update.feature
spec/helpers/application_helper_spec.rb
@@ -30,10 +30,10 @@ A fim de criar um projeto, você deve:
 <ol>
   <li>A partir da página do projeto, clique em "Novo Repositório"</li>
-  <li>Preencha o formulário, garantindo que:
+  <li>Preencha o formulário:
     <ul>
-      <li>O "Nome" seja único</li>
-      <li> Você deve escolher uma "Licença" Open Source na plataforma de acordo com o seu código</li>
+      <li>O "Nome" deve ser único</li>
+      <li>Você deve escolher uma "Licença" Open Source na plataforma de acordo com o seu código</li>
       <li>O campo "Tipo" está relacionado com a ferramenta de controle de versão do código (Git, por exemplo)</li>
       <li>Preencha o "Endereço" com a URL a partir da qual podemos fazer o download do código</li>
       <li>Se você quiser analisar seu projeto periodicamente, configure-o (você pode também executá-lo a partir da interface sempre que quiser)</li>
@@ -114,7 +114,6 @@ When(/^I wait up for the ajax request$/) do
 end
 When(/^I get the Creation Date information as "(.*?)"$/) do |variable|
-  p page.find('p', text: 'Creation Date').text.match(/^Creation Date:(.*)$/).captures
   val = page.find('p', text: 'Creation Date').text.match(/^Creation Date:(.*)$/).captures.first
   eval ("@#{variable} = DateTime.parse('#{val}')")
 end
@@ -172,10 +171,5 @@ end
 Then(/^"(.*?)" should be lesser than "(.*?)"$/) do |arg1, arg2|
   v1 = eval "@#{arg1}"
   v2 = eval "@#{arg2}"
-
-  p v1
-  p v2
-
   expect(v1 < v2).to be_truthy
 end
-
@@ -3,7 +3,6 @@ Feature: User update
   As a regular user
   I want to have an edit page
-  @javascript
   Scenario: with current password
     Given I am a regular user
     And I am signed in
@@ -9,7 +9,7 @@ describe ApplicationHelper, :type =&gt; :helper do
       let!(:translation) { "translated test" }
       before :each do
-        helper.expects(:t).with("activemodel.hints.#{helper.controller_name}.#{attribute_key}").returns(translation)
+        helper.expects(:t).with("activemodel.hints.#{helper.controller_name}.#{attribute_key}", {}).returns(translation)
       end
       it 'is expected to return the hint for the given attribute' do
@@ -23,4 +23,4 @@ describe ApplicationHelper, :type =&gt; :helper do
       end
     end
   end
-end
 \ No newline at end of file
+end
	@@ -114,7 +114,6 @@ When(/^I wait up for the ajax request$/) do		@@ -114,7 +114,6 @@ When(/^I wait up for the ajax request$/) do
114	end	114	end
115		115
116	When(/^I get the Creation Date information as "(.*?)"$/) do \|variable\|	116	When(/^I get the Creation Date information as "(.*?)"$/) do \|variable\|
117	- p page.find('p', text: 'Creation Date').text.match(/^Creation Date:(.*)$/).captures
118	val = page.find('p', text: 'Creation Date').text.match(/^Creation Date:(.*)$/).captures.first	117	val = page.find('p', text: 'Creation Date').text.match(/^Creation Date:(.*)$/).captures.first
119	eval ("@#{variable} = DateTime.parse('#{val}')")	118	eval ("@#{variable} = DateTime.parse('#{val}')")
120	end	119	end
	@@ -172,10 +171,5 @@ end		@@ -172,10 +171,5 @@ end
172	Then(/^"(.?)" should be lesser than "(.?)"$/) do \|arg1, arg2\|	171	Then(/^"(.?)" should be lesser than "(.?)"$/) do \|arg1, arg2\|
173	v1 = eval "@#{arg1}"	172	v1 = eval "@#{arg1}"
174	v2 = eval "@#{arg2}"	173	v2 = eval "@#{arg2}"
175	-
176	- p v1
177	- p v2
178	-
179	expect(v1 < v2).to be_truthy	174	expect(v1 < v2).to be_truthy
180	end	175	end
181	-
	@@ -3,7 +3,6 @@ Feature: User update		@@ -3,7 +3,6 @@ Feature: User update
3	As a regular user	3	As a regular user
4	I want to have an edit page	4	I want to have an edit page
5		5
6	- @javascript
7	Scenario: with current password	6	Scenario: with current password
8	Given I am a regular user	7	Given I am a regular user
9	And I am signed in	8	And I am signed in