Commit 7cc2fe6842f0986434b85b1392e932b199d48b64
Committed by
Heitor
Heitor
1 parent
8d65ed4d
Exists in
colab
and in
4 other branches
Standardize MetricConfigurationsCon[...] comments
Put a blank space between # and text and don't forget about tagging pending fixes with FIXME. Signed off by: Eduardo Araújo <duduktamg@hotmail.com>
Showing
1 changed file
with
4 additions
and
4 deletions
Show diff stats
app/controllers/metric_configurations_controller.rb
| @@ -7,7 +7,7 @@ class MetricConfigurationsController < BaseMetricConfigurationsController | @@ -7,7 +7,7 @@ class MetricConfigurationsController < BaseMetricConfigurationsController | ||
| 7 | 7 | ||
| 8 | def new | 8 | def new |
| 9 | super | 9 | super |
| 10 | - # find_by_name throws an exception instead of returning nil, unlike ActiveRecord's API | 10 | + # FIXME: find_by_name throws an exception instead of returning nil, unlike ActiveRecord's API |
| 11 | metric_configuration.metric = KalibroClient::Entities::Processor::MetricCollectorDetails.find_by_name(params[:metric_collector_name]).find_metric_by_code params[:metric_code] | 11 | metric_configuration.metric = KalibroClient::Entities::Processor::MetricCollectorDetails.find_by_name(params[:metric_collector_name]).find_metric_by_code params[:metric_code] |
| 12 | @reading_groups = ReadingGroup.public_or_owned_by_user(current_user).map { |reading_group| | 12 | @reading_groups = ReadingGroup.public_or_owned_by_user(current_user).map { |reading_group| |
| 13 | [reading_group.name, reading_group.id] | 13 | [reading_group.name, reading_group.id] |
| @@ -24,7 +24,7 @@ class MetricConfigurationsController < BaseMetricConfigurationsController | @@ -24,7 +24,7 @@ class MetricConfigurationsController < BaseMetricConfigurationsController | ||
| 24 | end | 24 | end |
| 25 | 25 | ||
| 26 | def edit | 26 | def edit |
| 27 | - #FIXME: set the configuration id just once! | 27 | + # FIXME: set the configuration id just once! |
| 28 | @kalibro_configuration_id = params[:kalibro_configuration_id] | 28 | @kalibro_configuration_id = params[:kalibro_configuration_id] |
| 29 | @metric_configuration.kalibro_configuration_id = @kalibro_configuration_id | 29 | @metric_configuration.kalibro_configuration_id = @kalibro_configuration_id |
| 30 | @reading_groups = ReadingGroup.public_or_owned_by_user(current_user).map { |reading_group| | 30 | @reading_groups = ReadingGroup.public_or_owned_by_user(current_user).map { |reading_group| |
| @@ -72,7 +72,7 @@ class MetricConfigurationsController < BaseMetricConfigurationsController | @@ -72,7 +72,7 @@ class MetricConfigurationsController < BaseMetricConfigurationsController | ||
| 72 | Rails.cache.delete("#{params[:kalibro_configuration_id]}_hotspot_metric_configurations") | 72 | Rails.cache.delete("#{params[:kalibro_configuration_id]}_hotspot_metric_configurations") |
| 73 | end | 73 | end |
| 74 | 74 | ||
| 75 | - # Duplicated code on create and update actions extracted here | 75 | + # FIXME: Duplicated code on create and update actions extracted here |
| 76 | def failed_action(format, destiny_action) | 76 | def failed_action(format, destiny_action) |
| 77 | @kalibro_configuration_id = params[:kalibro_configuration_id] | 77 | @kalibro_configuration_id = params[:kalibro_configuration_id] |
| 78 | 78 | ||
| @@ -80,7 +80,7 @@ class MetricConfigurationsController < BaseMetricConfigurationsController | @@ -80,7 +80,7 @@ class MetricConfigurationsController < BaseMetricConfigurationsController | ||
| 80 | format.json { render json: @metric_configuration.kalibro_errors, status: :unprocessable_entity } | 80 | format.json { render json: @metric_configuration.kalibro_errors, status: :unprocessable_entity } |
| 81 | end | 81 | end |
| 82 | 82 | ||
| 83 | - #Code extracted from create action | 83 | + # Code extracted from create action |
| 84 | def create_and_redir(format) | 84 | def create_and_redir(format) |
| 85 | if @metric_configuration.save | 85 | if @metric_configuration.save |
| 86 | format.html { redirect_to kalibro_configuration_path(@metric_configuration.kalibro_configuration_id), notice: t('successfully_created', :record => t(metric_configuration.class)) } | 86 | format.html { redirect_to kalibro_configuration_path(@metric_configuration.kalibro_configuration_id), notice: t('successfully_created', :record => t(metric_configuration.class)) } |