Add the structure to display hotspot metric results

* WIP: cucumber feature to show hotspot metric results * Add partials to list hotspot metric results * Add necessary JS to render the list of hotspot metric results on the right place div of the accordion * Translations specific to hotspot metric results * HotspotMetric and HotspotMetricConfiguration factories Signed off by: Eduardo Silva Araújo <duduktamg@hotmail.com>

Add the structure to display hotspot metric results
* WIP: cucumber feature to show hotspot metric results * Add partials to list hotspot metric results * Add necessary JS to render the list of hotspot metric results on the right place div of the accordion * Translations specific to hotspot metric results * HotspotMetric and HotspotMetricConfiguration factories Signed off by: Eduardo Silva Araújo <duduktamg@hotmail.com>
Diego Camarinha · Heitor
1 parent 4461895c
Showing 11 changed files with 70 additions and 4 deletions Show diff stats
app/assets/javascripts/module/tree.js.coffee
app/views/modules/_hotspot_metric_result.html.erb
app/views/modules/_hotspot_metric_results.html.erb
app/views/modules/load_module_tree.js.erb
config/locales/views/metric_results/en.yml
config/locales/views/metric_results/pt.yml
features/repository/show/hotspot_metric_results.feature
features/step_definitions/kalibro_configuration_steps.rb
features/step_definitions/repository_steps.rb
spec/factories/metric_configurations.rb
spec/factories/metrics.rb
 class Module.Tree
   @load: (loading_html, module_id) ->
+    # FIXME: The messages we send on loading_html are the same already
+    # shown on the Repository's show page
     $('div#module_tree').html(loading_html)
     $('div#metric_results').html(loading_html)
+    $('div#hotspot_metric_results').html(loading_html)
     $.post Routes.module_tree_path(module_id)
@@ -0,0 +1,4 @@
+<tr>
+  <td><%= hotspot_metric_result.line_number %></td>
+  <td><%= hotspot_metric_result.message %></td>
+</tr>
@@ -0,0 +1,14 @@
+<table class="table table-hover metric_results">
+  <thead>
+    <tr>
+      <th><%= t('activemodel.attributes.hotspot_metric_result.line') %></th>
+      <th><%= t('activemodel.attributes.hotspot_metric_result.message') %></th>
+    </tr>
+  </thead>
+
+  <tbody>
+    <% cache("#{@root_module_result.id}_hotspot_results") do %>
+      <%= render partial: 'hotspot_metric_result', collection: @root_module_result.hotspot_metric_results, locals: {module_result: @root_module_result} %>
+    <% end %>
+  </tbody>
+</table>
 $('div#module_tree').html('<%= escape_javascript(render partial: "module_tree") %>');
+$('div#hotspot_metric_results').html('<%= escape_javascript(render partial: "hotspot_metric_results") %>')
 $('div#metric_results').html('<%= escape_javascript(render partial: "metric_results") %>');
@@ -17,3 +17,6 @@ en:
         name: "Name"
         granularity: "Granularity"
         grade: "Grade"
+      hotspot_metric_result:
+        line: "Line"
+        message: "Message"
@@ -16,4 +16,7 @@ pt:
       kalibro_module:
         name: "Nome"
         granularity: "Granularidade"
-        grade: "Nota"
 \ No newline at end of file
+        grade: "Nota"
+      hotspot_metric_result:
+        line: "Linha"
+        message: "Mensagem"
@@ -3,6 +3,22 @@ Feature: Repository hotspot metric results
   As a regular user
   I should see the hotspot metric results list
+  @kalibro_configuration_restart @kalibro_processor_restart @javascript @wip
+  Scenario: Should show the message when the graphic of the given metric has only a single point
+    Given I am a regular user
+    And I am signed in
+    And I have a sample project
+    And I have a sample configuration with hotspot metrics
+    And I have a sample ruby repository within the sample project
+    And I start to process that repository
+    And I wait up for a ready processing
+    And I ask for the last ready processing of the given repository
+    And I ask for the module result of the given processing
+    And I ask for the hotspot metric results of the given module result
+    When I visit the repository show page
+    And I click the "Hotspot Metric Results" h3
+    Then I should see a list of hotspot metric results
+
   @kalibro_configuration_restart @kalibro_processor_restart @javascript
   Scenario: Should show the error message when the process fails
     Given I am a regular user
@@ -13,7 +13,14 @@ end
 Given(/^I have a sample configuration$/) do
   @kalibro_configuration = FactoryGirl.create(:kalibro_configuration)
   FactoryGirl.create(:kalibro_configuration_attributes, user_id: FactoryGirl.create(:another_user).id, kalibro_configuration_id: @kalibro_configuration.id)
+end
+Given(/^I have a sample configuration with hotspot metrics$/) do
+  @kalibro_configuration = FactoryGirl.create(:kalibro_configuration, name: 'Sample Ruby Configuration')
+  FactoryGirl.create(:kalibro_configuration_attributes, {id: nil, user_id: @user.id, kalibro_configuration_id: @kalibro_configuration.id})
+
+  metric_configuration = FactoryGirl.create(:hotspot_metric_configuration,
+                                            { kalibro_configuration_id: @kalibro_configuration.id} )
 end
 Given(/^I own a sample configuration$/) do
@@ -94,4 +101,3 @@ Then(/^the private configuration should not be there$/) do
   expect(page).to have_no_content(@private_kc.name)
   expect(page).to have_no_content(@private_kc.description)
 end
-
@@ -99,6 +99,10 @@ Given(/^I ask for the metric results of the given module result$/) do
   @metric_results = @module_result.tree_metric_results
 end
+Given(/^I ask for the hotspot metric results of the given module result$/) do
+  @metric_results = @module_result.hotspot_metric_results
+end
+
 Given(/^I see a sample metric's name$/) do
   expect(page).to have_content(@metric_results.first.metric_configuration.metric.name)
 end
@@ -219,5 +223,3 @@ end
 Then(/^I should be at the Repositories index$/) do
   expect(page.current_path).to end_with(repositories_path) # We use end_with in order to avoid the language route
 end
-
-
@@ -35,4 +35,8 @@ FactoryGirl.define do
     kalibro_configuration_id 1
   end
+  factory :hotspot_metric_configuration, class: MetricConfiguration do
+    metric { FactoryGirl.build(:hotspot_metric) }
+    kalibro_configuration_id 1
+  end
 end
@@ -52,4 +52,14 @@ FactoryGirl.define do
     initialize_with { new(name, code, scope, script) }
   end
+
+  factory :hotspot_metric, class: KalibroClient::Entities::Miscellaneous::HotspotMetric do
+    name "Flay"
+    code "flay"
+    description ""
+    metric_collector_name "MetricFu"
+    languages nil
+
+    initialize_with { new(name, code, languages, metric_collector_name) }
+  end
 end
@@ -0,0 +1,4 @@		@@ -0,0 +1,4 @@
	1	+<tr>
	2	+ <td><%= hotspot_metric_result.line_number %></td>
	3	+ <td><%= hotspot_metric_result.message %></td>
	4	+</tr>
@@ -0,0 +1,14 @@		@@ -0,0 +1,14 @@
	1	+<table class="table table-hover metric_results">
	2	+ <thead>
	3	+ <tr>
	4	+ <th><%= t('activemodel.attributes.hotspot_metric_result.line') %></th>
	5	+ <th><%= t('activemodel.attributes.hotspot_metric_result.message') %></th>
	6	+ </tr>
	7	+ </thead>
	8	+
	9	+ <tbody>
	10	+ <% cache("#{@root_module_result.id}_hotspot_results") do %>
	11	+ <%= render partial: 'hotspot_metric_result', collection: @root_module_result.hotspot_metric_results, locals: {module_result: @root_module_result} %>
	12	+ <% end %>
	13	+ </tbody>
	14	+</table>
1	$('div#module_tree').html('<%= escape_javascript(render partial: "module_tree") %>');	1	$('div#module_tree').html('<%= escape_javascript(render partial: "module_tree") %>');
		2	+$('div#hotspot_metric_results').html('<%= escape_javascript(render partial: "hotspot_metric_results") %>')
2	$('div#metric_results').html('<%= escape_javascript(render partial: "metric_results") %>');	3	$('div#metric_results').html('<%= escape_javascript(render partial: "metric_results") %>');
	@@ -17,3 +17,6 @@ en:		@@ -17,3 +17,6 @@ en:
17	name: "Name"	17	name: "Name"
18	granularity: "Granularity"	18	granularity: "Granularity"
19	grade: "Grade"	19	grade: "Grade"
		20	+ hotspot_metric_result:
		21	+ line: "Line"
		22	+ message: "Message"
	@@ -16,4 +16,7 @@ pt:		@@ -16,4 +16,7 @@ pt:
16	kalibro_module:	16	kalibro_module:
17	name: "Nome"	17	name: "Nome"
18	granularity: "Granularidade"	18	granularity: "Granularidade"
19	- grade: "Nota"
20	\ No newline at end of file	19	\ No newline at end of file
		20	+ grade: "Nota"
		21	+ hotspot_metric_result:
		22	+ line: "Linha"
		23	+ message: "Mensagem"
	@@ -3,6 +3,22 @@ Feature: Repository hotspot metric results		@@ -3,6 +3,22 @@ Feature: Repository hotspot metric results
3	As a regular user	3	As a regular user
4	I should see the hotspot metric results list	4	I should see the hotspot metric results list
5		5
		6	+ @kalibro_configuration_restart @kalibro_processor_restart @javascript @wip
		7	+ Scenario: Should show the message when the graphic of the given metric has only a single point
		8	+ Given I am a regular user
		9	+ And I am signed in
		10	+ And I have a sample project
		11	+ And I have a sample configuration with hotspot metrics
		12	+ And I have a sample ruby repository within the sample project
		13	+ And I start to process that repository
		14	+ And I wait up for a ready processing
		15	+ And I ask for the last ready processing of the given repository
		16	+ And I ask for the module result of the given processing
		17	+ And I ask for the hotspot metric results of the given module result
		18	+ When I visit the repository show page
		19	+ And I click the "Hotspot Metric Results" h3
		20	+ Then I should see a list of hotspot metric results
		21	+
6	@kalibro_configuration_restart @kalibro_processor_restart @javascript	22	@kalibro_configuration_restart @kalibro_processor_restart @javascript
7	Scenario: Should show the error message when the process fails	23	Scenario: Should show the error message when the process fails
8	Given I am a regular user	24	Given I am a regular user
	@@ -13,7 +13,14 @@ end		@@ -13,7 +13,14 @@ end
13	Given(/^I have a sample configuration$/) do	13	Given(/^I have a sample configuration$/) do
14	@kalibro_configuration = FactoryGirl.create(:kalibro_configuration)	14	@kalibro_configuration = FactoryGirl.create(:kalibro_configuration)
15	FactoryGirl.create(:kalibro_configuration_attributes, user_id: FactoryGirl.create(:another_user).id, kalibro_configuration_id: @kalibro_configuration.id)	15	FactoryGirl.create(:kalibro_configuration_attributes, user_id: FactoryGirl.create(:another_user).id, kalibro_configuration_id: @kalibro_configuration.id)
		16	+end
16		17
		18	+Given(/^I have a sample configuration with hotspot metrics$/) do
		19	+ @kalibro_configuration = FactoryGirl.create(:kalibro_configuration, name: 'Sample Ruby Configuration')
		20	+ FactoryGirl.create(:kalibro_configuration_attributes, {id: nil, user_id: @user.id, kalibro_configuration_id: @kalibro_configuration.id})
		21	+
		22	+ metric_configuration = FactoryGirl.create(:hotspot_metric_configuration,
		23	+ { kalibro_configuration_id: @kalibro_configuration.id} )
17	end	24	end
18		25
19	Given(/^I own a sample configuration$/) do	26	Given(/^I own a sample configuration$/) do
	@@ -94,4 +101,3 @@ Then(/^the private configuration should not be there$/) do		@@ -94,4 +101,3 @@ Then(/^the private configuration should not be there$/) do
94	expect(page).to have_no_content(@private_kc.name)	101	expect(page).to have_no_content(@private_kc.name)
95	expect(page).to have_no_content(@private_kc.description)	102	expect(page).to have_no_content(@private_kc.description)
96	end	103	end
97	-
	@@ -99,6 +99,10 @@ Given(/^I ask for the metric results of the given module result$/) do		@@ -99,6 +99,10 @@ Given(/^I ask for the metric results of the given module result$/) do
99	@metric_results = @module_result.tree_metric_results	99	@metric_results = @module_result.tree_metric_results
100	end	100	end
101		101
		102	+Given(/^I ask for the hotspot metric results of the given module result$/) do
		103	+ @metric_results = @module_result.hotspot_metric_results
		104	+end
		105	+
102	Given(/^I see a sample metric's name$/) do	106	Given(/^I see a sample metric's name$/) do
103	expect(page).to have_content(@metric_results.first.metric_configuration.metric.name)	107	expect(page).to have_content(@metric_results.first.metric_configuration.metric.name)
104	end	108	end
	@@ -219,5 +223,3 @@ end		@@ -219,5 +223,3 @@ end
219	Then(/^I should be at the Repositories index$/) do	223	Then(/^I should be at the Repositories index$/) do
220	expect(page.current_path).to end_with(repositories_path) # We use end_with in order to avoid the language route	224	expect(page.current_path).to end_with(repositories_path) # We use end_with in order to avoid the language route
221	end	225	end
222	-
223	-
	@@ -35,4 +35,8 @@ FactoryGirl.define do		@@ -35,4 +35,8 @@ FactoryGirl.define do
35	kalibro_configuration_id 1	35	kalibro_configuration_id 1
36	end	36	end
37		37
		38	+ factory :hotspot_metric_configuration, class: MetricConfiguration do
		39	+ metric { FactoryGirl.build(:hotspot_metric) }
		40	+ kalibro_configuration_id 1
		41	+ end
38	end	42	end
	@@ -52,4 +52,14 @@ FactoryGirl.define do		@@ -52,4 +52,14 @@ FactoryGirl.define do
52		52
53	initialize_with { new(name, code, scope, script) }	53	initialize_with { new(name, code, scope, script) }
54	end	54	end
		55	+
		56	+ factory :hotspot_metric, class: KalibroClient::Entities::Miscellaneous::HotspotMetric do
		57	+ name "Flay"
		58	+ code "flay"
		59	+ description ""
		60	+ metric_collector_name "MetricFu"
		61	+ languages nil
		62	+
		63	+ initialize_with { new(name, code, languages, metric_collector_name) }
		64	+ end
55	end	65	end