08 Jun, 2016

4 commits

20 Apr, 2016

1 commit

  • 75f3fbe9   Fix home page latest content cache efectiveness ... Browse Dir » 
    There were instance variables filled by fetching the latest content
every time, defeating the purpose of the fragment caches in the view.

Replace them with helper methods, that also make the number of items
visible in the view.

Signed-off-by: otaviocv <otavio@deluqui.com.br>
    Daniel
     

18 Apr, 2016

1 commit

16 Apr, 2016

1 commit

15 Apr, 2016

1 commit

13 Apr, 2016

1 commit

11 Apr, 2016

1 commit

  • b2d7c543   Refactor Webhook support to allow verification of parameters ... Browse Dir » 
    Ensure webhook requests are only accepted after proper verification of
expected headers, repository address and branch, using the newly
implemented library.

To that effect, split up the logic to extract that information from
requests to it's own class, and use it in the notify_push action.

Also, add factories to make better testing of the notify_push action
possible, such as a factory similar to a real request from Gitlab, and
one for the Kalibro Client repository on Gitlab.

Adding other hook providers should be quite a lot easier after this is
applied.
    Daniel
     

04 Apr, 2016

1 commit

30 Mar, 2016

1 commit

17 Feb, 2016

1 commit

29 Jan, 2016

1 commit

  • 5ee25d55   Replace url helpers by the path ones ... Browse Dir » 
    This is expected to improve compatibility with reverse-proxies.

Still, for full compatibility, regarding redirections, we still may
need to set the default url options with the proxy host.

Signed-off-by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
    Heitor
     

22 Jan, 2016

3 commits

20 Jan, 2016

6 commits

  • 8a7dfde2   I18n missing BaseMetricConfigurations messages ... Browse Dir » 
    Signed-off-by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
    Heitor
     
  • 2f185be5   Skip coverage check for metric_configuration_params ... Browse Dir » 
    The code is pretty straightforward, just raising an Error in order to
force subclasses to implement this.

Signed-off-by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
    Heitor
     
  • eaaf4f2f   Add proper Reading Group fetching in Metric Configurations controllers ... Browse Dir » 
    Also improve error reporting functions
    Daniel
     
  • eaa33fc4   Refactor MetricConfiguration controllers ... Browse Dir » 
    Move as much code as possible to BaseMetricConfigurationsController
instead of repeating it ad-hoc in the concrete classes. Most of the
concrete code has gone away except for some small overrides:

- Hotspot's does not have a 'new' action, and therefore can't redirect
to it. It also does not accept any MetricConfiguration parameters.
- Metric's only accepts 'weight' and 'aggregation_form'
MetricConfiguration parameters. It also needs to fetch ReadingGroups to
display in the 'choose_metric' action.
- Compound's needs to force the Metric type when creating the metric,
and must accept parameters for Metric ('name', 'description', 'script',
'scope', 'code') in addition to MetricConfiguration's 'weight'.

Additionally:
- Update cache clearing to clear caches for Hotspot and Tree
configurations
- Verify the existence of the KalibroConfiguration and use the object
that was fetched whenever necessary, instead of only using the id.
- Ensure the KalibroConfiguration and ReadingGroup ids match between the
values inside and outside the 'metric_configuration' parameter.
Previously it was possible to send one in the URL and update another,
which might even have been a security issue.
- Allow sending either 'metric_code' or 'metric_name' as a parameter.
Both are used in different places in the code, but making them uniform
is a job for a later time.

Signed off by: Daniel Miranda <danielkza2@gmail.com>
    Heitor
     
  • c91af636   Add a redirect on hotspot metric configuration creation ... Browse Dir » 
    Now it doesn't redirect to the tree metric configuration creation page
after choosing a hotspot metric configuration

Adds a bunch of code from removed commit
ec4c3ef6f29aa34f3c58819df4f84725aff8bd60 that fixed the view after the
modification introduced by 39bc97f568d6989ae98b1f5fd5452515ee54045f.

It fixes the view to properly work with the path helper.

This is a squash of two commits.

Signed off by: Diego Araújo <diegoamc90@gmail.com>
Signed off by: Heitor Reis <marcheing@gmail.com>
    Heitor
     
  • 07fca75c   Create HotspotMetricConfigurationsController ... Browse Dir » 
    It has just the prototype for the method so its route works. This
route will be useful when creating the upcoming helper method for metric
configuration creation form.

Signed off by: Heitor Reis <marcheing@gmail.com>
    Rafael Manzo
     

12 Jan, 2016

1 commit

  • 7e89b4a3   Replace url route helpers by path ones ... Browse Dir » 
    Using URL helpers is not friendly with proxies like Colab. The path
helpers have the same effect unless we want sometime to render pages
outside Prezento context like embeds or sending emails.

Signed off by: Diego Araújo <diegoamc90@gmail.com>
    Rafael Manzo
     

23 Nov, 2015

2 commits

19 Nov, 2015

1 commit

09 Nov, 2015

1 commit

  • 057737c7   Fix ProjectAttributes association with Project ... Browse Dir » 
      * Renamed ProjectAttributes' column hidden to public and inverted
    default values
  * Implemented Project#"public_or_owned_by_user"
  * All features now create ProjectAttributes after creating a Project
  * Implemented ProjectAttributes#project and ProjectAttributes#project=
  * Fix Project#attributes to return nil when there is no
    ProjectAttribute
  * Fixes #263

Signed off by: Diego Araújo <diegoamc90@gmail.com>
    Heitor
     

28 Oct, 2015

1 commit

26 Oct, 2015

3 commits

11 Sep, 2015

1 commit

14 Aug, 2015

1 commit

08 Jul, 2015

2 commits

06 Jul, 2015

1 commit

24 Jun, 2015

1 commit

22 Jun, 2015

1 commit

17 Jun, 2015

1 commit

  • e19c7cef   Repository routes decoupled from Project ... Browse Dir » 
    new and create action can be acessed both with or without a project. This
enables to have repositories the two ways.

The behaviour for the back had to change from going back to a specific project
page. To the all projects pages since some repositories may not have a
project_id.

With the routes, many helpers had to get fixed together with acceptance
tests steps (for this a new step was created in order to be able to create
RepositoryAttributes).

Finally the JS for repository state retrieval needed fixes since it builds the
route withot any helper. Same thing for the JS that prevents infinite state
queries.

Signed off by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
    Pedro