18 Apr, 2016

1 commit

11 Apr, 2016

1 commit

  • b2d7c543   Refactor Webhook support to allow verification of parameters ... Browse File » 
    Ensure webhook requests are only accepted after proper verification of
expected headers, repository address and branch, using the newly
implemented library.

To that effect, split up the logic to extract that information from
requests to it's own class, and use it in the notify_push action.

Also, add factories to make better testing of the notify_push action
possible, such as a factory similar to a real request from Gitlab, and
one for the Kalibro Client repository on Gitlab.

Adding other hook providers should be quite a lot easier after this is
applied.
    Daniel
     

04 Apr, 2016

1 commit

23 Nov, 2015

2 commits

19 Nov, 2015

1 commit

14 Aug, 2015

1 commit

08 Jul, 2015

2 commits

06 Jul, 2015

1 commit

24 Jun, 2015

1 commit

22 Jun, 2015

1 commit

17 Jun, 2015

1 commit

  • e19c7cef   Repository routes decoupled from Project ... Browse File » 
    new and create action can be acessed both with or without a project. This
enables to have repositories the two ways.

The behaviour for the back had to change from going back to a specific project
page. To the all projects pages since some repositories may not have a
project_id.

With the routes, many helpers had to get fixed together with acceptance
tests steps (for this a new step was created in order to be able to create
RepositoryAttributes).

Finally the JS for repository state retrieval needed fixes since it builds the
route withot any helper. Same thing for the JS that prevents infinite state
queries.

Signed off by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
    Pedro
     

16 Jun, 2015

2 commits

22 May, 2015

1 commit

21 May, 2015

2 commits

27 Apr, 2015

1 commit

  • e390e540   Correct error handling for resource finding in controllers ... Browse File » 
    Error handling for finding resources in controllers used a find_resource
method. It was broken and was letting code pass-through after errors. In
addition, cases for find methods for things other than simple IDs
weren't handled.

Replace it with an error handler in ApplicationController capturing
RecordNotFound exceptions and returning the appropriate error pages (or
JSON).

Also, fix usages of find that should throw errors (using ActiveRecord
methods ending with !) but didn't.

Correspondly, fix all the tests that mocked the find_resource method,
and correct expectations where needed.

Signed-off-by: Daniel Miranda <danielkza2@gmail.com>
    Diego Camarinha
     

17 Apr, 2015

1 commit

27 Feb, 2015

1 commit

23 Feb, 2015

1 commit

12 Feb, 2015

3 commits

10 Dec, 2014

1 commit

08 Oct, 2014

1 commit

26 Sep, 2014

1 commit

12 Sep, 2014

3 commits

26 Feb, 2014

2 commits

28 Jan, 2014

2 commits

21 Jan, 2014

1 commit

16 Dec, 2013

1 commit

11 Dec, 2013

2 commits

09 Dec, 2013

1 commit