08 Jun, 2016

6 commits


28 May, 2016

1 commit


04 May, 2016

1 commit


20 Apr, 2016

2 commits


18 Apr, 2016

3 commits


16 Apr, 2016

2 commits


15 Apr, 2016

2 commits


13 Apr, 2016

2 commits


11 Apr, 2016

2 commits

  • The repository/notify_push feature was making post request directly
    using Rack::Test methods, which is not optimal when we have Capybara to
    handle all the driver setup and flexibility for us.
    
    Change it to use Capybara methods, and fix all the steps accordingly. To
    make things easier, add some helper methods to deal with headers in
    different drivers.
    
    Also fix a small clarity issue in the notify_push unity tests that also
    have to set headers.
    Daniel
     
  • Ensure webhook requests are only accepted after proper verification of
    expected headers, repository address and branch, using the newly
    implemented library.
    
    To that effect, split up the logic to extract that information from
    requests to it's own class, and use it in the notify_push action.
    
    Also, add factories to make better testing of the notify_push action
    possible, such as a factory similar to a real request from Gitlab, and
    one for the Kalibro Client repository on Gitlab.
    
    Adding other hook providers should be quite a lot easier after this is
    applied.
    Daniel
     

04 Apr, 2016

1 commit

  • A bug in notify_push was missed due to CSRF protection being disabled in
    the test environment. Fix that by adding a tag that can enabled it in
    some features.
    
    We might eventually want to enable it for all acceptance tests to make
    sure other cases like this don't show up.
    Daniel
     

22 Feb, 2016

2 commits


20 Jan, 2016

6 commits


25 Nov, 2015

1 commit


19 Nov, 2015

3 commits


09 Nov, 2015

2 commits

  •   * Closes Issue #218
    
    KalibroClient returns 0 instead of nil when the module has no parent.
    
    Signed-off-by: Eduardo Silva Araújo <duduktamg@hotmail.com>
    Diego Camarinha
     
  •   * Renamed ProjectAttributes' column hidden to public and inverted
        default values
      * Implemented Project#"public_or_owned_by_user"
      * All features now create ProjectAttributes after creating a Project
      * Implemented ProjectAttributes#project and ProjectAttributes#project=
      * Fix Project#attributes to return nil when there is no
        ProjectAttribute
      * Fixes #263
    
    Signed off by: Diego Araújo <diegoamc90@gmail.com>
    Heitor
     

06 Nov, 2015

2 commits


28 Oct, 2015

1 commit

  •  * Also the previous conditional in the view was unnecessary because the
     kalibro_ranges method never returns nil, at most it returns an empty
     array, which is checked by another conditional in the same view
    
    Signed off by: Eduardo Araújo <duduktamg@hotmail.com>
    Heitor
     

26 Oct, 2015

1 commit