08 Jun, 2016
3 commits
-
This reverts commit 4211de4d7a8af53111995500e4d7c225023e143c. The right way to set the subdirectory is by setting the Rack mount on config.ru or on the webserver like apache or nginx.
-
Signed-off-by: Heitor Reis Ribeiro <marcheing@gmail.com>
04 May, 2016
1 commit
-
This is meant to ensure we remember when we commit changes without tests. Also, to be able to run all the tests locally without worrying about that, we make the minimum coverage only required if the environment variable 'CI' is set to true. In practice, this means we only check minimun coverage if we are building the environment on travis. Also remove some default configurations for Rails on Simplecov. Updates CHANGELOG
20 Apr, 2016
1 commit
-
Unit tests cannot expects that models will always be fetched. But to make sure things are still well tested, verify the existence of a configuration, project and repository in the homepage feature.
18 Apr, 2016
5 commits
-
This method is a copy and paste from other methods (of Project, for example) and should be refactored to avoid code duplications.
-
Signed-off-by: Heitor Reis <marcheing@gmail.com>
16 Apr, 2016
1 commit
-
It makes it harder for an user to mistakenly add a metric to their script that will never work. Signed-off-by: Eduardo Araújo <duduktamg@hotmail.com>
15 Apr, 2016
1 commit
-
They were moved to mezuro.github.io Signed-off-by: Rafael Reggiani Manzo <rr.manzo@protonmail.com>
13 Apr, 2016
3 commits
-
The acceptance test has been refactored accordingly and got more extended to untested features.
-
This is a information that will get published at the homepage.
-
This is a information that will get published at the homepage.
11 Apr, 2016
4 commits
-
The repository/notify_push feature was making post request directly using Rack::Test methods, which is not optimal when we have Capybara to handle all the driver setup and flexibility for us. Change it to use Capybara methods, and fix all the steps accordingly. To make things easier, add some helper methods to deal with headers in different drivers. Also fix a small clarity issue in the notify_push unity tests that also have to set headers.
-
Ensure webhook requests are only accepted after proper verification of expected headers, repository address and branch, using the newly implemented library. To that effect, split up the logic to extract that information from requests to it's own class, and use it in the notify_push action. Also, add factories to make better testing of the notify_push action possible, such as a factory similar to a real request from Gitlab, and one for the Kalibro Client repository on Gitlab. Adding other hook providers should be quite a lot easier after this is applied.
-
It can abstract different webhook formats for different services, and have verification of request, repository address and branch information.
08 Apr, 2016
1 commit
-
Signed-off-by: Daniel Miranda <danielkza2@gmail.com>
30 Mar, 2016
1 commit
-
Update KalibroClient to version v4.0.0.alpha1 Signed-off-by: Daniel Miranda <danielkza2@gmail.com>
22 Feb, 2016
1 commit
-
There were outdated tests that did not update from the deprecated 'Average' aggregation form to 'Mean'. Fix that, while simultaneously refactoring the configuration creation and repository processing features, into a single 'golden path' that tests boths, ensuring a very common user task works as expected. Signed-off-by: Daniel Miranda <danielkza2@gmail.com>
12 Feb, 2016
1 commit
-
KalibroClient now expectes granularity as a hash with key type.
29 Jan, 2016
1 commit
-
This is expected to improve compatibility with reverse-proxies. Still, for full compatibility, regarding redirections, we still may need to set the default url options with the proxy host. Signed-off-by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
22 Jan, 2016
1 commit
-
Signed-off-by: Heitor Reis <marcheing@gmail.com>
20 Jan, 2016
12 commits
-
Test the path where the provided metric's type is different from the controller's one. Signed-off-by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
-
We were not testing the case when the returned metric_configuration was from a different KalibroConfiguration. This prevents different ownership MetricConfiguration editions and false positives for ownership_authentication helper. Signed off by: Heitor Reis <marcheing@gmail.com>
-
There was no test case for failed_action when the action was neither create or update. The coverage was achieved through show action with invalid reading group id. Signed-off-by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
-
It was missing proper mocks for the set_metric! before_action from BaseMetricConfigurationsController. Signed off by: Heitor Reis <marcheing@gmail.com>
-
All of it's code is covered by the concrete class tests, and the abstract class tests were nothing like real usage, and will be made totally obsolete with the refactor. Signed off by: Daniel Miranda <danielkza2@gmail.com>
-
- Fix usage of MetricConfiguration models converted directly to hashes as parameters. It didn't reflect how they are actually sent and omitted some necessary parameters like metric_collector_name and metric_name/metric_code, which are now passed. - Fix KalibroConfigurations not being searched by the controller methods. We must be sure they exist, and fail with a 404 if they don't instead of failing only in one of the ownership testing methods. - Update the expectations for cache cleaning to include both Hotspot and Tree MetricConfigurations Signed off by: Daniel Miranda <danielkza2@gmail.com>
-
Now it doesn't redirect to the tree metric configuration creation page after choosing a hotspot metric configuration Adds a bunch of code from removed commit ec4c3ef6f29aa34f3c58819df4f84725aff8bd60 that fixed the view after the modification introduced by 39bc97f568d6989ae98b1f5fd5452515ee54045f. It fixes the view to properly work with the path helper. This is a squash of two commits. Signed off by: Diego Araújo <diegoamc90@gmail.com> Signed off by: Heitor Reis <marcheing@gmail.com>
-
To decide betwen the different routes for tree metrics or hotspot metrics. Signed off by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
-
It has just the prototype for the method so its route works. This route will be useful when creating the upcoming helper method for metric configuration creation form. Signed off by: Heitor Reis <marcheing@gmail.com>
-
This will enable different actions for TreeMetricConfigurations and Hotspot ones. Signed off by: Diego Araújo <diegoamc90@gmail.com>
-
This test is necessary in order to provide proper coverage that allows a refactor. Signed off by: Diego Araújo <diegoamc90@gmail.com>
23 Nov, 2015
2 commits
-
Signed off by: Daniel Miranda <danielkza2@gmail.com>
-
Gitlab sends the 'X-Gitlab-Event' header for all the webhook requests. Verify it so we reduce the chance that robots call the hooks accidentally. Signed off by: Daniel Miranda <danielkza2@gmail.com>
19 Nov, 2015
1 commit
-
* Creates a step to create a ruby configuration with the Saikuro metric * Define new factories for a saikuro metric and saikuro metric configuration