20 Apr, 2016

1 commit

18 Apr, 2016

2 commits

16 Apr, 2016

1 commit

15 Apr, 2016

1 commit

13 Apr, 2016

1 commit

11 Apr, 2016

2 commits

  • 4734ba1b   Update header and request handling in tests ... Browse Dir » 
    The repository/notify_push feature was making post request directly
using Rack::Test methods, which is not optimal when we have Capybara to
handle all the driver setup and flexibility for us.

Change it to use Capybara methods, and fix all the steps accordingly. To
make things easier, add some helper methods to deal with headers in
different drivers.

Also fix a small clarity issue in the notify_push unity tests that also
have to set headers.
    Daniel
     
  • b2d7c543   Refactor Webhook support to allow verification of parameters ... Browse Dir » 
    Ensure webhook requests are only accepted after proper verification of
expected headers, repository address and branch, using the newly
implemented library.

To that effect, split up the logic to extract that information from
requests to it's own class, and use it in the notify_push action.

Also, add factories to make better testing of the notify_push action
possible, such as a factory similar to a real request from Gitlab, and
one for the Kalibro Client repository on Gitlab.

Adding other hook providers should be quite a lot easier after this is
applied.
    Daniel
     

30 Mar, 2016

1 commit

29 Jan, 2016

1 commit

  • 5ee25d55   Replace url helpers by the path ones ... Browse Dir » 
    This is expected to improve compatibility with reverse-proxies.

Still, for full compatibility, regarding redirections, we still may
need to set the default url options with the proxy host.

Signed-off-by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
    Heitor
     

20 Jan, 2016

8 commits

  • ed86c4b3   Add test for metric configuration creation with invalid metric ... Browse Dir » 
    Test the path where the provided metric's type is different from the
controller's one.

Signed-off-by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
    Heitor
     
  • 8c64ffc8   Coverup all metric_con finding branches on Base ... Browse Dir » 
    We were not testing the case when the returned metric_configuration was
from a different KalibroConfiguration.

This prevents different ownership MetricConfiguration editions and false
positives for ownership_authentication helper.

Signed off by: Heitor Reis <marcheing@gmail.com>
    Rafael Manzo
     
  • aaae2246   Cover MetricConfigurationsController failed_action ... Browse Dir » 
    There was no test case for failed_action when the action was neither
create or update. The coverage was achieved through show action with
invalid reading group id.

Signed-off-by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
    Heitor
     
  • 9f532746   Fix MetricConfigurationController#update unit test ... Browse Dir » 
    It was missing proper mocks for the set_metric! before_action from
BaseMetricConfigurationsController.

Signed off by: Heitor Reis <marcheing@gmail.com>
    Rafael Manzo
     
  • 20ed82ce   Fix Metric Configuration controllers unit tests Browse Dir »
    Daniel
     
  • 3d724355   Remove BaseMetricConfigurationsController unit test ... Browse Dir » 
    All of it's code is covered by the concrete class tests, and the
abstract class tests were nothing like real usage, and will be made
totally obsolete with the refactor.

Signed off by: Daniel Miranda <danielkza2@gmail.com>
    Heitor
     
  • 82bc8ca4   Update MetricConfiguration controllers' tests ... Browse Dir » 
    - Fix usage of MetricConfiguration models converted directly to hashes
as parameters. It didn't reflect how they are actually sent and omitted
some necessary parameters like metric_collector_name and
metric_name/metric_code, which are now passed.
- Fix KalibroConfigurations not being searched by the controller
methods. We must be sure they exist, and fail with a 404 if they don't
instead of failing only in one of the ownership testing methods.
- Update the expectations for cache cleaning to include both Hotspot and
Tree MetricConfigurations

Signed off by: Daniel Miranda <danielkza2@gmail.com>
    Heitor
     
  • c91af636   Add a redirect on hotspot metric configuration creation ... Browse Dir » 
    Now it doesn't redirect to the tree metric configuration creation page
after choosing a hotspot metric configuration

Adds a bunch of code from removed commit
ec4c3ef6f29aa34f3c58819df4f84725aff8bd60 that fixed the view after the
modification introduced by 39bc97f568d6989ae98b1f5fd5452515ee54045f.

It fixes the view to properly work with the path helper.

This is a squash of two commits.

Signed off by: Diego Araújo <diegoamc90@gmail.com>
Signed off by: Heitor Reis <marcheing@gmail.com>
    Heitor
     

23 Nov, 2015

2 commits

19 Nov, 2015

1 commit

18 Nov, 2015

1 commit

09 Nov, 2015

1 commit

  • 057737c7   Fix ProjectAttributes association with Project ... Browse Dir » 
      * Renamed ProjectAttributes' column hidden to public and inverted
    default values
  * Implemented Project#"public_or_owned_by_user"
  * All features now create ProjectAttributes after creating a Project
  * Implemented ProjectAttributes#project and ProjectAttributes#project=
  * Fix Project#attributes to return nil when there is no
    ProjectAttribute
  * Fixes #263

Signed off by: Diego Araújo <diegoamc90@gmail.com>
    Heitor
     

26 Oct, 2015

3 commits

14 Aug, 2015

1 commit

05 Aug, 2015

1 commit

30 Jul, 2015

2 commits

08 Jul, 2015

1 commit

06 Jul, 2015

1 commit

22 Jun, 2015

1 commit

17 Jun, 2015

2 commits

  • e19c7cef   Repository routes decoupled from Project ... Browse Dir » 
    new and create action can be acessed both with or without a project. This
enables to have repositories the two ways.

The behaviour for the back had to change from going back to a specific project
page. To the all projects pages since some repositories may not have a
project_id.

With the routes, many helpers had to get fixed together with acceptance
tests steps (for this a new step was created in order to be able to create
RepositoryAttributes).

Finally the JS for repository state retrieval needed fixes since it builds the
route withot any helper. Same thing for the JS that prevents infinite state
queries.

Signed off by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
    Pedro
     
  • 72b87ff3   Repository ownership checking uses RepositoryAttributes instead of Project Browse Dir »
    Rafael Manzo
     

16 Jun, 2015

2 commits

10 Jun, 2015

1 commit

08 Jun, 2015

1 commit

22 May, 2015

1 commit