17 Feb, 2016
1 commit
-
Now scope has a hash with key type.
29 Jan, 2016
1 commit
-
This is expected to improve compatibility with reverse-proxies. Still, for full compatibility, regarding redirections, we still may need to set the default url options with the proxy host. Signed-off-by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
22 Jan, 2016
3 commits
-
Calling methods with self improve the readability as it makes clear that it is not a variable but a method! Signed off by: Daniel Miranda <danielkza2@gmail.com>
-
It will never return nil. At most, it will raise a ActiveRecord::RecordNotFound Signed off by: Diego Araújo <diegoamc90@gmail.com>
-
Signed off by: Diego Araújo <diegoamc90@gmail.com>
20 Jan, 2016
6 commits
-
Signed-off-by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
-
The code is pretty straightforward, just raising an Error in order to force subclasses to implement this. Signed-off-by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
-
Also improve error reporting functions
-
Move as much code as possible to BaseMetricConfigurationsController instead of repeating it ad-hoc in the concrete classes. Most of the concrete code has gone away except for some small overrides: - Hotspot's does not have a 'new' action, and therefore can't redirect to it. It also does not accept any MetricConfiguration parameters. - Metric's only accepts 'weight' and 'aggregation_form' MetricConfiguration parameters. It also needs to fetch ReadingGroups to display in the 'choose_metric' action. - Compound's needs to force the Metric type when creating the metric, and must accept parameters for Metric ('name', 'description', 'script', 'scope', 'code') in addition to MetricConfiguration's 'weight'. Additionally: - Update cache clearing to clear caches for Hotspot and Tree configurations - Verify the existence of the KalibroConfiguration and use the object that was fetched whenever necessary, instead of only using the id. - Ensure the KalibroConfiguration and ReadingGroup ids match between the values inside and outside the 'metric_configuration' parameter. Previously it was possible to send one in the URL and update another, which might even have been a security issue. - Allow sending either 'metric_code' or 'metric_name' as a parameter. Both are used in different places in the code, but making them uniform is a job for a later time. Signed off by: Daniel Miranda <danielkza2@gmail.com> -
Now it doesn't redirect to the tree metric configuration creation page after choosing a hotspot metric configuration Adds a bunch of code from removed commit ec4c3ef6f29aa34f3c58819df4f84725aff8bd60 that fixed the view after the modification introduced by 39bc97f568d6989ae98b1f5fd5452515ee54045f. It fixes the view to properly work with the path helper. This is a squash of two commits. Signed off by: Diego Araújo <diegoamc90@gmail.com> Signed off by: Heitor Reis <marcheing@gmail.com>
-
It has just the prototype for the method so its route works. This route will be useful when creating the upcoming helper method for metric configuration creation form. Signed off by: Heitor Reis <marcheing@gmail.com>
12 Jan, 2016
1 commit
-
Using URL helpers is not friendly with proxies like Colab. The path helpers have the same effect unless we want sometime to render pages outside Prezento context like embeds or sending emails. Signed off by: Diego Araújo <diegoamc90@gmail.com>
23 Nov, 2015
2 commits
-
Signed off by: Daniel Miranda <danielkza2@gmail.com>
-
Gitlab sends the 'X-Gitlab-Event' header for all the webhook requests. Verify it so we reduce the chance that robots call the hooks accidentally. Signed off by: Daniel Miranda <danielkza2@gmail.com>
19 Nov, 2015
1 commit
-
* Includes this action in the list of actions that do not need user authentication. Signed-off-by: Heitor Reis <marcheing@gmail.com>
09 Nov, 2015
1 commit
-
* Renamed ProjectAttributes' column hidden to public and inverted default values * Implemented Project#"public_or_owned_by_user" * All features now create ProjectAttributes after creating a Project * Implemented ProjectAttributes#project and ProjectAttributes#project= * Fix Project#attributes to return nil when there is no ProjectAttribute * Fixes #263 Signed off by: Diego Araújo <diegoamc90@gmail.com>
28 Oct, 2015
1 commit
-
Signed off by: Eduardo Araújo <duduktamg@hotmail.com>
26 Oct, 2015
3 commits
-
The search and replace missed this. Now when a new CompoundMetriConfiguration gets created or updated the KalibroConfiguration show page gets a clear cache. Signed off by: Heitor Reis <marcheing@gmail.com>
-
Put a blank space between # and text and don't forget about tagging pending fixes with FIXME. Signed off by: Eduardo Araújo <duduktamg@hotmail.com>
-
Signed off by: Eduardo Silva Araújo <duduktamg@hotmail.com> Signed off by: Diego Araújo <diegoamc90@gmail.com>
11 Sep, 2015
1 commit
14 Aug, 2015
1 commit
08 Jul, 2015
2 commits
-
Fixed acceptance tests and removed project list selector from repository form Signed-off-by: Pedro Scocco <pedroscocco@gmail.com> Signed off by: Diego Araújo <diegoamc90@gmail.com>
-
Signed-off-by: Daniel Miranda <danielkza2@gmail.com>
06 Jul, 2015
1 commit
-
Signed off by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
24 Jun, 2015
1 commit
-
Signed off by: Daniel Miranda <danielkza2@gmail.com> Signed-off-by: Pedro Scocco <pedroscocco@gmail.com> Signed off by: Heitor Reis <marcheing@gmail.com>
22 Jun, 2015
1 commit
-
Actions new and create check if project_id was provided before trying to check the project ownership
17 Jun, 2015
2 commits
-
new and create action can be acessed both with or without a project. This enables to have repositories the two ways. The behaviour for the back had to change from going back to a specific project page. To the all projects pages since some repositories may not have a project_id. With the routes, many helpers had to get fixed together with acceptance tests steps (for this a new step was created in order to be able to create RepositoryAttributes). Finally the JS for repository state retrieval needed fixes since it builds the route withot any helper. Same thing for the JS that prevents infinite state queries. Signed off by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
16 Jun, 2015
2 commits
-
Signed-off-by: Pedro Scocco <pedroscocco@gmail.com>
-
Created javascript to show and hide the branch field. Created javascript to fetch the branches of a valid url of a git repository. New route repository_branches to communicate with kalibro_client. TODO: Fix acceptance tests. TODO: Handle errors on javascript. TODO: Extract javascript code to assets. TODO: Create a white list for the action branches of the repository's controller. Signed off by: Pedro Scocco <pedroscocco@gmail.com>
10 Jun, 2015
1 commit
08 Jun, 2015
1 commit
-
Generally rails will deal with this, but since we are already on a rescue it will not handle to avoid an infinite loop. So we need to deal with the error.
22 May, 2015
4 commits
-
group private. Signed off by: Heitor Reis <marcheing@gmail.com>
-
Signed off by: Heitor Reis <marcheing@gmail.com>
21 May, 2015
3 commits
-
…ng the kalibro configurations list Before they were not loaded leading to a exception when redering the edit view again.
-
Signed off by: Pedro Scocco <pedroscocco@gmail.com>
-
Signed-off-by: Daniel Miranda <danielkza2@gmail.com>