22 Feb, 2016
1 commit
-
There were outdated tests that did not update from the deprecated 'Average' aggregation form to 'Mean'. Fix that, while simultaneously refactoring the configuration creation and repository processing features, into a single 'golden path' that tests boths, ensuring a very common user task works as expected. Signed-off-by: Daniel Miranda <danielkza2@gmail.com>
17 Feb, 2016
3 commits
-
After kalibro_client upgrade, scope now has the type nested as a key.
-
Due to the kalibro_client upgrade, metric granularities are now actual object instances instead of hashes.
-
Now scope has a hash with key type.
12 Feb, 2016
1 commit
-
KalibroClient now expectes granularity as a hash with key type.
29 Jan, 2016
1 commit
-
This is expected to improve compatibility with reverse-proxies. Still, for full compatibility, regarding redirections, we still may need to set the default url options with the proxy host. Signed-off-by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
22 Jan, 2016
5 commits
-
Calling methods with self improve the readability as it makes clear that it is not a variable but a method! Signed off by: Daniel Miranda <danielkza2@gmail.com>
-
Signed-off-by: Heitor Reis <marcheing@gmail.com>
-
It will never return nil. At most, it will raise a ActiveRecord::RecordNotFound Signed off by: Diego Araújo <diegoamc90@gmail.com>
-
Signed off by: Diego Araújo <diegoamc90@gmail.com>
-
Signed off by: Diego Araújo <diegoamc90@gmail.com>
20 Jan, 2016
10 commits
-
Signed-off-by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
-
The code is pretty straightforward, just raising an Error in order to force subclasses to implement this. Signed-off-by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
-
Also improve error reporting functions
-
Move as much code as possible to BaseMetricConfigurationsController instead of repeating it ad-hoc in the concrete classes. Most of the concrete code has gone away except for some small overrides: - Hotspot's does not have a 'new' action, and therefore can't redirect to it. It also does not accept any MetricConfiguration parameters. - Metric's only accepts 'weight' and 'aggregation_form' MetricConfiguration parameters. It also needs to fetch ReadingGroups to display in the 'choose_metric' action. - Compound's needs to force the Metric type when creating the metric, and must accept parameters for Metric ('name', 'description', 'script', 'scope', 'code') in addition to MetricConfiguration's 'weight'. Additionally: - Update cache clearing to clear caches for Hotspot and Tree configurations - Verify the existence of the KalibroConfiguration and use the object that was fetched whenever necessary, instead of only using the id. - Ensure the KalibroConfiguration and ReadingGroup ids match between the values inside and outside the 'metric_configuration' parameter. Previously it was possible to send one in the URL and update another, which might even have been a security issue. - Allow sending either 'metric_code' or 'metric_name' as a parameter. Both are used in different places in the code, but making them uniform is a job for a later time. Signed off by: Daniel Miranda <danielkza2@gmail.com> -
There will no longer be a @kalibro_configuration_id instance variable, and all the views will use @metric_configuration, with no special cases like Compound previously had. Signed off by: Daniel Miranda <danielkza2@gmail.com>
-
There are no attributes to be edited on a hotspot metric configuration Signed off by: Diego Araújo <diegoamc90@gmail.com>
-
Now it doesn't redirect to the tree metric configuration creation page after choosing a hotspot metric configuration Adds a bunch of code from removed commit ec4c3ef6f29aa34f3c58819df4f84725aff8bd60 that fixed the view after the modification introduced by 39bc97f568d6989ae98b1f5fd5452515ee54045f. It fixes the view to properly work with the path helper. This is a squash of two commits. Signed off by: Diego Araújo <diegoamc90@gmail.com> Signed off by: Heitor Reis <marcheing@gmail.com>
-
To decide betwen the different routes for tree metrics or hotspot metrics. Signed off by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
-
It has just the prototype for the method so its route works. This route will be useful when creating the upcoming helper method for metric configuration creation form. Signed off by: Heitor Reis <marcheing@gmail.com>
-
This will enable different actions for TreeMetricConfigurations and Hotspot ones. Signed off by: Diego Araújo <diegoamc90@gmail.com>
12 Jan, 2016
1 commit
-
Using URL helpers is not friendly with proxies like Colab. The path helpers have the same effect unless we want sometime to render pages outside Prezento context like embeds or sending emails. Signed off by: Diego Araújo <diegoamc90@gmail.com>
23 Nov, 2015
2 commits
-
Signed off by: Daniel Miranda <danielkza2@gmail.com>
-
Gitlab sends the 'X-Gitlab-Event' header for all the webhook requests. Verify it so we reduce the chance that robots call the hooks accidentally. Signed off by: Daniel Miranda <danielkza2@gmail.com>
19 Nov, 2015
1 commit
-
* Includes this action in the list of actions that do not need user authentication. Signed-off-by: Heitor Reis <marcheing@gmail.com>
09 Nov, 2015
2 commits
-
* Closes Issue #218 KalibroClient returns 0 instead of nil when the module has no parent. Signed-off-by: Eduardo Silva Araújo <duduktamg@hotmail.com>
-
* Renamed ProjectAttributes' column hidden to public and inverted default values * Implemented Project#"public_or_owned_by_user" * All features now create ProjectAttributes after creating a Project * Implemented ProjectAttributes#project and ProjectAttributes#project= * Fix Project#attributes to return nil when there is no ProjectAttribute * Fixes #263 Signed off by: Diego Araújo <diegoamc90@gmail.com>
28 Oct, 2015
2 commits
-
* Also the previous conditional in the view was unnecessary because the kalibro_ranges method never returns nil, at most it returns an empty array, which is checked by another conditional in the same view Signed off by: Eduardo Araújo <duduktamg@hotmail.com>
-
Signed off by: Eduardo Araújo <duduktamg@hotmail.com>
26 Oct, 2015
11 commits
-
* It was showing the hash corresponding to the granularity, now it only shows the granularity's type Signed off by: Diego Araújo <diegoamc90@gmail.com>
-
* Now it is correctly checking for the names of the files in the repositories#show page Signed off by: Diego Araújo <diegoamc90@gmail.com>
-
* Also renamed some step definitions to explicitly use tree metric configurations or hotspot metric configurations * Also added translations for the cases when there are no metric configurations of each type * Showing name and code on the table for hotspot metric configurations * When adding a hotspot metric configuration, the weight will be Signed off by: Diego Araújo <diegoamc90@gmail.com>
-
* The acceptance test got ambiguous when trying to assert for links inside metric configuration tables. Signed off by: Rafael Reggiani Manzo <rr.manzo@gmail.com> -
The search and replace missed this. Now when a new CompoundMetriConfiguration gets created or updated the KalibroConfiguration show page gets a clear cache. Signed off by: Heitor Reis <marcheing@gmail.com>
-
Put a blank space between # and text and don't forget about tagging pending fixes with FIXME. Signed off by: Eduardo Araújo <duduktamg@hotmail.com>
-
Signed off by: Eduardo Silva Araújo <duduktamg@hotmail.com> Signed off by: Diego Araújo <diegoamc90@gmail.com>
-
* WIP: cucumber feature to show hotspot metric results * Add partials to list hotspot metric results * Add necessary JS to render the list of hotspot metric results on the right place div of the accordion * Translations specific to hotspot metric results * HotspotMetric and HotspotMetricConfiguration factories Signed off by: Eduardo Silva Araújo <duduktamg@hotmail.com>
-
* Includes translations * Replaces "Metric Results" with "Tree Metric Results" * Creates a feature for hotspot metric results * Handles the view when the processing fails Signed off by: Eduardo Silva Araújo <duduktamg@hotmail.com>
-
The test was wipped and forgotten long ago and now been bought back to life! Signed off by: Heitor Reis <marcheing@gmail.com>
-
* Currently using tree_metric_results to get the results from the module Signed off by: Diego Araújo <diegoamc90@gmail.com>