Merge Request #7

Merged
noosfero-themes/angular-theme!7
Created by Victor Costa

Frontend for comment paragraph plugin

Also:

  1. Add macro directive for articles
  2. Load components defined in plugins
  3. Add plugins in gulp build
  4. Create infra for plugins hotspots
  5. Merge plugin languages when building with gulp
  6. Improve visualization of comment's replies
Assignee: None
Milestone: 2016.05

Merged by Michel Felipe

Source branch has been removed
Commits (16)
3 participants
  • 4a20548511a65cfccc863520b70c3ee9?s=40&d=identicon
    Victor Costa @vfcosta

    Added 1 new commit:

    • 5dcbc016 - Limit comments identation and display replied comment in tooltip
    Choose File ...   File name...
    Cancel
  • 5bf9bf341e9d00ebd854cdaf1a4299b2?s=40&d=identicon
    Leandro Santos @leandronunes

    Milestone changed to 2016.05

    Choose File ...   File name...
    Cancel
  • Me
    Michel Felipe @mfdeveloper

    Reassigned to @mfdeveloper

    Choose File ...   File name...
    Cancel
  • Me
    Michel Felipe @mfdeveloper (Edited )

    Farei o merge pela urgência, mas dê uma olhada nos comentários @vfcosta. Em linhas gerais, o ideal é documentar as classes de plugin e de decorators de hostspot usando o @ngdoc. Além disso, não estou completamente certo se a abordagem de ter criado @Hotspot como um decorator e uma classe Plugins e seus plugins front-end herdando delas é realmente o melhor a ser feito. Tlvz padronizar (ambos serem classes pai, ou ambos serem decorators). È interessante uma reflexão acerca disso, uma vez q isso será genérico e "padrão" para tdos os plugins q venhamos a desenvolver no decorrer do tempo. Me deu a impressão de estarmos apenas tentando "adaptar" a abordagem de Plugins criada pelo noosfero com pouca mudança, sendo que, não sei se realmente é o melhor a fazer :(

    Além disso, achei os nomes dos arquivos muito grandes. A estrutura de pastas dentro desse plugin criado segue uma organização um pouco diferente dos componentes do core, o que pode ocasionar em confusão. Acho de grande importãncia documentar essa parte e o um exemplo de uso disto.

    Choose File ...   File name...
    Cancel
  • Me
    Michel Felipe @mfdeveloper

    Added 49 new commits:

    • 2abc9dd1 - Updated typescript version
    • 01d73906 - Upgrade Vagrantfile with shared folder
    • da7503d7 - Update gitignore with vagrant
    • e4637b83 - Merge branch 'devenv-update' into 'master'
    • ea217b65 - Fix bug in build task
    • 00882cc3 - changed to use @Output on post-comment-component to propagate event to the comme…
    • 45e13641 - Merge branch 'comments'
    • fc86b9f5 - Refactory into ComponentTestHelper and helpers.ts with improvements
    • 0e6cfa00 - Merge branch 'component-test-improvements' into 'master'
    • ed34cf65 - Support ckeditor in article edition
    • 28d86107 - Support storage of current object in generic restangular service
    • 2259690d - Create article and associate it to parent
    • a5984494 - Move basic editor to its own folder
    • ecac812c - Add cancel button in basic editor
    • ed2107bd - Translate basic editor component
    • 33ae65dd - Adapt basic editor to edit an existing article
    • 8f0e4db1 - Create component to encapsulate wysiwyg editor
    • 6b15acb7 - Add article edit button
    • ba389ecc - Edit visibility status of an article
    • 00eaab03 - Display basic error message when fail to save an article
    • 5f9ef2ae - Refactor tests of content viewer actions to use ComponentTestHelper
    • 1894afc0 - Merge branch 'create-article' into 'master'
    • 8616dd98 - Add missing type arguments from members and people blocks
    • dcc1120f - Fix styles watch from gulp
    • 8362948a - adding participa consulta theme
    • e59add5d - Created sidebar component with sass and a service to show/hide using Angular 2 EventEmitter sintax
    • 4c39bd75 - Added hamburguer sidebar toggle button to show only after login
    • 41cad538 - Refactory into unit tests to use EventEmitter mocks
    • f711ee9c - Refactory into ComponentTestHelper and sidebar unit tests enhancements
    • dd6a4819 - Added feature to sidebar pushing right content on show/hide
    • af427f22 - Created SidebarSectionsComponent with a dinamic menu/submenu
    • 7e4cecee - Added @ngdoc documentation and refactor the SidebarSection component
    • c0fd7cf6 - Merge branch 'sidebar-menu' into 'master'
    • 2cafe5da - Add macro directive for articles
    • 4b4877ed - Load components defined in plugins
    • 33544a8b - Add plugins in gulp build
    • 31b34a75 - Display paragraph comments besides the article
    • 1f246d3f - Load comments by paragraph
    • 56a44bd2 - Create infra for plugins hotspots
    • 5deddf45 - Set parahraph uuid when create comments in paragraphs
    • abdfbb35 - Activate/deactivate comment paragraph in articles
    • b77b920c - Emit event when toggle comment paragraph in articles
    • 8a1cb95c - Display comment counts beside paragraphs
    • 65c6a4ac - Merge plugin languages when building with gulp
    • 9bf4d461 - Improve layout of comment paragraph plugin
    • 7b6978a6 - Fix html path in karma conf
    • f98ac330 - Add tests for comment paragraph plugin
    • 4840baa9 - Add paragraph uuid in comment form
    • 800e2559 - Limit comments identation and display replied comment in tooltip
    Choose File ...   File name...
    Cancel
  • Me
    Michel Felipe @mfdeveloper

    Assignee removed

    Choose File ...   File name...
    Cancel
  • Me
    Michel Felipe @mfdeveloper
    Choose File ...   File name...
    Cancel