Don't crash migration on save if IssueTracker doesn't have username or password

Nathan Broadbent
1 parent 4cd24a8b
Showing 2 changed files with 2 additions and 2 deletions Show diff stats
app/models/issue_trackers/github_issues_tracker.rb
db/migrate/20120603112130_change_github_url_to_github_repo.rb
@@ -21,7 +21,7 @@ class IssueTrackers::GithubIssuesTracker &lt; IssueTracker
  
   def check_params
     if Fields.detect {|f| self[f[0]].blank? }
-      errors.add :base, 'You must specify your GitHub repository, username and password'
+      errors.add :base, 'You must specify your GitHub username and password'
     end
   end
  
@@ -3,7 +3,7 @@ class ChangeGithubUrlToGithubRepo &lt; Mongoid::Migration
     App.collection.update({}, {'$rename' => {'github_url' => 'github_repo'}}, multi: true, safe: true)
     App.all.each do |app|
       app.send :normalize_github_repo
-      app.save!
+      app.save
     end
   end
...	...	@@ -21,7 +21,7 @@ class IssueTrackers::GithubIssuesTracker < IssueTracker
21	21
22	22	def check_params
23	23	if Fields.detect {\|f\| self[f[0]].blank? }
24		- errors.add :base, 'You must specify your GitHub repository, username and password'
	24	+ errors.add :base, 'You must specify your GitHub username and password'
25	25	end
26	26	end
27	27
...	...
...	...	@@ -3,7 +3,7 @@ class ChangeGithubUrlToGithubRepo < Mongoid::Migration
3	3	App.collection.update({}, {'$rename' => {'github_url' => 'github_repo'}}, multi: true, safe: true)
4	4	App.all.each do \|app\|
5	5	app.send :normalize_github_repo
6		- app.save!
	6	+ app.save
7	7	end
8	8	end
9	9
...	...