Download as
Browse Code »

Commit 929e795aba1c09a217a1a755fd8ed70c39f793dd

Authored by Dave Miller
1 parent 88004758
Exists in master and in 1 other branch production

Treat request URL as CDATA so query string params don't result in invalid XML

Showing 3 changed files with 3 additions and 3 deletions   Show diff stats
public/javascripts/notifier.js
  Diff comments   View file @929e795
@@ -506,7 +506,7 @@ printStackTrace.implementation.prototype = { @@ -506,7 +506,7 @@ printStackTrace.implementation.prototype = {
506 '<backtrace>{backtrace_lines}</backtrace>' + 506 '<backtrace>{backtrace_lines}</backtrace>' +
507 '</error>' + 507 '</error>' +
508 '<request>' + 508 '<request>' +
509 - '<url>{request_url}</url>' + 509 + '<url><![CDATA[{request_url}]]></url>' +
510 '<component>{request_component}</component>' + 510 '<component>{request_component}</component>' +
511 '<action>{request_action}</action>' + 511 '<action>{request_action}</action>' +
512 '{request}' + 512 '{request}' +
spec/fixtures/hoptoad_test_notice.xml
  Diff comments   View file @929e795
@@ -87,7 +87,7 @@ @@ -87,7 +87,7 @@
87 </backtrace> 87 </backtrace>
88 </error> 88 </error>
89 <request> 89 <request>
90 - <url>http://example.org/verify</url> 90 + <url><![CDATA[http://example.org/verify/cupcake=fistfight&lovebird=doomsayer]]></url>
91 <component>application</component> 91 <component>application</component>
92 <action>verify</action> 92 <action>verify</action>
93 <params> 93 <params>
spec/models/error_report_spec.rb
  Diff comments   View file @929e795
@@ -84,7 +84,7 @@ describe ErrorReport do @@ -84,7 +84,7 @@ describe ErrorReport do
84 end 84 end
85 85
86 it 'has request' do 86 it 'has request' do
87 - subject.request['url'].should == 'http://example.org/verify' 87 + subject.request['url'].should == 'http://example.org/verify/cupcake=fistfight&lovebird=doomsayer'
88 subject.request['params']['controller'].should == 'application' 88 subject.request['params']['controller'].should == 'application'
89 end 89 end
90 90