Commit 98f4db155e230af6321f049a65da01af006a1894
1 parent
9408ceef
Exists in
master
and in
1 other branch
Fixed line spacing for backtrace, added blank space for empty line numbers
Showing
2 changed files
with
14 additions
and
4 deletions
Show diff stats
app/views/notices/_backtrace.html.haml
@@ -4,8 +4,11 @@ | @@ -4,8 +4,11 @@ | ||
4 | %th | 4 | %th |
5 | %ul.line-numbers | 5 | %ul.line-numbers |
6 | - lines.each do |line| | 6 | - lines.each do |line| |
7 | - %li= (@app.github_url? && Notice.in_app_backtrace_line?(line)) ? link_to_github(@app, line, line['number']) : line['number'] | ||
8 | - | 7 | + %li |
8 | + - if line['number'].present? | ||
9 | + = (@app.github_url? && Notice.in_app_backtrace_line?(line)) ? link_to_github(@app, line, line['number']) : line['number'] | ||
10 | + - else | ||
11 | + | ||
9 | %td | 12 | %td |
10 | %ul.lines | 13 | %ul.lines |
11 | - lines.each do |line| | 14 | - lines.each do |line| |
public/stylesheets/application.css
@@ -691,16 +691,23 @@ table.backtrace td { | @@ -691,16 +691,23 @@ table.backtrace td { | ||
691 | background-color: #222 !important; | 691 | background-color: #222 !important; |
692 | } | 692 | } |
693 | table.backtrace ul.line-numbers li { | 693 | table.backtrace ul.line-numbers li { |
694 | + border-bottom: 0; | ||
694 | text-align: right; | 695 | text-align: right; |
696 | + font-size: 13px; | ||
697 | + line-height: 21px; | ||
695 | } | 698 | } |
699 | + | ||
696 | table.backtrace ul.lines { | 700 | table.backtrace ul.lines { |
697 | padding: 10px 8px; | 701 | padding: 10px 8px; |
698 | overflow: auto; | 702 | overflow: auto; |
699 | } | 703 | } |
700 | -table.backtrace li { | 704 | +table.backtrace ul.lines li { |
705 | + border-bottom: 1px solid #2B2B2B; | ||
706 | + font-size: 13px; | ||
707 | + line-height: 20px; | ||
701 | white-space: nowrap; | 708 | white-space: nowrap; |
702 | } | 709 | } |
703 | -table.backtrace li.in-app { | 710 | +table.backtrace ul.lines li.in-app { |
704 | color: #2adb2e; | 711 | color: #2adb2e; |
705 | background-color: #2f2f2f; | 712 | background-color: #2f2f2f; |
706 | } | 713 | } |