Download as
Browse Code »

Commit c7b8e0fd7643e7803f2cf061df67220cd847e484

Authored by Shuky Dvir
1 parent 385edff2
Exists in master and in 1 other branch production

making the app index more nice

Showing 2 changed files with 4 additions and 8 deletions   Show diff stats
app/helpers/notices_helper.rb
  Diff comments   View file @c7b8e0f
@@ -33,7 +33,7 @@ module NoticesHelper @@ -33,7 +33,7 @@ module NoticesHelper
33 33
34 def link_to_bitbucket(app, line, text = nil) 34 def link_to_bitbucket(app, line, text = nil)
35 file_name, file_path = filepath_parts(line['file']) 35 file_name, file_path = filepath_parts(line['file'])
36 - href = "%s#L%s" % [app.bitbucket_url_to_file(file_path), line['number']] 36 + href = "%s#cl-%s" % [app.bitbucket_url_to_file(file_path), line['number']]
37 link_to(text || file_name, href, :target => '_blank') 37 link_to(text || file_name, href, :target => '_blank')
38 end 38 end
39 39
app/views/apps/index.html.haml
  Diff comments   View file @c7b8e0f
@@ -6,10 +6,8 @@ @@ -6,10 +6,8 @@
6 %thead 6 %thead
7 %tr 7 %tr
8 %th Name 8 %th Name
9 - - if any_github_repos?  
10 - %th GitHub Repo  
11 - - if any_bitbucket_repos?  
12 - %th Bitbucket Repo 9 + - if any_github_repos? or any_bitbucket_repos?
  10 + %th Repository
13 - if any_issue_trackers? 11 - if any_issue_trackers?
14 %th Tracker 12 %th Tracker
15 - if any_deploys? 13 - if any_deploys?
@@ -19,12 +17,10 @@ @@ -19,12 +17,10 @@
19 - @apps.each do |app| 17 - @apps.each do |app|
20 %tr 18 %tr
21 %td.name= link_to app.name, app_path(app) 19 %td.name= link_to app.name, app_path(app)
22 - - if any_github_repos? 20 + - if any_github_repos? or any_bitbucket_repos?
23 %td.github_repo 21 %td.github_repo
24 - if app.github_repo? 22 - if app.github_repo?
25 = link_to(app.github_repo, app.github_url, :target => '_blank') 23 = link_to(app.github_repo, app.github_url, :target => '_blank')
26 - - if any_bitbucket_repos?  
27 - %td.github_repo  
28 - if app.bitbucket_repo? 24 - if app.bitbucket_repo?
29 = link_to(app.bitbucket_repo, app.bitbucket_url, :target => '_blank') 25 = link_to(app.bitbucket_repo, app.bitbucket_url, :target => '_blank')
30 - if any_issue_trackers? 26 - if any_issue_trackers?