Download as
Browse Code »

Commit 1af65c96c952fd7b02b24cae34e526d7dd7b5950

Authored by Jacob Vosmaer
1 parent 845b98ec
Exists in master and in 4 other branches 6-8-stable, 7-0-stable, 7-0-stable-spb, spb-stable

Avoid duplicate group membership emails

Showing 2 changed files with 6 additions and 1 deletions   Show diff stats
app/observers/users_group_observer.rb
  Diff comments   View file @1af65c9
@@ -4,6 +4,6 @@ class UsersGroupObserver < BaseObserver @@ -4,6 +4,6 @@ class UsersGroupObserver < BaseObserver
4 end 4 end
5 5
6 def after_update(membership) 6 def after_update(membership)
7 - notification.update_group_member(membership) 7 + notification.update_group_member(membership) if membership.group_access_changed?
8 end 8 end
9 end 9 end
spec/observers/users_group_observer_spec.rb
  Diff comments   View file @1af65c9
@@ -23,5 +23,10 @@ describe UsersGroupObserver do @@ -23,5 +23,10 @@ describe UsersGroupObserver do
23 subject.should_receive(:notification) 23 subject.should_receive(:notification)
24 @membership.update_attribute(:group_access, UsersGroup::MASTER) 24 @membership.update_attribute(:group_access, UsersGroup::MASTER)
25 end 25 end
  26 +
  27 + it "does not send an email when the access level has not changed" do
  28 + subject.should_not_receive(:notification)
  29 + @membership.update_attribute(:group_access, UsersGroup::OWNER)
  30 + end
26 end 31 end
27 end 32 end