Fail faster on an invalid target_type

Jacob Vosmaer
1 parent e5cf5f4f
Showing 2 changed files with 7 additions and 0 deletions Show diff stats
app/finders/notes_finder.rb
spec/finders/notes_finder_spec.rb
@@ -12,6 +12,8 @@ class NotesFinder
       project.merge_requests.find(target_id).mr_and_commit_notes.inc_author.fresh
     when "snippet"
       project.snippets.find(target_id).notes.fresh
+    else
+      raise 'invalid target_type'
     end
   end
 end
@@ -22,5 +22,10 @@ describe NotesFinder do
       notes = NotesFinder.new.execute(project, user, params)
       notes.size.should eq(2)
     end
+
+    it 'should raise an exception for an invalid target_type' do
+      params = { target_id: commit.id, target_type: 'invalid' }
+      expect { NotesFinder.new.execute(project, user, params) }.to raise_error('invalid target_type')
+    end
   end
 end
...	...	@@ -12,6 +12,8 @@ class NotesFinder
12	12	project.merge_requests.find(target_id).mr_and_commit_notes.inc_author.fresh
13	13	when "snippet"
14	14	project.snippets.find(target_id).notes.fresh
	15	+ else
	16	+ raise 'invalid target_type'
15	17	end
16	18	end
17	19	end
...	...
...	...	@@ -22,5 +22,10 @@ describe NotesFinder do
22	22	notes = NotesFinder.new.execute(project, user, params)
23	23	notes.size.should eq(2)
24	24	end
	25	+
	26	+ it 'should raise an exception for an invalid target_type' do
	27	+ params = { target_id: commit.id, target_type: 'invalid' }
	28	+ expect { NotesFinder.new.execute(project, user, params) }.to raise_error('invalid target_type')
	29	+ end
25	30	end
26	31	end
...	...