Commit 7339464e7701c0778cca12c12ace83ebd8ffe2f7
1 parent
e5cf5f4f
Exists in
spb-stable
and in
2 other branches
Fail faster on an invalid target_type
Showing
2 changed files
with
7 additions
and
0 deletions
Show diff stats
app/finders/notes_finder.rb
| @@ -12,6 +12,8 @@ class NotesFinder | @@ -12,6 +12,8 @@ class NotesFinder | ||
| 12 | project.merge_requests.find(target_id).mr_and_commit_notes.inc_author.fresh | 12 | project.merge_requests.find(target_id).mr_and_commit_notes.inc_author.fresh |
| 13 | when "snippet" | 13 | when "snippet" |
| 14 | project.snippets.find(target_id).notes.fresh | 14 | project.snippets.find(target_id).notes.fresh |
| 15 | + else | ||
| 16 | + raise 'invalid target_type' | ||
| 15 | end | 17 | end |
| 16 | end | 18 | end |
| 17 | end | 19 | end |
spec/finders/notes_finder_spec.rb
| @@ -22,5 +22,10 @@ describe NotesFinder do | @@ -22,5 +22,10 @@ describe NotesFinder do | ||
| 22 | notes = NotesFinder.new.execute(project, user, params) | 22 | notes = NotesFinder.new.execute(project, user, params) |
| 23 | notes.size.should eq(2) | 23 | notes.size.should eq(2) |
| 24 | end | 24 | end |
| 25 | + | ||
| 26 | + it 'should raise an exception for an invalid target_type' do | ||
| 27 | + params = { target_id: commit.id, target_type: 'invalid' } | ||
| 28 | + expect { NotesFinder.new.execute(project, user, params) }.to raise_error('invalid target_type') | ||
| 29 | + end | ||
| 25 | end | 30 | end |
| 26 | end | 31 | end |