Software Publico / Gitlab

06 Feb, 2013

3 commits

41e93bbf Test added to check creation of note to a non-existent MR via API Browse Dir »

Sebastian Ziebell
2013-02-06 17:05:55 +0100

f978a71f Creating MR comment without a note returns status code 400 (Bad request) ... Browse Dir »

Creating a comment to an existing merge request via API without providing a note
returns a status code 400 now, suggesting a bad request. The reason for this
is the resource itself (MR) exists but the required property is not set.

2013-02-06 17:02:30 +0100

413952ff Creating or updating a MR returns more informative status codes. ... Browse Dir »

Using the API library to create or update a merge request at the moment a 404 error is returned.
This is fine when the merge request in question does not exist, but does not provide good
information that for example a required attribute is missing.
A status code of 400 (Bad request) is returned when creating or updating a merge request
when either `source_branch` or `target_branch` is missing. A status code of 409 is returned
when `source_branch` and `target_branch` are the same. Tests are added for these cases.

2013-02-06 16:57:00 +0100

01 Feb, 2013

1 commit

ce6436b9 Don't crash when removing a user that's not project member ... Browse Dir »

The attempt to revoke project access for a user that was not member of the
project results in a 500 Internal Server error where it actually should
result in a 200 OK since after the operation, the user is not member of
the project. This turns the operation into an idempotent call that can
be repeated with no ill effects.

Updated the spec and changed the code accordingly. However, the result differs
slightly, as we can't return the users project access level if the user was not
member. I'm not aware if anybody relies on the result of this call.

Fixes #2832

2013-02-01 13:53:35 +0000

27 Jan, 2013

1 commit

7175b6a7 Fixed dashboard show specs Browse Dir »

Dmitriy Zaporozhets
2013-01-27 13:20:23 +0200

18 Jan, 2013

1 commit

296cdd59 Add optional signup. Browse Dir »

Marin Jankovski
2013-01-18 11:57:31 +0100

15 Jan, 2013

8 commits

fd522b32 should be green build now :) Browse Dir »

Dmitriy Zaporozhets
2013-01-15 19:18:52 +0200
cc54c66f Fix spec/requests/notes_on_merge_requests_spec.r Browse Dir »

Dmitriy Zaporozhets
2013-01-15 18:20:58 +0200
2191efd8 fix notes_on_wall specs Browse Dir »

Dmitriy Zaporozhets
2013-01-15 15:04:22 +0200
ac983319 fixing some test Browse Dir »

Dmitriy Zaporozhets
2013-01-15 12:42:54 +0200
d28176b1 Replace commit diff note request specs with spinach features Browse Dir »

Riyad Preukschas
2013-01-15 00:52:57 +0100
f8e1f4a7 Replace commit note request specs with spinach features Browse Dir »

Riyad Preukschas
2013-01-15 00:52:55 +0100

30227869 Merge commit 'master' into discussions ... Browse Dir »

Conflicts:
	app/assets/stylesheets/sections/notes.scss
	app/contexts/notes/load_context.rb
	app/models/project.rb
	app/observers/note_observer.rb
	app/roles/votes.rb
	app/views/commit/show.html.haml
	app/views/merge_requests/_show.html.haml
	app/views/merge_requests/diffs.js.haml
	app/views/merge_requests/show.js.haml
	app/views/notes/_note.html.haml
	features/steps/project/project_merge_requests.rb
	spec/models/note_spec.rb

2013-01-15 00:52:25 +0100